Skip to content

Commit

Permalink
Android WebView: don't switch debug/release automatically.
Browse files Browse the repository at this point in the history
Changing build config based on TARGET_BUILD_VARIANT breaks the buildbots
downstream; just default it to Release all the time. Developers can
manually specify GYP_CONFIGURATION=Debug at make time.

NOTRY=true
BUG=
R=benm@chromium.org

Review URL: https://codereview.chromium.org/19463006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212014 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
torne@chromium.org committed Jul 17, 2013
1 parent d6adbef commit 56063a1
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,9 @@ CHROMIUM_DIR := $(call my-dir)
# WebView build using the Android build system.
ifneq (,$(wildcard $(CHROMIUM_DIR)/GypAndroid.$(HOST_OS)-$(TARGET_ARCH).mk))

ifeq ($(TARGET_BUILD_VARIANT),eng)
GYP_CONFIGURATION := Debug
else
# We default to release for the Android build system. Developers working on
# WebView code can build with "make GYP_CONFIGURATION=Debug".
GYP_CONFIGURATION := Release
endif

include $(CHROMIUM_DIR)/GypAndroid.$(HOST_OS)-$(TARGET_ARCH).mk
include $(CHROMIUM_DIR)/android_webview/Android.mk
Expand Down

0 comments on commit 56063a1

Please sign in to comment.