Skip to content

Commit

Permalink
Enable some more targets in the GN build.
Browse files Browse the repository at this point in the history
Fixes a warning in the sandbox code. GYP must compile this file with reduced warnings, but it's a valid warning so it seems better to fix than suppress.

Review URL: https://codereview.chromium.org/317733007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274922 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
brettw@chromium.org committed Jun 4, 2014
1 parent fee41a7 commit 543f171
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
13 changes: 7 additions & 6 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ group("root") {
"//content/public/common",
"//content/public/renderer",
"//crypto",
"//extensions/common/api:extensions_api",
"//dbus",
"//device/usb",
#"//extensions/common/api:extensions_api",
"//gin",
"//gpu",
"//google_apis",
Expand All @@ -49,7 +49,7 @@ group("root") {
"//net",
"//ppapi:ppapi_c",
"//printing",
#"//sandbox",
"//sandbox",
"//sdch",
"//skia",
"//sql",
Expand All @@ -63,6 +63,7 @@ group("root") {
"//third_party/libusb",
"//third_party/libwebm",
"//third_party/libwebp",
"//third_party/libyuv",
"//third_party/mesa",
"//third_party/ots",
"//third_party/protobuf:protobuf_lite",
Expand All @@ -71,9 +72,7 @@ group("root") {
"//third_party/smhasher:cityhash",
"//third_party/smhasher:murmurhash3",
"//third_party/smhasher:pmurhash",
# TODO(brettw) re-enable once the unused variables in this .gn file are
# fixed and rolled into Chrome.
#"//third_party/WebKit/Source/platform",
"//third_party/WebKit/Source/platform",
"//third_party/WebKit/Source/wtf",
"//third_party/zlib",
"//third_party:jpeg",
Expand Down Expand Up @@ -120,10 +119,12 @@ group("root") {
"//content/public/common",
"//content/public/renderer",
"//dbus",
"//extensions/common/api:extensions_api",
"//ppapi:ppapi_c",
"//third_party/libusb",
#"//third_party/WebKit/Source/platform",
"//third_party/WebKit/Source/platform",
"//third_party/WebKit/Source/wtf", # TODO(brettw) re-enable for Android.
"//sandbox",
"//tools/gn",

# Not tested on Android yet:
Expand Down
2 changes: 1 addition & 1 deletion sandbox/linux/suid/process_util_linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,5 @@ bool AdjustOOMScore(pid_t process, int score) {

ssize_t bytes_written = write(fd, buf, len);
close(fd);
return (bytes_written == len);
return (bytes_written == (ssize_t)len);
}

0 comments on commit 543f171

Please sign in to comment.