Remove all remaining traces of MessageLoopProxy.

TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2133083002
Cr-Commit-Position: refs/heads/master@{#404480}

PRESUBMIT.py

@@ -277,18 +277,6 @@
         r'extensions[\\\/]renderer[\\\/]safe_builtins\.*',
       ),
     ),
-    (
-      '\<MessageLoopProxy\>',
-      (
-        'MessageLoopProxy is deprecated. ',
-        'Please use SingleThreadTaskRunner or ThreadTaskRunnerHandle instead.'
-      ),
-      True,
-      (
-        # Internal message_loop related code may still use it.
-        r'^base[\\\/]message_loop[\\\/].*',
-      ),
-    ),
     (
       '#pragma comment(lib,',
       (

android_webview/browser/aw_browser_context.cc

@@ -73,7 +73,7 @@ AwBrowserContext* g_browser_context = NULL;
 std::unique_ptr<net::ProxyConfigService> CreateProxyConfigService() {
   std::unique_ptr<net::ProxyConfigService> config_service =
       net::ProxyService::CreateSystemProxyConfigService(
-          BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO),
+          BrowserThread::GetTaskRunnerForThread(BrowserThread::IO),
           nullptr /* Ignored on Android */);
 
   // TODO(csharrison) Architect the wrapper better so we don't need a cast for
@@ -98,7 +98,7 @@ policy::URLBlacklistManager* CreateURLBlackListManager(
   scoped_refptr<base::SequencedTaskRunner> background_task_runner =
       pool->GetSequencedTaskRunner(pool->GetSequenceToken());
   scoped_refptr<base::SingleThreadTaskRunner> io_task_runner =
-      BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO);
+      BrowserThread::GetTaskRunnerForThread(BrowserThread::IO);
 
   return new policy::URLBlacklistManager(pref_service, background_task_runner,
                                          io_task_runner, segment_url_callback,

android_webview/browser/aw_form_database_service.cc

@@ -28,16 +28,16 @@ namespace android_webview {
 
 AwFormDatabaseService::AwFormDatabaseService(const base::FilePath path) {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  web_database_ = new WebDatabaseService(path.Append(kWebDataFilename),
-      BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI),
-      BrowserThread::GetMessageLoopProxyForThread(BrowserThread::DB));
+  web_database_ = new WebDatabaseService(
+      path.Append(kWebDataFilename),
+      BrowserThread::GetTaskRunnerForThread(BrowserThread::UI),
+      BrowserThread::GetTaskRunnerForThread(BrowserThread::DB));
   web_database_->AddTable(base::WrapUnique(new autofill::AutofillTable));
   web_database_->LoadDatabase();
 
   autofill_data_ = new autofill::AutofillWebDataService(
-      web_database_,
-      BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI),
-      BrowserThread::GetMessageLoopProxyForThread(BrowserThread::DB),
+      web_database_, BrowserThread::GetTaskRunnerForThread(BrowserThread::UI),
+      BrowserThread::GetTaskRunnerForThread(BrowserThread::DB),
       base::Bind(&DatabaseErrorCallback));
   autofill_data_->Init();
 }

android_webview/browser/net/aw_url_request_context_getter.cc

@@ -178,7 +178,7 @@ AwURLRequestContextGetter::AwURLRequestContextGetter(
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
   scoped_refptr<base::SingleThreadTaskRunner> io_thread_proxy =
-      BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO);
+      BrowserThread::GetTaskRunnerForThread(BrowserThread::IO);
 
   auth_server_whitelist_.Init(
       prefs::kAuthServerWhitelist, user_pref_service,
@@ -243,7 +243,7 @@ void AwURLRequestContextGetter::InitializeURLRequestContext() {
   cache_params.path = cache_path_;
   builder.EnableHttpCache(cache_params);
   builder.SetFileTaskRunner(
-      BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE));
+      BrowserThread::GetTaskRunnerForThread(BrowserThread::CACHE));
 
   net::URLRequestContextBuilder::HttpNetworkSessionParams
       network_session_params;
@@ -278,7 +278,7 @@ net::URLRequestContext* AwURLRequestContextGetter::GetURLRequestContext() {
 
 scoped_refptr<base::SingleThreadTaskRunner>
 AwURLRequestContextGetter::GetNetworkTaskRunner() const {
-  return BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO);
+  return BrowserThread::GetTaskRunnerForThread(BrowserThread::IO);
 }
 
 void AwURLRequestContextGetter::SetHandlersAndInterceptors(

android_webview/native/aw_contents.cc

@@ -174,7 +174,7 @@ AwContents::AwContents(std::unique_ptr<WebContents> web_contents)
       functor_(nullptr),
       browser_view_renderer_(
           this,
-          BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI)),
+          BrowserThread::GetTaskRunnerForThread(BrowserThread::UI)),
       web_contents_(std::move(web_contents)),
       renderer_manager_key_(GLViewRendererManager::GetInstance()->NullKey()) {
   base::subtle::NoBarrier_AtomicIncrement(&g_instance_count, 1);

android_webview/native/aw_gl_functor.cc

@@ -33,7 +33,7 @@ AwGLFunctor::AwGLFunctor(const JavaObjectWeakGlobalRef& java_ref)
     : java_ref_(java_ref),
       render_thread_manager_(
           this,
-          BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI)) {
+          BrowserThread::GetTaskRunnerForThread(BrowserThread::UI)) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   ++g_instance_count;
 }

base/tracked_objects.h

@@ -174,7 +174,7 @@ struct TrackingInfo;
 // (worker threads don't have message loops generally, and hence gathering from
 // them will continue to be asynchronous).  We had an implementation of this in
 // the past, but the difficulty is dealing with message loops being terminated.
-// We can *try* to spam the available threads via some message loop proxy to
+// We can *try* to spam the available threads via some task runner to
 // achieve this feat, and it *might* be valuable when we are collecting data
 // for upload via UMA (where correctness of data may be more significant than
 // for a single screen of about:profiler).

blimp/engine/app/blimp_system_url_request_context_getter.cc

@@ -42,7 +42,7 @@ BlimpSystemURLRequestContextGetter::GetURLRequestContext() {
 
 scoped_refptr<base::SingleThreadTaskRunner>
 BlimpSystemURLRequestContextGetter::GetNetworkTaskRunner() const {
-  return content::BrowserThread::GetMessageLoopProxyForThread(
+  return content::BrowserThread::GetTaskRunnerForThread(
       content::BrowserThread::IO);
 }
 

blimp/engine/app/blimp_url_request_context_getter.cc

@@ -91,7 +91,7 @@ net::URLRequestContext* BlimpURLRequestContextGetter::GetURLRequestContext() {
 
 scoped_refptr<base::SingleThreadTaskRunner>
 BlimpURLRequestContextGetter::GetNetworkTaskRunner() const {
-  return content::BrowserThread::GetMessageLoopProxyForThread(
+  return content::BrowserThread::GetTaskRunnerForThread(
       content::BrowserThread::IO);
 }
 

blimp/engine/browser_tests/blimp_browser_test.cc

@@ -76,8 +76,7 @@ void BlimpBrowserTest::SetUpOnMainThread() {
 }
 
 void BlimpBrowserTest::TearDownOnMainThread() {
-  content::BrowserThread::GetMessageLoopProxyForThread(
-      content::BrowserThread::UI)
+  content::BrowserThread::GetTaskRunnerForThread(content::BrowserThread::UI)
       ->PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());
 }
 

blimp/engine/common/blimp_browser_context.cc

@@ -181,9 +181,9 @@ net::URLRequestContextGetter* BlimpBrowserContext::CreateRequestContext(
   resource_context_->set_url_request_context_getter(
       new BlimpURLRequestContextGetter(
           ignore_certificate_errors_, GetPath(),
-          content::BrowserThread::GetMessageLoopProxyForThread(
+          content::BrowserThread::GetTaskRunnerForThread(
               content::BrowserThread::IO),
-          content::BrowserThread::GetMessageLoopProxyForThread(
+          content::BrowserThread::GetTaskRunnerForThread(
               content::BrowserThread::FILE),
           protocol_handlers, std::move(request_interceptors), net_log_));
   return resource_context_->url_request_context_getter().get();

blimp/engine/session/blimp_engine_session.cc

@@ -302,10 +302,10 @@ void BlimpEngineSession::GetEnginePortForTesting(
 }
 
 void BlimpEngineSession::RegisterFeatures() {
-  thread_pipe_manager_.reset(new ThreadPipeManager(
-      content::BrowserThread::GetMessageLoopProxyForThread(
-          content::BrowserThread::IO),
-      net_components_->GetBrowserConnectionHandler()));
+  thread_pipe_manager_.reset(
+      new ThreadPipeManager(content::BrowserThread::GetTaskRunnerForThread(
+                                content::BrowserThread::IO),
+                            net_components_->GetBrowserConnectionHandler()));
 
   // Register features' message senders and receivers.
   tab_control_message_sender_ =

chrome/browser/after_startup_task_utils_unittest.cc

@@ -73,9 +73,9 @@ class AfterStartupTaskTest : public testing::Test {
   AfterStartupTaskTest()
       : browser_thread_bundle_(TestBrowserThreadBundle::REAL_DB_THREAD) {
     ui_thread_ = new WrappedTaskRunner(
-        BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI));
+        BrowserThread::GetTaskRunnerForThread(BrowserThread::UI));
     db_thread_ = new WrappedTaskRunner(
-        BrowserThread::GetMessageLoopProxyForThread(BrowserThread::DB));
+        BrowserThread::GetTaskRunnerForThread(BrowserThread::DB));
     AfterStartupTaskUtils::UnsafeResetForTesting();
   }
 

chrome/browser/android/data_usage/data_use_ui_tab_model_unittest.cc

@@ -106,9 +106,9 @@ class DataUseUITabModelTest : public testing::Test {
 
  protected:
   void SetUp() override {
-    io_task_runner_ = content::BrowserThread::GetMessageLoopProxyForThread(
+    io_task_runner_ = content::BrowserThread::GetTaskRunnerForThread(
         content::BrowserThread::IO);
-    ui_task_runner_ = content::BrowserThread::GetMessageLoopProxyForThread(
+    ui_task_runner_ = content::BrowserThread::GetTaskRunnerForThread(
         content::BrowserThread::UI);
 
     data_use_aggregator_.reset(

chrome/browser/android/data_usage/external_data_use_observer_unittest.cc

@@ -58,9 +58,9 @@ class ExternalDataUseObserverTest : public testing::Test {
   void SetUp() override {
     thread_bundle_.reset(new content::TestBrowserThreadBundle(
         content::TestBrowserThreadBundle::IO_MAINLOOP));
-    io_task_runner_ = content::BrowserThread::GetMessageLoopProxyForThread(
+    io_task_runner_ = content::BrowserThread::GetTaskRunnerForThread(
         content::BrowserThread::IO);
-    ui_task_runner_ = content::BrowserThread::GetMessageLoopProxyForThread(
+    ui_task_runner_ = content::BrowserThread::GetTaskRunnerForThread(
         content::BrowserThread::UI);
     data_use_aggregator_.reset(
         new data_usage::DataUseAggregator(nullptr, nullptr));

chrome/browser/android/logo_service.cc

@@ -117,7 +117,7 @@ void LogoService::GetLogo(search_provider_logos::LogoObserver* observer) {
   if (!logo_tracker_) {
     logo_tracker_.reset(new LogoTracker(
         profile_->GetPath().Append(kCachedLogoDirectory),
-        BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE),
+        BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE),
         BrowserThread::GetBlockingPool(), profile_->GetRequestContext(),
         std::unique_ptr<search_provider_logos::LogoDelegate>(
             new ChromeLogoDelegate())));

chrome/browser/apps/app_shim/app_shim_host_mac.cc

@@ -25,11 +25,9 @@ void AppShimHost::ServeChannel(const IPC::ChannelHandle& handle) {
   DCHECK(CalledOnValidThread());
   DCHECK(!channel_.get());
   channel_ = IPC::ChannelProxy::Create(
-      handle,
-      IPC::Channel::MODE_SERVER,
-      this,
-      content::BrowserThread::GetMessageLoopProxyForThread(
-          content::BrowserThread::IO).get());
+      handle, IPC::Channel::MODE_SERVER, this,
+      content::BrowserThread::GetTaskRunnerForThread(content::BrowserThread::IO)
+          .get());
 }
 
 base::FilePath AppShimHost::GetProfilePath() const {

chrome/browser/autocomplete/shortcuts_backend_factory.cc

@@ -95,7 +95,7 @@ scoped_refptr<ShortcutsBackend> ShortcutsBackendFactory::CreateShortcutsBackend(
       base::WrapUnique(new UIThreadSearchTermsData(profile)),
       HistoryServiceFactory::GetForProfile(profile,
                                            ServiceAccessType::EXPLICIT_ACCESS),
-      content::BrowserThread::GetMessageLoopProxyForThread(
+      content::BrowserThread::GetTaskRunnerForThread(
           content::BrowserThread::DB),
       profile->GetPath().Append(kShortcutsDatabaseName), suppress_db));
 #if defined(ENABLE_EXTENSIONS)

chrome/browser/bookmarks/bookmark_model_factory.cc

@@ -63,11 +63,10 @@ KeyedService* BookmarkModelFactory::BuildServiceInstanceFor(
   BookmarkModel* bookmark_model =
       new BookmarkModel(base::WrapUnique(new ChromeBookmarkClient(
           profile, ManagedBookmarkServiceFactory::GetForProfile(profile))));
-  bookmark_model->Load(profile->GetPrefs(),
-                       profile->GetPath(),
+  bookmark_model->Load(profile->GetPrefs(), profile->GetPath(),
                        StartupTaskRunnerServiceFactory::GetForProfile(profile)
                            ->GetBookmarkTaskRunner(),
-                       content::BrowserThread::GetMessageLoopProxyForThread(
+                       content::BrowserThread::GetTaskRunnerForThread(
                            content::BrowserThread::UI));
   bool register_bookmark_undo_service_as_observer = true;
 #if !BUILDFLAG(ANDROID_JAVA_UI)

chrome/browser/browser_process_impl.cc

@@ -1181,9 +1181,9 @@ void BrowserProcessImpl::CreateGCMDriver() {
   gcm_driver_ = gcm::CreateGCMDriverDesktop(
       base::WrapUnique(new gcm::GCMClientFactory), local_state(), store_path,
       system_request_context(), chrome::GetChannel(),
-      content::BrowserThread::GetMessageLoopProxyForThread(
+      content::BrowserThread::GetTaskRunnerForThread(
           content::BrowserThread::UI),
-      content::BrowserThread::GetMessageLoopProxyForThread(
+      content::BrowserThread::GetTaskRunnerForThread(
           content::BrowserThread::IO),
       blocking_task_runner);
 #endif  // defined(OS_ANDROID)

chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc

@@ -36,8 +36,8 @@ class BrowsingDataQuotaHelperTest : public testing::Test {
     EXPECT_TRUE(dir_.CreateUniqueTempDir());
     quota_manager_ = new storage::QuotaManager(
         false, dir_.path(),
-        BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO).get(),
-        BrowserThread::GetMessageLoopProxyForThread(BrowserThread::DB).get(),
+        BrowserThread::GetTaskRunnerForThread(BrowserThread::IO).get(),
+        BrowserThread::GetTaskRunnerForThread(BrowserThread::DB).get(),
         nullptr);
     helper_ = new BrowsingDataQuotaHelperImpl(quota_manager_.get());
   }

chrome/browser/chrome_browser_main.cc

@@ -801,7 +801,7 @@ void ChromeBrowserMainParts::StartMetricsRecording() {
   TRACE_EVENT0("startup", "ChromeBrowserMainParts::StartMetricsRecording");
 
   g_browser_process->metrics_service()->CheckForClonedInstall(
-      BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));
+      BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE));
 
   g_browser_process->GetMetricsServicesManager()->UpdateUploadPermissions(true);
 }
@@ -1456,7 +1456,7 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
   }
 
   ui::SelectFileDialog::SetFactory(new ChromeSelectFileDialogFactory(
-      BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO)));
+      BrowserThread::GetTaskRunnerForThread(BrowserThread::IO)));
 #endif  // defined(OS_WIN)
 
   if (parsed_command_line().HasSwitch(switches::kMakeDefaultBrowser)) {

chrome/browser/chrome_browser_main_win.cc

@@ -318,7 +318,7 @@ void ChromeBrowserMainPartsWin::PostProfileInit() {
   base::FilePath path(
       profile()->GetPath().AppendASCII("ChromeDWriteFontCache"));
   content::BrowserThread::PostAfterStartupTask(
-      FROM_HERE, content::BrowserThread::GetMessageLoopProxyForThread(
+      FROM_HERE, content::BrowserThread::GetTaskRunnerForThread(
                      content::BrowserThread::FILE),
       base::Bind(base::IgnoreResult(&base::DeleteFile), path, false));
 }

chrome/browser/chrome_device_client.cc

@@ -20,7 +20,7 @@ device::UsbService* ChromeDeviceClient::GetUsbService() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   if (!usb_service_) {
     usb_service_ = device::UsbService::Create(
-        BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));
+        BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE));
   }
   return usb_service_.get();
 }
@@ -30,7 +30,7 @@ device::HidService* ChromeDeviceClient::GetHidService() {
 #if !defined(OS_ANDROID)
   if (!hid_service_) {
     hid_service_ = device::HidService::Create(
-        BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));
+        BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE));
   }
 #endif
   return hid_service_.get();

chrome/browser/chromeos/chrome_browser_main_chromeos.cc

@@ -382,7 +382,7 @@ void ChromeBrowserMainPartsChromeos::PostMainMessageLoopStart() {
 void ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() {
   // Set the crypto thread after the IO thread has been created/started.
   TPMTokenLoader::Get()->SetCryptoTaskRunner(
-      content::BrowserThread::GetMessageLoopProxyForThread(
+      content::BrowserThread::GetTaskRunnerForThread(
           content::BrowserThread::IO));
 
   CrasAudioHandler::Initialize(
@@ -399,7 +399,7 @@ void ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() {
   // will ensure that loading is aborted on early exit.
   bool load_oem_statistics = !StartupUtils::IsOobeCompleted();
   system::StatisticsProvider::GetInstance()->StartLoadingMachineStatistics(
-      content::BrowserThread::GetMessageLoopProxyForThread(
+      content::BrowserThread::GetTaskRunnerForThread(
           content::BrowserThread::FILE),
       load_oem_statistics);
 

chrome/browser/chromeos/device/input_service_proxy.cc

@@ -87,8 +87,7 @@ class InputServiceProxy::ServiceObserver : public InputServiceLinux::Observer {
 
 InputServiceProxy::InputServiceProxy()
     : service_observer_(new ServiceObserver()),
-      task_runner_(BrowserThread::GetMessageLoopProxyForThread(
-          thread_identifier_)),
+      task_runner_(BrowserThread::GetTaskRunnerForThread(thread_identifier_)),
       weak_factory_(this) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   task_runner_->PostTask(

chrome/browser/chromeos/drive/drive_integration_service.cc

@@ -260,7 +260,7 @@ DriveIntegrationService::DriveIntegrationService(
       metadata_storage_.get(), cache_.get(), blocking_task_runner_));
 
   file_task_runner_ =
-      BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE);
+      BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE);
   file_system_.reset(
       test_file_system
           ? test_file_system

chrome/browser/chromeos/drive/fileapi/async_file_util.cc

@@ -79,7 +79,7 @@ void RunCreateOrOpenFileCallback(
   callback.Run(
       std::move(file),
       base::Bind(&google_apis::RunTaskWithTaskRunner,
-                 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI),
+                 BrowserThread::GetTaskRunnerForThread(BrowserThread::UI),
                  close_callback_on_ui_thread));
 }
 

chrome/browser/chromeos/extensions/external_cache_unittest.cc

@@ -62,7 +62,7 @@ class ExternalCacheTest : public testing::Test,
   // testing::Test overrides:
   void SetUp() override {
     request_context_getter_ = new net::TestURLRequestContextGetter(
-        content::BrowserThread::GetMessageLoopProxyForThread(
+        content::BrowserThread::GetTaskRunnerForThread(
             content::BrowserThread::IO));
     fetcher_factory_.reset(new net::TestURLFetcherFactory());
 

chrome/browser/chromeos/file_manager/zip_file_creator.cc

@@ -93,8 +93,7 @@ void ZipFileCreator::StartProcessOnIOThread(base::File dest_file) {
   base::FileDescriptor dest_fd(std::move(dest_file));
 
   UtilityProcessHost* host = UtilityProcessHost::Create(
-      this,
-      BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI).get());
+      this, BrowserThread::GetTaskRunnerForThread(BrowserThread::UI).get());
   host->SetName(
       l10n_util::GetStringUTF16(IDS_UTILITY_PROCESS_ZIP_FILE_CREATOR_NAME));
   host->SetExposedDir(src_dir_);