diff --git a/cc/trees/frame_rate_counter.cc b/cc/trees/frame_rate_counter.cc index f801dbf640d97c..ac4d517f5d2768 100644 --- a/cc/trees/frame_rate_counter.cc +++ b/cc/trees/frame_rate_counter.cc @@ -57,18 +57,6 @@ void FrameRateCounter::SaveTimeStamp(base::TimeTicks timestamp, bool software) { base::TimeDelta frame_interval_seconds = RecentFrameInterval(ring_buffer_.BufferSize() - 1); - if (has_impl_thread_ && ring_buffer_.CurrentIndex() > 0) { - if (software) { - UMA_HISTOGRAM_CUSTOM_COUNTS( - "Renderer4.SoftwareCompositorThreadImplDrawDelay", - frame_interval_seconds.InMilliseconds(), 1, 120, 60); - } else { - UMA_HISTOGRAM_CUSTOM_COUNTS("Renderer4.CompositorThreadImplDrawDelay", - frame_interval_seconds.InMilliseconds(), 1, - 120, 60); - } - } - if (!IsBadFrameInterval(frame_interval_seconds) && frame_interval_seconds.InSecondsF() > kDroppedFrameTime) dropped_frame_count_ += diff --git a/components/translate/core/common/translate_metrics.cc b/components/translate/core/common/translate_metrics.cc index db31f0e6c853cc..9135737fa4c48e 100644 --- a/components/translate/core/common/translate_metrics.cc +++ b/components/translate/core/common/translate_metrics.cc @@ -18,7 +18,6 @@ namespace translate { namespace metrics_internal { -const char kRenderer4LanguageDetection[] = "Renderer4.LanguageDetection"; const char kTranslateContentLanguage[] = "Translate.ContentLanguage"; const char kTranslateHtmlLang[] = "Translate.HtmlLang"; const char kTranslateLanguageVerification[] = "Translate.LanguageVerification"; @@ -102,11 +101,6 @@ void ReportPageScheme(const std::string& scheme) { SCHEME_MAX); } -void ReportLanguageDetectionTime(base::TimeTicks begin, base::TimeTicks end) { - UMA_HISTOGRAM_MEDIUM_TIMES(metrics_internal::kRenderer4LanguageDetection, - end - begin); -} - void ReportSimilarLanguageMatch(bool match) { UMA_HISTOGRAM_BOOLEAN(metrics_internal::kTranslateSimilarLanguageMatch, match); diff --git a/components/translate/core/common/translate_metrics.h b/components/translate/core/common/translate_metrics.h index 5dfbfb2695a223..8c42c1f4edd648 100644 --- a/components/translate/core/common/translate_metrics.h +++ b/components/translate/core/common/translate_metrics.h @@ -16,7 +16,6 @@ namespace translate { namespace metrics_internal { // Constant string values to indicate UMA names. -extern const char kRenderer4LanguageDetection[]; extern const char kTranslateContentLanguage[]; extern const char kTranslateHtmlLang[]; extern const char kTranslateLanguageVerification[]; @@ -92,9 +91,6 @@ void ReportUserActionDuration(base::TimeTicks begin, base::TimeTicks end); // Called when a translation is triggered. void ReportPageScheme(const std::string& scheme); -// Called when CLD detects page language. -void ReportLanguageDetectionTime(base::TimeTicks begin, base::TimeTicks end); - // Called when CLD agreed on a language which is different, but in the similar // language list. void ReportSimilarLanguageMatch(bool match); diff --git a/components/translate/core/common/translate_metrics_unittest.cc b/components/translate/core/common/translate_metrics_unittest.cc index 6f5ae19b834670..44d1acf945da24 100644 --- a/components/translate/core/common/translate_metrics_unittest.cc +++ b/components/translate/core/common/translate_metrics_unittest.cc @@ -279,17 +279,6 @@ TEST(TranslateMetricsTest, ReportSimilarLanguageMatch) { EXPECT_EQ(1, recorder.GetCount(kFalse)); } -TEST(TranslateMetricsTest, ReportLanguageDetectionTime) { - MetricsRecorder recorder( - translate::metrics_internal::kRenderer4LanguageDetection); - recorder.CheckTotalCount(0); - TimeTicks begin = TimeTicks::Now(); - TimeTicks end = begin + base::TimeDelta::FromMicroseconds(9009); - translate::ReportLanguageDetectionTime(begin, end); - recorder.CheckValueInLogs(9.009); - recorder.CheckTotalCount(1); -} - TEST(TranslateMetricsTest, ReportLanguageDetectionConflict) { MetricsRecorder recorder( translate::metrics_internal::kTranslateLanguageDetectionConflict); diff --git a/components/translate/core/language_detection/language_detection_util.cc b/components/translate/core/language_detection/language_detection_util.cc index ea481c36e97cf3..e4e59ed4cece0d 100644 --- a/components/translate/core/language_detection/language_detection_util.cc +++ b/components/translate/core/language_detection/language_detection_util.cc @@ -15,7 +15,6 @@ #include "base/strings/string_split.h" #include "base/strings/string_util.h" #include "base/strings/utf_string_conversions.h" -#include "base/time/time.h" #include "components/translate/core/common/translate_constants.h" #include "components/translate/core/common/translate_metrics.h" #include "components/translate/core/common/translate_util.h" @@ -152,7 +151,6 @@ std::string DeterminePageLanguage(const std::string& code, const base::string16& contents, std::string* cld_language_p, bool* is_cld_reliable_p) { - base::TimeTicks begin_time = base::TimeTicks::Now(); bool is_cld_reliable; // Check if html lang attribute is valid. std::string modified_html_lang; @@ -172,7 +170,6 @@ std::string DeterminePageLanguage(const std::string& code, } std::string cld_language = DetermineTextLanguage(contents, &is_cld_reliable); - translate::ReportLanguageDetectionTime(begin_time, base::TimeTicks::Now()); if (cld_language_p != nullptr) *cld_language_p = cld_language; diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index 7035ce927a43ce..2b8a50c6c40e42 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -78785,6 +78785,10 @@ uploading your change for review. + + Deprecated in 06/2018, M69. Renderer4.CompositorThreadImplDrawDelay is no + longer needed due to issue 851784. + wiltzius@chromium.org Time between frames, as measured on the compositor thread. This is collected @@ -79062,6 +79066,10 @@ uploading your change for review. + + Deprecated in 06/2018, M69. Renderer4.LanguageDetection is no longer needed + due to issue 851784. + wiltzius@chromium.org Time to determine the page language. This is done after the page has been @@ -79247,6 +79255,10 @@ uploading your change for review. + + Deprecated in 06/2018, M69. Renderer4.SoftwareCompositorThreadImplDrawDelay + is no longer needed due to issue 851784. + wiltzius@chromium.org Time between frames when the software renderer is being used, as measured on