diff --git a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc index 76690494129fd0..f8aa1b36e6fc7f 100644 --- a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc +++ b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc @@ -256,15 +256,15 @@ SocketsTcpServerGetInfoFunction::~SocketsTcpServerGetInfoFunction() = default; ExtensionFunction::ResponseAction SocketsTcpServerGetInfoFunction::Work() { std::unique_ptr params = sockets_tcp_server::GetInfo::Params::Create(args()); - EXTENSION_FUNCTION_VALIDATE(params_.get()); + EXTENSION_FUNCTION_VALIDATE(params.get()); - ResumableTCPServerSocket* socket = GetTcpSocket(params_->socket_id); + ResumableTCPServerSocket* socket = GetTcpSocket(params->socket_id); if (!socket) { return RespondNow(Error(kSocketNotFoundError)); } sockets_tcp_server::SocketInfo socket_info = - CreateSocketInfo(params_->socket_id, socket); + CreateSocketInfo(params->socket_id, socket); return RespondNow( ArgumentList(sockets_tcp_server::GetInfo::Results::Create(socket_info))); } diff --git a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h index 39d68080d449de..d60fa8bbe677c8 100644 --- a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h +++ b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h @@ -134,9 +134,6 @@ class SocketsTcpServerGetInfoFunction : public TCPServerSocketApiFunction { // SocketApiFunction: ResponseAction Work() override; - - private: - std::unique_ptr params_; }; class SocketsTcpServerGetSocketsFunction : public TCPServerSocketApiFunction { diff --git a/extensions/test/data/sockets_tcp_server/api/background.js b/extensions/test/data/sockets_tcp_server/api/background.js index 8a2ff5ee95c74b..f25b1e7dead44c 100644 --- a/extensions/test/data/sockets_tcp_server/api/background.js +++ b/extensions/test/data/sockets_tcp_server/api/background.js @@ -43,6 +43,11 @@ var testSocketListening = function() { function onServerSocketCreate(socketInfo) { console.log("Server socket created: sd=" + socketInfo.socketId); socketId = socketInfo.socketId; + chrome.sockets.tcpServer.getInfo(socketId, onGetInfo); + } + + function onGetInfo(socketInfo) { + chrome.test.assertEq(socketInfo.socketId, socketId); chrome.sockets.tcpServer.listen(socketId, address, port, onListen); }