Skip to content

Commit

Permalink
[IPC] Remove no-longer-needed *MsgStart defines
Browse files Browse the repository at this point in the history
Part of the elimination of the legacy IPC system.

Bug: 1007300
Change-Id: Ia0f3a49c09156d5a66cf8b7075c08f954d78e8ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833822
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703630}
  • Loading branch information
colinblundell authored and Commit Bot committed Oct 8, 2019
1 parent c43246b commit 3c541e6
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 15 deletions.
2 changes: 0 additions & 2 deletions chrome/common/apps/platform_apps/chrome_apps_messages.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
#include "chrome/common/apps/platform_apps/media_galleries_permission_data.h"
#include "ipc/ipc_message_macros.h"

#define IPC_MESSAGE_START ChromeAppsMsgStart

IPC_STRUCT_TRAITS_BEGIN(chrome_apps::MediaGalleriesPermissionData)
IPC_STRUCT_TRAITS_MEMBER(permission())
IPC_STRUCT_TRAITS_END()
Expand Down
4 changes: 0 additions & 4 deletions content/common/resource_messages.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@

#endif // INTERNAL_CONTENT_COMMON_RESOURCE_MESSAGES_H_

#define IPC_MESSAGE_START ResourceMsgStart
#undef IPC_MESSAGE_EXPORT
#define IPC_MESSAGE_EXPORT CONTENT_EXPORT

IPC_ENUM_TRAITS_MAX_VALUE(blink::WebMixedContentContextType,
blink::WebMixedContentContextType::kLast)

Expand Down
5 changes: 0 additions & 5 deletions ipc/ipc_message_start.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ enum IPCMessageStart {
GpuChannelMsgStart,
MediaMsgStart,
PpapiMsgStart,
ResourceMsgStart,
ChromeMsgStart,
DragMsgStart,
PrintMsgStart,
Expand All @@ -36,9 +35,7 @@ enum IPCMessageStart {
ChromotingMsgStart,
BrowserPluginMsgStart,
AndroidWebViewMsgStart,
MediaPlayerMsgStart,
PeerConnectionTrackerMsgStart,
WebRtcLoggingMsgStart,
NaClHostMsgStart,
EncryptedMediaMsgStart,
CastMsgStart,
Expand All @@ -48,7 +45,6 @@ enum IPCMessageStart {
WebTestMsgStart,
NetworkHintsMsgStart,
CastMediaMsgStart,
SyncCompositorMsgStart,
ExtensionsGuestViewMsgStart,
GuestViewMsgStart,
// Note: CastCryptoMsgStart and CastChannelMsgStart reserved for Chromecast
Expand All @@ -60,7 +56,6 @@ enum IPCMessageStart {
SurfaceViewManagerMsgStart,
ExtensionWorkerMsgStart,
SubresourceFilterMsgStart,
ChromeAppsMsgStart,
UnfreezableFrameMsgStart,
LastIPCMsgStart // Must come last.
};
Expand Down
4 changes: 0 additions & 4 deletions tools/ipc_fuzzer/message_tools/message_list.cc
Original file line number Diff line number Diff line change
Expand Up @@ -54,21 +54,17 @@ static bool check_msgtable() {
exemptions.push_back(CastMediaMsgStart); // Reserved for chromecast.
exemptions.push_back(IPCTestMsgStart);
exemptions.push_back(WorkerMsgStart); // Now only used by tests.
exemptions.push_back(ResourceMsgStart); // Cleanup underway.
exemptions.push_back(ChromeUtilityPrintingMsgStart); // BUILDFLAGS, sigh.
exemptions.push_back(WebRtcLoggingMsgStart);

#if !BUILDFLAG(ENABLE_NACL)
exemptions.push_back(NaClMsgStart);
#endif // !BUILDFLAG(ENABLE_NACL)


#if !defined(OS_ANDROID)
exemptions.push_back(MediaPlayerMsgStart);
exemptions.push_back(EncryptedMediaMsgStart);
exemptions.push_back(GinJavaBridgeMsgStart);
exemptions.push_back(AndroidWebViewMsgStart);
exemptions.push_back(SyncCompositorMsgStart);
exemptions.push_back(ExtensionWorkerMsgStart);
exemptions.push_back(SurfaceViewManagerMsgStart);
#endif // !defined(OS_ANDROID)
Expand Down

0 comments on commit 3c541e6

Please sign in to comment.