From 3b5cac24943ce9e682c806f844a6aec90481774c Mon Sep 17 00:00:00 2001 From: brettw Date: Wed, 2 Dec 2015 11:44:54 -0800 Subject: [PATCH] Add all components to "gn check". All components now pass a "gn check" step. Whitelist with a wildcard. R=dpranke@chromium.org Reland of https://codereview.chromium.org/1491743002 Review URL: https://codereview.chromium.org/1490113006 Cr-Commit-Position: refs/heads/master@{#362776} --- .gn | 153 +----------------------- components/arc/BUILD.gn | 1 + components/exo/BUILD.gn | 1 + components/exo/wayland/BUILD.gn | 2 + components/version_info/version_info.cc | 2 +- components/wifi_sync/BUILD.gn | 25 ++-- ui/ozone/BUILD.gn | 5 +- 7 files changed, 28 insertions(+), 161 deletions(-) diff --git a/.gn b/.gn index d3f9ffee81c51c..df8816d75710ef 100644 --- a/.gn +++ b/.gn @@ -34,158 +34,7 @@ check_targets = [ #"//chrome_elf/*", #"//cloud_print/*", - #"//components/*", # Needs nacl below. - "//components:*", - "//components/about_handler/*", - "//components/about_ui/*", - "//components/app_modal/*", - "//components/audio_modem/*", - "//components/autofill/*", - "//components/auto_login_parser/*", - "//components/bitmap_uploader/*", - "//components/bookmarks/*", - "//components/browser_sync/*", - "//components/browser_watcher/*", - "//components/browsing_data/*", - "//components/bubble/*", - "//components/captive_portal/*", - "//components/cdm/*", - "//components/certificate_reporting/*", - "//components/certificate_transparency/*", - "//components/chrome_apps/*", - "//components/clipboard/*", - "//components/cloud_devices/*", - "//components/component_updater/*", - "//components/compression/*", - "//components/constrained_window/*", - "//components/content_settings/*", - "//components/cookie_config/*", - "//components/copresence/*", - "//components/crash/*", - "//components/cronet/*", - "//components/crx_file/*", - "//components/data_reduction_proxy/*", - "//components/data_usage/*", - "//components/data_use_measurement/*", - "//components/device_event_log/*", - "//components/devtools_discovery/*", - "//components/devtools_http_handler/*", - "//components/devtools_service/*", - "//components/dom_distiller/*", - "//components/domain_reliability/*", - "//components/drive/*", - "//components/enhanced_bookmarks/*", - "//components/error_page/*", - "//components/exp/*", - "//components/external_video_surface/*", - "//components/favicon/*", - "//components/favicon_base/*", - "//components/feedback/*", - "//components/filesystem/*", - "//components/flags_ui/*", - "//components/font_service/*", - "//components/gcm_driver/*", - "//components/google/*", - "//components/gpu/*", - "//components/guest_view/*", - "//components/handoff/*", - "//components/history/*", - "//components/html_viewer/*", - "//components/infobars/*", - "//components/invalidation/*", - "//components/json_schema/*", - "//components/keyed_service/*", - "//components/language_usage_metrics/*", - "//components/leveldb_proto/*", - "//components/login/*", - "//components/memory_pressure/*", - "//components/message_port/*", - "//components/metrics/*", - "//components/metrics_services_manager/*", - "//components/mime_util/*", - "//components/mus/*", - "//components/nacl/*", - "//components/navigation_interception/*", - "//components/navigation_metrics/*", - "//components/net_log/*", - "//components/network_hints/*", - "//components/network_time/*", - "//components/offline_pages/*", - "//components/omnibox/*", - "//components/onc/*", - "//components/open_from_clipboard/*", - "//components/os_crypt/*", - "//components/ownership/*", - "//components/packed_ct_ev_whitelist/*", - "//components/page_load_metrics/*", - "//components/pairing/*", - "//components/password_manager/*", - "//components/pdf/*", - "//components/pdf_viewer/*", - "//components/plugins/*", - "//components/policy/*", - "//components/power/*", - "//components/precache/*", - "//components/pref_registry/*", - "//components/printing/*", - "//components/proximity_auth/*", - "//components/proxy_config/*", - "//components/query_parser/*", - "//components/rappor/*", - "//components/renderer_context_menu/*", - "//components/resource_provider/*", - "//components/resources/*", - "//components/rlz/*", - "//components/safe_browsing_db/*", - "//components/safe_json/*", - "//components/scheduler/*", - "//components/search/*", - "//components/search_engines/*", - "//components/search_provider_logos/*", - "//components/security_interstitials/*", - "//components/service_tab_launcher/*", - "//components/session_manager/*", - "//components/sessions/*", - "//components/signin/*", - "//components/ssl_config/*", - "//components/ssl_errors/*", - "//components/startup_metric_utils/*", - "//components/storage_monitor/*", - "//components/strings/*", - "//components/suggestions/*", - "//components/sync_bookmarks/*", - "//components/sync_driver/*", - "//components/sync_sessions/*", - "//components/syncable_prefs/*", - "//components/test/*", - "//components/test_runner/*", - "//components/timers/*", - "//components/toolbar/*", - "//components/tools/*", - "//components/tracing/*", - "//components/translate/*", - "//components/ui/*", - "//components/undo/*", - "//components/update_client/*", - "//components/upload_list/*", - "//components/url_formatter/*", - "//components/url_matcher/*", - "//components/user_manager/*", - "//components/user_prefs/*", - "//components/variations/*", - "//components/visitedlink/*", - "//components/wallpaper/*", - "//components/web_cache/*", - "//components/web_modal/*", - "//components/web_resource/*", - "//components/web_view/*", - "//components/webcrypto/*", - "//components/webdata/*", - "//components/webdata_services/*", - "//components/webp_transcode/*", - "//components/webui_generator/*", - "//components/webusb/*", - "//components/wifi/*", + "//components/*", #"//content/*", # A whole lot of errors. "//content/public/common:result_codes", diff --git a/components/arc/BUILD.gn b/components/arc/BUILD.gn index e6f40684c2c505..7fbfd24145d1d7 100644 --- a/components/arc/BUILD.gn +++ b/components/arc/BUILD.gn @@ -13,6 +13,7 @@ static_library("arc") { deps = [ "//base", + "//base:prefs", "//chromeos", "//ipc", ] diff --git a/components/exo/BUILD.gn b/components/exo/BUILD.gn index ab9103527b8bf6..00f328d52346fc 100644 --- a/components/exo/BUILD.gn +++ b/components/exo/BUILD.gn @@ -85,6 +85,7 @@ source_set("unit_tests") { "//ui/gfx", "//ui/keyboard", "//ui/message_center", + "//ui/ozone", "//ui/views", ] } diff --git a/components/exo/wayland/BUILD.gn b/components/exo/wayland/BUILD.gn index 67d6d63db713f4..f69909b6d52367 100644 --- a/components/exo/wayland/BUILD.gn +++ b/components/exo/wayland/BUILD.gn @@ -35,6 +35,8 @@ source_set("unit_tests") { deps = [ ":wayland", + "//base", + "//components/exo", "//testing/gtest", "//third_party/wayland:wayland_client", ] diff --git a/components/version_info/version_info.cc b/components/version_info/version_info.cc index a6c39164e0e364..70657785f2e3cf 100644 --- a/components/version_info/version_info.cc +++ b/components/version_info/version_info.cc @@ -9,7 +9,7 @@ #include "grit/components_strings.h" #if defined(USE_UNOFFICIAL_VERSION_NUMBER) -#include "ui/base/l10n/l10n_util.h" +#include "ui/base/l10n/l10n_util.h" // nogncheck #endif // USE_UNOFFICIAL_VERSION_NUMBER namespace version_info { diff --git a/components/wifi_sync/BUILD.gn b/components/wifi_sync/BUILD.gn index 034442895505a7..72ac120899b62c 100644 --- a/components/wifi_sync/BUILD.gn +++ b/components/wifi_sync/BUILD.gn @@ -22,21 +22,22 @@ source_set("wifi_sync") { deps = [ "//base", + "//base:i18n", + "//components/keyed_service/content", + "//components/keyed_service/core", "//components/onc", + "//content/public/browser", "//sync", ] + + if (is_chromeos) { + deps += [ "//chromeos" ] + } } source_set("unit_tests") { testonly = true - deps = [ - ":wifi_sync", - "//sync", - "//testing/gmock", - "//testing/gtest", - ] - sources = [ "wifi_config_delegate_chromeos_unittest.cc", "wifi_credential_syncable_service_unittest.cc", @@ -44,4 +45,14 @@ source_set("unit_tests") { "wifi_security_class_chromeos_unittest.cc", "wifi_security_class_unittest.cc", ] + + deps = [ + ":wifi_sync", + "//base", + "//chromeos", + "//components/onc", + "//sync:test_support_sync_api", + "//testing/gmock", + "//testing/gtest", + ] } diff --git a/ui/ozone/BUILD.gn b/ui/ozone/BUILD.gn index f52969253c46c2..f492ec61039449 100644 --- a/ui/ozone/BUILD.gn +++ b/ui/ozone/BUILD.gn @@ -120,11 +120,14 @@ component("ozone") { defines = [ "OZONE_IMPLEMENTATION" ] + public_deps = [ + ":ozone_base", + ] + deps = [ ":generate_constructor_list", ":generate_ozone_platform_list", - ":ozone_base", "//base", "//ipc", "//skia",