Skip to content

Commit

Permalink
chromeos_camera: Skip testing the shmem path for V4L2
Browse files Browse the repository at this point in the history
We only use DMA buffer for V4L2 path, don't need to test them. For VAAPI
case, some older boards may use the shmem path so keep them.

Bug: b:171356989
Test: jpeg_encode_accelerator_unittest
Change-Id: I02b088925b088cbaf7597dddd3ac50835b27ab9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757593
Reviewed-by: Wei Lee <wtlee@chromium.org>
Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#862730}
  • Loading branch information
mojahsu authored and Chromium LUCI CQ committed Mar 15, 2021
1 parent 60d056b commit 38b13f2
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,9 @@ void JpegEncodeAcceleratorTest::TestEncode(size_t num_concurrent_encoders,
VLOG(1) << "Exit TestEncode";
}

// We may need to keep the VAAPI shared memory path for Linux-based Chrome VCD.
// Some of our older boards are still running on the Linux VCD.
#if BUILDFLAG(USE_VAAPI)
TEST_F(JpegEncodeAcceleratorTest, SimpleEncode) {
for (size_t i = 0; i < g_env->repeat_; i++) {
for (auto& image : g_env->image_data_user_) {
Expand Down Expand Up @@ -855,6 +858,7 @@ TEST_F(JpegEncodeAcceleratorTest, CodedSizeAlignment) {
TestEncode(/*num_concurrent_encoders=*/1u, /*is_dma=*/false,
/*exif_size=*/0u);
}
#endif

TEST_F(JpegEncodeAcceleratorTest, SimpleDmaEncode) {
for (size_t i = 0; i < g_env->repeat_; i++) {
Expand Down

0 comments on commit 38b13f2

Please sign in to comment.