Skip to content

Commit

Permalink
[Contextual Search] Adjust spacing according to spec
Browse files Browse the repository at this point in the history
BUG=528332

Review URL: https://codereview.chromium.org/1308163008

Cr-Commit-Position: refs/heads/master@{#347747}
  • Loading branch information
pedrosimonetti authored and Commit bot committed Sep 8, 2015
1 parent 558063b commit 3598f6b
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
android:id="@+id/selected_text"
style="@style/ContextualSearchTextView"
android:layout_width="wrap_content"
android:layout_marginStart="5dp"
android:layout_marginEnd="5dp"
android:gravity="center_horizontal" />
<TextView
android:id="@+id/surrounding_text_end"
Expand Down
7 changes: 3 additions & 4 deletions chrome/android/java/res/values-v17/styles.xml
Original file line number Diff line number Diff line change
Expand Up @@ -366,14 +366,13 @@
<item name="android:layout_height">wrap_content</item>
<item name="android:layout_gravity">bottom</item>
<item name="android:background">#FFF</item>
<item name="android:paddingStart">40dp</item>
<item name="android:paddingEnd">40dp</item>
<item name="android:visibility">invisible</item>
<!-- 60dp padding minus 7dp for fading edge -->
<item name="android:paddingStart">53dp</item>
<item name="android:paddingEnd">53dp</item>
</style>
<style name="ContextualSearchTextView">
<item name="android:layout_height">match_parent</item>
<item name="android:layout_marginStart">5dp</item>
<item name="android:layout_marginEnd">5dp</item>
<item name="android:ellipsize">end</item>
<item name="android:singleLine">true</item>
<item name="android:textColor">#000</item>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ abstract class ContextualSearchPanelBase extends ContextualSearchPanelStateHandl
/**
* The side padding of Search Bar icons in dps.
*/
private static final float SEARCH_BAR_ICON_SIDE_PADDING_DP = 16.f;
private static final float SEARCH_BAR_ICON_SIDE_PADDING_DP = 12.f;

/**
* The height of the Search Bar's border in dps.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,19 +148,20 @@ void ContextualSearchLayer::SetProperties(
// ---------------------------------------------------------------------------
// Search Provider Icon
// ---------------------------------------------------------------------------
float search_provider_icon_left;
float search_provider_icon_top;
// Positions the Search Provider Icon at the start of the Search Bar.
float search_provider_icon_left;
if (is_rtl) {
search_provider_icon_left = search_panel_width -
search_provider_icon_resource->size.width() - search_bar_margin_side;
} else {
search_provider_icon_left = search_bar_margin_side;
}

// Centers the Search Provider Icon vertically in the Search Bar.
search_provider_icon_top =
float search_provider_icon_top =
search_bar_height / 2 -
search_provider_icon_resource->size.height() / 2;

search_provider_icon_->SetUIResourceId(
search_provider_icon_resource->ui_resource->id());
search_provider_icon_->SetBounds(search_provider_icon_resource->size);
Expand Down

0 comments on commit 3598f6b

Please sign in to comment.