Skip to content

Commit

Permalink
Expose immersive-ar enum value in all cases
Browse files Browse the repository at this point in the history
Bug: 1025992
Change-Id: If19cde37384656652a3dcbbf5331c13c794241f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924886
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716805}
  • Loading branch information
Manishearth authored and Commit Bot committed Nov 19, 2019
1 parent e13dde5 commit 34bab11
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions third_party/blink/renderer/modules/xr/xr.cc
Original file line number Diff line number Diff line change
Expand Up @@ -655,9 +655,7 @@ ScriptPromise XR::InternalIsSessionSupported(ScriptState* script_state,

if (session_mode == XRSession::kModeImmersiveAR &&
!RuntimeEnabledFeatures::WebXRARModuleEnabled(doc)) {
query->RejectWithTypeError(
String::Format(kImmersiveArModeNotValid, "supportsSession"),
&exception_state);
query->Resolve(false);
return promise;
}

Expand Down
2 changes: 1 addition & 1 deletion third_party/blink/renderer/modules/xr/xr_session.idl
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
enum XRSessionMode {
"inline",
"immersive-vr",
/* [RuntimeEnabled=WebXRARModule] */ "immersive-ar",
"immersive-ar",
};

enum XREnvironmentBlendMode {
Expand Down

0 comments on commit 34bab11

Please sign in to comment.