Skip to content

Commit

Permalink
[Audio Process] Launching sandbox on Windows 100%.
Browse files Browse the repository at this point in the history
In preparation to launch sandbox on Windows fully, this CL swtiches the
default of the flag to always enabled sandbox on Windows.

Bug: 974452
Change-Id: Ide06a7be38440409707f46a35e31413ce82ccc55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808837
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698148}
  • Loading branch information
Armando Miraglia authored and Commit Bot committed Sep 19, 2019
1 parent 1c1837a commit 2bd930f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
10 changes: 8 additions & 2 deletions services/service_manager/sandbox/features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,14 @@ namespace features {

// Enables audio service sandbox.
// (Only causes an effect when feature kAudioServiceOutOfProcess is enabled.)
const base::Feature kAudioServiceSandbox{"AudioServiceSandbox",
base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kAudioServiceSandbox {
"AudioServiceSandbox",
#if defined(OS_WIN)
base::FEATURE_ENABLED_BY_DEFAULT
#else
base::FEATURE_DISABLED_BY_DEFAULT
#endif // defined(OS_WIN)
};

// Enables network service sandbox.
// (Only causes an effect when feature kNetworkService is enabled.)
Expand Down
1 change: 0 additions & 1 deletion testing/variations/fieldtrial_testing_config.json
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,6 @@
{
"name": "AudioProcess_APM",
"enable_features": [
"AudioServiceSandbox",
"WebRtcApmInAudioService"
]
}
Expand Down

0 comments on commit 2bd930f

Please sign in to comment.