Skip to content

Commit

Permalink
Remove a TODO comment in URLLoader
Browse files Browse the repository at this point in the history
We won't add a flag to control the callback of Early Hints since
having a trusted flag in ResourceRequest is a bit difficult.

Bug: N/A
Change-Id: Ie2900432df135fdd1349554e751247c24c97d628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2781091
Auto-Submit: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866410}
  • Loading branch information
bashi authored and Chromium LUCI CQ committed Mar 25, 2021
1 parent 05a716e commit 27f5a22
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions services/network/url_loader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -640,9 +640,6 @@ URLLoader::URLLoader(
&URLLoader::SetRawResponseHeaders, base::Unretained(this)));
}

// TODO(crbug.com/671310): We may want to add
// ResourceRequest::report_early_response so that we can bypass setting
// EarlyResponseHeadersCallback if the client can't handle Early Hints.
url_request_->SetEarlyResponseHeadersCallback(base::BindRepeating(
&URLLoader::NotifyEarlyResponse, base::Unretained(this)));

Expand Down

0 comments on commit 27f5a22

Please sign in to comment.