Skip to content

Commit

Permalink
valgrind.sh vs gdb: keep the registers in gdb in sync with the code.
Browse files Browse the repository at this point in the history
This might come at a performance price but I don't think this is important for valgrind.sh
(please note the tests on the bots are started using a different runner)

BUG=113513
TEST=http://code.google.com/p/chromium/issues/detail?id=113513#c8

Review URL: http://codereview.chromium.org/9666056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126883 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
timurrrr@chromium.org committed Mar 15, 2012
1 parent ef69c35 commit 21d90b8
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tools/valgrind/valgrind.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash

# Copyright (c) 2011 The Chromium Authors. All rights reserved.
# Copyright (c) 2012 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

Expand All @@ -25,6 +25,8 @@ setup_memcheck() {

# Prompt to attach gdb when there was an error detected.
DEFAULT_TOOL_FLAGS=("--db-command=$GDB -nw %f %p" "--db-attach=yes" \
# Keep the registers in gdb in sync with the code.
"--vex-iropt-precise-memory-exns=yes" \
# Overwrite newly allocated or freed objects
# with 0x41 to catch inproper use.
"--malloc-fill=41" "--free-fill=41" \
Expand Down

0 comments on commit 21d90b8

Please sign in to comment.