Devtools: Add metrics for drawer views being shown

Given that drawer views are taking an increasingly dominant UI position, drawer metrics added to provide insight. Due to backwards compatability, original version was reverted in crrev.com/1672243003 Review URL: https://codereview.chromium.org/1678013002 Cr-Commit-Position: refs/heads/master@{#374269}
marcosholgado · Feb 9, 2016 · 20a8be3 · 20a8be3
1 parent b82272a
commit 20a8be3
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 1 deletion.
diff --git a/third_party/WebKit/LayoutTests/inspector/user-metrics-expected.txt b/third_party/WebKit/LayoutTests/inspector/user-metrics-expected.txt
@@ -27,6 +27,12 @@ recordPanelShown:
 {
     audits : 7
     console : 8
+    drawer-animations : 11
+    drawer-console : 10
+    drawer-network.config : 12
+    drawer-rendering : 13
+    drawer-sensors : 14
+    drawer-sources.search : 15
     elements : 1
     layers : 9
     network : 3

diff --git a/third_party/WebKit/Source/devtools/front_end/components/Drawer.js b/third_party/WebKit/Source/devtools/front_end/components/Drawer.js
@@ -68,6 +68,7 @@ WebInspector.Drawer.prototype = {
     showView: function(id, immediate)
     {
         this._innerShow(immediate);
+        WebInspector.userMetrics.drawerShown(id);
         return this._extensibleTabbedPaneController.showTab(id);
     },
 

diff --git a/third_party/WebKit/Source/devtools/front_end/host/UserMetrics.js b/third_party/WebKit/Source/devtools/front_end/host/UserMetrics.js
@@ -69,7 +69,13 @@ WebInspector.UserMetrics._PanelCodes = {
     profiles: 6,
     audits: 7,
     console: 8,
-    layers: 9
+    layers: 9,
+    "drawer-console": 10,
+    "drawer-animations": 11,
+    "drawer-network.config": 12,
+    "drawer-rendering": 13,
+    "drawer-sensors": 14,
+    "drawer-sources.search": 15
 }
 
 WebInspector.UserMetrics.prototype = {
@@ -83,6 +89,14 @@ WebInspector.UserMetrics.prototype = {
         InspectorFrontendHost.recordEnumeratedHistogram("DevTools.PanelShown", code, size);
     },
 
+    /**
+     * @param {string} drawerId
+     */
+    drawerShown: function(drawerId)
+    {
+        this.panelShown("drawer-" + drawerId);
+    },
+
     /**
      * @param {!WebInspector.UserMetrics.Action} action
      */

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
@@ -60922,6 +60922,12 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="7" label="Audits"/>
   <int value="8" label="Console"/>
   <int value="9" label="Layers"/>
+  <int value="10" label="Drawer - Console"/>
+  <int value="11" label="Drawer - Animations"/>
+  <int value="12" label="Drawer - Network config"/>
+  <int value="13" label="Drawer - Rendering"/>
+  <int value="14" label="Drawer - Sensors"/>
+  <int value="15" label="Drawer - Search"/>
 </enum>
 
 <enum name="DevToolsSetting" type="int">