forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathsearchbox_unittest.cc
325 lines (292 loc) · 12.1 KB
/
searchbox_unittest.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/renderer/searchbox/searchbox.h"
#include <map>
#include <string>
#include "base/basictypes.h"
#include "chrome/common/instant_types.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
namespace {
const auto FAVICON = SearchBox::FAVICON;
const auto LARGE_ICON = SearchBox::LARGE_ICON;
const auto FALLBACK_ICON = SearchBox::FALLBACK_ICON;
const auto THUMB = SearchBox::THUMB;
const char* kUrlString1 = "http://www.google.com";
const char* kUrlString2 = "http://www.chromium.org/path/q=3#r=4";
const char* kUrlString3 = "http://www.youtube.com:8080/hosps";
// Mock helper to test internal::TranslateIconRestrictedUrl().
class MockIconURLHelper: public SearchBox::IconURLHelper {
public:
MockIconURLHelper();
~MockIconURLHelper() override;
int GetViewID() const override;
std::string GetURLStringFromRestrictedID(InstantRestrictedID rid) const
override;
private:
std::map<InstantRestrictedID, std::string> rid_to_url_string_;
};
MockIconURLHelper::MockIconURLHelper() {
rid_to_url_string_[1] = kUrlString1;
rid_to_url_string_[2] = kUrlString2;
rid_to_url_string_[3] = kUrlString3;
}
MockIconURLHelper::~MockIconURLHelper() {
}
int MockIconURLHelper::GetViewID() const {
return 137;
}
std::string MockIconURLHelper::GetURLStringFromRestrictedID(
InstantRestrictedID rid) const {
auto it = rid_to_url_string_.find(rid);
return it == rid_to_url_string_.end() ? std::string() : it->second;
}
} // namespace
namespace internal {
// Defined in searchbox.cc
bool ParseViewIdAndRestrictedId(const std::string& id_part,
int* view_id_out,
InstantRestrictedID* rid_out);
// Defined in searchbox.cc
bool ParseIconRestrictedUrl(const GURL& url,
SearchBox::ImageSourceType type,
std::string* param_part,
int* view_id,
InstantRestrictedID* rid);
// Defined in searchbox.cc
bool TranslateIconRestrictedUrl(const GURL& transient_url,
SearchBox::ImageSourceType type,
const SearchBox::IconURLHelper& helper,
GURL* url);
TEST(SearchBoxUtilTest, ParseViewIdAndRestrictedIdSuccess) {
int view_id = -1;
InstantRestrictedID rid = -1;
EXPECT_TRUE(ParseViewIdAndRestrictedId("2/3", &view_id, &rid));
EXPECT_EQ(2, view_id);
EXPECT_EQ(3, rid);
EXPECT_TRUE(ParseViewIdAndRestrictedId("0/0", &view_id, &rid));
EXPECT_EQ(0, view_id);
EXPECT_EQ(0, rid);
EXPECT_TRUE(ParseViewIdAndRestrictedId("1048576/314", &view_id, &rid));
EXPECT_EQ(1048576, view_id);
EXPECT_EQ(314, rid);
// Odd but not fatal.
EXPECT_TRUE(ParseViewIdAndRestrictedId("00/09", &view_id, &rid));
EXPECT_EQ(0, view_id);
EXPECT_EQ(9, rid);
// Tolerates multiple, leading, and trailing "/".
EXPECT_TRUE(ParseViewIdAndRestrictedId("2////3", &view_id, &rid));
EXPECT_EQ(2, view_id);
EXPECT_EQ(3, rid);
EXPECT_TRUE(ParseViewIdAndRestrictedId("5/6/", &view_id, &rid));
EXPECT_EQ(5, view_id);
EXPECT_EQ(6, rid);
EXPECT_TRUE(ParseViewIdAndRestrictedId("/7/8", &view_id, &rid));
EXPECT_EQ(7, view_id);
EXPECT_EQ(8, rid);
}
TEST(SearchBoxUtilTest, ParseViewIdAndRestrictedIdFailure) {
const char* test_cases[] = {
"",
" ",
"/",
"2/",
"/3",
"2a/3",
"2/3a",
" 2/3",
"2/ 3",
"2 /3 ",
"23",
"2,3",
"-2/3",
"2/-3",
"2/3/1",
"blahblah",
"0xA/0x10",
};
for (size_t i = 0; i < arraysize(test_cases); ++i) {
int view_id = -1;
InstantRestrictedID rid = -1;
EXPECT_FALSE(ParseViewIdAndRestrictedId(test_cases[i], &view_id, &rid))
<< " for test_cases[" << i << "]";
EXPECT_EQ(-1, view_id);
EXPECT_EQ(-1, rid);
}
}
TEST(SearchBoxUtilTest, ParseIconRestrictedUrlFaviconSuccess) {
struct {
SearchBox::ImageSourceType type;
const char* transient_url_str;
const char* expected_param_part;
int expected_view_id;
InstantRestrictedID expected_rid;
} test_cases[] = {
{FAVICON, "chrome-search://favicon/1/2", "", 1, 2},
{FAVICON, "chrome-search://favicon/size/16@2x/3/4", "size/16@2x/", 3, 4},
{FAVICON, "chrome-search://favicon/largest/5/6", "largest/", 5, 6},
{FAVICON, "chrome-search://favicon/origin/7/8", "origin/", 7, 8},
{FAVICON, "chrome-search://favicon/iconurl/9/10", "iconurl/", 9, 10},
{LARGE_ICON, "chrome-search://large-icon/96/1/2", "96/", 1, 2},
{LARGE_ICON, "chrome-search://large-icon/1/3/4", "1/", 3, 4},
// Size restriction is *not* enforced during parsing, but later.
{LARGE_ICON, "chrome-search://large-icon/1000000/5/6", "1000000/", 5, 6},
{FALLBACK_ICON, "chrome-search://fallback-icon/,,,,/1/2", ",,,,/", 1, 2},
{FALLBACK_ICON, "chrome-search://fallback-icon/1,,,,/3/4", "1,,,,/", 3, 4},
{FALLBACK_ICON, "chrome-search://fallback-icon/64,fff,black,0.4,0.6/5/6",
"64,fff,black,0.4,0.6/", 5, 6},
{THUMB, "chrome-search://thumb/1/2", "", 1, 2},
};
for (size_t i = 0; i < arraysize(test_cases); ++i) {
std::string param_part = "(unwritten)";
int view_id = -1;
InstantRestrictedID rid = -1;
EXPECT_TRUE(ParseIconRestrictedUrl(GURL(test_cases[i].transient_url_str),
test_cases[i].type, ¶m_part, &view_id, &rid))
<< " for test_cases[" << i << "]";
EXPECT_EQ(test_cases[i].expected_param_part, param_part)
<< " for test_cases[" << i << "]";
EXPECT_EQ(test_cases[i].expected_view_id, view_id)
<< " for test_cases[" << i << "]";
EXPECT_EQ(test_cases[i].expected_rid, rid)
<< " for test_cases[" << i << "]";
}
}
TEST(SearchBoxUtilTest, ParseIconRestrictedUrlFailure) {
struct {
SearchBox::ImageSourceType type;
const char* transient_url_str;
} test_cases[] = {
{FAVICON, "chrome-search://favicon/"},
{FAVICON, "chrome-search://favicon/3/"},
{FAVICON, "chrome-search://favicon/size/3/4"},
{FAVICON, "chrome-search://favicon/largest/http://www.google.com"},
{FAVICON, "chrome-search://favicon/size/16@2x/-1/10"},
{LARGE_ICON, "chrome-search://large-icon/"},
{LARGE_ICON, "chrome-search://large-icon/3"},
{LARGE_ICON, "chrome-search://large-icon/3/4"},
{LARGE_ICON, "chrome-search://large-icon/-1/3/4"},
{LARGE_ICON, "chrome-search://large-icon/0/3/4"},
{LARGE_ICON, "chrome-search://large-icon/64/http://www.google.com"},
{LARGE_ICON, "chrome-search://large-icon/bad-size/3/4"},
{FALLBACK_ICON, "chrome-search://fallback-icon/"},
{FALLBACK_ICON, "chrome-search://fallback-icon/3"},
{FALLBACK_ICON, "chrome-search://fallback-icon/3/4"},
{FALLBACK_ICON, "chrome-search://fallback-icon//3/4"},
{FALLBACK_ICON, "chrome-search://fallback-icon/,,/3/4"},
{FALLBACK_ICON, "chrome-search://fallback-icon/bad-spec/3/4"},
{FALLBACK_ICON, "chrome-search://fallback-icon/-1,,,,/3/4"},
{FALLBACK_ICON, "chrome-search://fallback-icon/,junk,,,/3/4"},
// This case is a bit stringent. Since we always render fallback icons,
// search privider can't use this to probe user history. We'll consider
// relaxing the check if the need arises.
{FALLBACK_ICON, "chrome-search://fallback-icon/,,,,/http://www.google.com"},
{THUMB, "chrome-search://thumb"},
{THUMB, "chrome-search://thumb/"},
{THUMB, "chrome-search://thumb/123"},
{THUMB, "chrome-search://thumb/xyz"},
{THUMB, "chrome-search://thumb/123/"},
{THUMB, "chrome-search://thumb/123/xyz"},
{THUMB, "chrome-search://thumb/http://www.google.com"},
};
for (size_t i = 0; i < arraysize(test_cases); ++i) {
std::string param_part = "(unwritten)";
int view_id = -1;
InstantRestrictedID rid = -1;
EXPECT_FALSE(ParseIconRestrictedUrl(GURL(test_cases[i].transient_url_str),
test_cases[i].type, ¶m_part, &view_id, &rid))
<< " for test_cases[" << i << "]";
EXPECT_EQ("(unwritten)", param_part);
EXPECT_EQ(-1, view_id);
EXPECT_EQ(-1, rid);
}
}
TEST(SearchBoxUtilTest, TranslateIconRestrictedUrlSuccess) {
struct {
SearchBox::ImageSourceType type;
const char* transient_url_str;
std::string expected_url_str;
} test_cases[] = {
{FAVICON, "chrome-search://favicon/137/1",
std::string("chrome-search://favicon/") + kUrlString1},
// FAVICON is permission: invalid input just yields default endpoint.
{FAVICON, "chrome-search://favicon/", "chrome-search://favicon/"},
{FAVICON, "chrome-search://favicon/314", "chrome-search://favicon/"},
{FAVICON, "chrome-search://favicon/314/1", "chrome-search://favicon/"},
{FAVICON, "chrome-search://favicon/137/255", "chrome-search://favicon/"},
{FAVICON, "chrome-search://favicon/-3/-1", "chrome-search://favicon/"},
{FAVICON, "chrome-search://favicon/invalidstuff",
"chrome-search://favicon/"},
{FAVICON, "chrome-search://favicon/size/16@2x/http://www.google.com",
"chrome-search://favicon/"},
// Other types of icons.
{LARGE_ICON, "chrome-search://large-icon/64/137/2",
std::string("chrome-search://large-icon/64/") + kUrlString2},
{LARGE_ICON, "chrome-search://large-icon/1/137/1",
std::string("chrome-search://large-icon/1/") + kUrlString1},
{FALLBACK_ICON, "chrome-search://fallback-icon/,,,,/137/3",
std::string("chrome-search://fallback-icon/,,,,/") + kUrlString3},
{FALLBACK_ICON, "chrome-search://fallback-icon/64,fff,,,1/137/1",
std::string("chrome-search://fallback-icon/64,fff,,,1/") + kUrlString1},
{THUMB, "chrome-search://thumb/137/3",
std::string("chrome-search://thumb/") + kUrlString3},
};
MockIconURLHelper helper;
for (size_t i = 0; i < arraysize(test_cases); ++i) {
GURL url;
GURL transient_url(test_cases[i].transient_url_str);
EXPECT_TRUE(TranslateIconRestrictedUrl(transient_url, test_cases[i].type,
helper, &url))
<< " for test_cases[" << i << "]";
EXPECT_EQ(GURL(test_cases[i].expected_url_str), url)
<< " for test_cases[" << i << "]";
}
}
// For Non-FAVICON only.
TEST(SearchBoxUtilTest, TranslateIconRestrictedUrlFailure) {
struct {
SearchBox::ImageSourceType type;
const char* transient_url_str;
} test_cases[] = {
// Empty.
{LARGE_ICON, "chrome-search://large-icon/"},
{FALLBACK_ICON, "chrome-search://fallback-icon/"},
{THUMB, "chrome-search://thumb/"},
// Bad view_id.
{LARGE_ICON, "chrome-search://large-icon/64/314/2"},
{LARGE_ICON, "chrome-search://large-icon/1/314/1"},
{FALLBACK_ICON, "chrome-search://fallback-icon/,,,,/314/3"},
{FALLBACK_ICON, "chrome-search://fallback-icon/64,fff,,,1/314/1"},
{THUMB, "chrome-search://thumb/314/1"},
// Missing rid.
{LARGE_ICON, "chrome-search://large-icon/64/137/"},
{LARGE_ICON, "chrome-search://large-icon/64/137/blah"},
{FALLBACK_ICON, "chrome-search://fallback-icon/,,,,/137/"},
{THUMB, "chrome-search://thumb/314/"},
// Bad params.
{LARGE_ICON, "chrome-search://large-icon/137/2"},
{LARGE_ICON, "chrome-search://large-icon//137/2"},
{LARGE_ICON, "chrome-search://large-icon/96"},
{LARGE_ICON, "chrome-search://large-icon/-1/137/2"},
{LARGE_ICON, "chrome-search://large-icon/blah/137/2"},
{FALLBACK_ICON, "chrome-search://fallback-icon/137/3"},
{FALLBACK_ICON, "chrome-search://fallback-icon//137/3"},
{FALLBACK_ICON, "chrome-search://fallback-icon/-64,fff,,,1/137/3"},
{FALLBACK_ICON, "chrome-search://fallback-icon/springfront/137/3"},
// Use Page URL.
{LARGE_ICON, "chrome-search://large-icon/96/http://www.google.com"},
{FALLBACK_ICON, "chrome-search://fallback-icon/,,,,/http://www.google.com"},
{THUMB, "chrome-search://thumb/http://www.google.com"},
};
MockIconURLHelper helper;
for (size_t i = 0; i < arraysize(test_cases); ++i) {
GURL url;
GURL transient_url(test_cases[i].transient_url_str);
EXPECT_FALSE(TranslateIconRestrictedUrl(transient_url, test_cases[i].type,
helper, &url))
<< " for test_cases[" << i << "]";
EXPECT_TRUE(url.is_empty()) << " for test_cases[" << i << "]";
}
}
} // namespace internal