forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathnon_client_frame_view_ash_unittest.cc
897 lines (753 loc) · 35.5 KB
/
non_client_frame_view_ash_unittest.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/frame/non_client_frame_view_ash.h"
#include <memory>
#include "ash/accelerators/accelerator_controller_impl.h"
#include "ash/frame/header_view.h"
#include "ash/frame/wide_frame_view.h"
#include "ash/resources/vector_icons/vector_icons.h"
#include "ash/shell.h"
#include "ash/test/ash_test_base.h"
#include "ash/wm/desks/desks_util.h"
#include "ash/wm/overview/overview_controller.h"
#include "ash/wm/splitview/split_view_controller.h"
#include "ash/wm/tablet_mode/tablet_mode_controller.h"
#include "ash/wm/window_state.h"
#include "ash/wm/window_state_delegate.h"
#include "ash/wm/wm_event.h"
#include "base/command_line.h"
#include "base/containers/flat_set.h"
#include "chromeos/ui/base/window_properties.h"
#include "chromeos/ui/frame/caption_buttons/frame_caption_button_container_view.h"
#include "chromeos/ui/frame/default_frame_header.h"
#include "chromeos/ui/frame/immersive/immersive_fullscreen_controller.h"
#include "chromeos/ui/frame/immersive/immersive_fullscreen_controller_test_api.h"
#include "chromeos/ui/vector_icons/vector_icons.h"
#include "ui/aura/client/aura_constants.h"
#include "ui/aura/window.h"
#include "ui/aura/window_targeter.h"
#include "ui/base/accelerators/accelerator.h"
#include "ui/base/accelerators/test_accelerator_target.h"
#include "ui/base/ui_base_features.h"
#include "ui/compositor/layer.h"
#include "ui/compositor/test/draw_waiter_for_test.h"
#include "ui/events/test/event_generator.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/image/image_skia.h"
#include "ui/gfx/image/image_unittest_util.h"
#include "ui/gfx/vector_icon_types.h"
#include "ui/views/widget/widget.h"
#include "ui/views/widget/widget_delegate.h"
#include "ui/views/window/caption_button_layout_constants.h"
#include "ui/views/window/frame_caption_button.h"
#include "ui/views/window/vector_icons/vector_icons.h"
#include "ui/wm/core/window_util.h"
namespace ash {
using ::chromeos::DefaultFrameHeader;
using ::chromeos::FrameCaptionButtonContainerView;
using ::chromeos::ImmersiveFullscreenController;
using ::chromeos::ImmersiveFullscreenControllerDelegate;
using ::chromeos::ImmersiveFullscreenControllerTestApi;
using ::chromeos::kFrameActiveColorKey;
using ::chromeos::kFrameInactiveColorKey;
// A views::WidgetDelegate which uses a NonClientFrameViewAsh.
class NonClientFrameViewAshTestWidgetDelegate
: public views::WidgetDelegateView {
public:
NonClientFrameViewAshTestWidgetDelegate() = default;
NonClientFrameViewAshTestWidgetDelegate(
const NonClientFrameViewAshTestWidgetDelegate&) = delete;
NonClientFrameViewAshTestWidgetDelegate& operator=(
const NonClientFrameViewAshTestWidgetDelegate&) = delete;
~NonClientFrameViewAshTestWidgetDelegate() override = default;
std::unique_ptr<views::NonClientFrameView> CreateNonClientFrameView(
views::Widget* widget) override {
auto non_client_frame_view =
std::make_unique<NonClientFrameViewAsh>(widget);
non_client_frame_view_ = non_client_frame_view.get();
return non_client_frame_view;
}
int GetNonClientFrameViewTopBorderHeight() {
return non_client_frame_view_->NonClientTopBorderHeight();
}
NonClientFrameViewAsh* non_client_frame_view() const {
return non_client_frame_view_;
}
HeaderView* header_view() const {
return non_client_frame_view_->header_view_;
}
private:
// Not owned.
NonClientFrameViewAsh* non_client_frame_view_ = nullptr;
};
class TestWidgetConstraintsDelegate
: public NonClientFrameViewAshTestWidgetDelegate {
public:
TestWidgetConstraintsDelegate() {
SetCanMaximize(true);
SetCanMinimize(true);
}
TestWidgetConstraintsDelegate(const TestWidgetConstraintsDelegate&) = delete;
TestWidgetConstraintsDelegate& operator=(
const TestWidgetConstraintsDelegate&) = delete;
~TestWidgetConstraintsDelegate() override = default;
// views::View:
gfx::Size GetMinimumSize() const override { return minimum_size_; }
gfx::Size GetMaximumSize() const override { return maximum_size_; }
views::View* GetContentsView() override {
// Set this instance as the contents view so that the maximum and minimum
// size constraints will be used.
return this;
}
// views::WidgetDelegate:
void set_minimum_size(const gfx::Size& min_size) { minimum_size_ = min_size; }
void set_maximum_size(const gfx::Size& max_size) { maximum_size_ = max_size; }
const gfx::Rect& GetFrameCaptionButtonContainerViewBounds() {
return non_client_frame_view()
->GetFrameCaptionButtonContainerViewForTest()
->bounds();
}
void EndFrameCaptionButtonContainerViewAnimations() {
FrameCaptionButtonContainerView::TestApi test(
non_client_frame_view()->GetFrameCaptionButtonContainerViewForTest());
test.EndAnimations();
}
int GetTitleBarHeight() const {
return non_client_frame_view()->NonClientTopBorderHeight();
}
private:
gfx::Size minimum_size_;
gfx::Size maximum_size_;
};
using NonClientFrameViewAshTest = AshTestBase;
// Verifies the client view is not placed at a y location of 0.
TEST_F(NonClientFrameViewAshTest, ClientViewCorrectlyPlaced) {
std::unique_ptr<views::Widget> widget =
CreateTestWidget(new NonClientFrameViewAshTestWidgetDelegate);
EXPECT_NE(0, widget->client_view()->bounds().y());
}
// Test that the height of the header is correct upon initially displaying
// the widget.
TEST_F(NonClientFrameViewAshTest, HeaderHeight) {
NonClientFrameViewAshTestWidgetDelegate* delegate =
new NonClientFrameViewAshTestWidgetDelegate;
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
// The header should have enough room for the window controls. The
// header/content separator line overlays the window controls.
EXPECT_EQ(views::GetCaptionButtonLayoutSize(
views::CaptionButtonLayoutSize::kNonBrowserCaption)
.height(),
delegate->non_client_frame_view()->GetHeaderView()->height());
}
// Regression test for https://crbug.com/839955
TEST_F(NonClientFrameViewAshTest, ActiveStateOfButtonMatchesWidget) {
NonClientFrameViewAshTestWidgetDelegate* delegate =
new NonClientFrameViewAshTestWidgetDelegate;
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
FrameCaptionButtonContainerView::TestApi test_api(
delegate->non_client_frame_view()
->GetHeaderView()
->caption_button_container());
widget->Show();
EXPECT_TRUE(widget->IsActive());
// The paint state doesn't change till the next paint.
ui::DrawWaiterForTest::WaitForCommit(widget->GetLayer()->GetCompositor());
EXPECT_TRUE(test_api.size_button()->GetPaintAsActive());
// Activate a different widget so the original one loses activation.
std::unique_ptr<views::Widget> widget2 =
CreateTestWidget(new NonClientFrameViewAshTestWidgetDelegate);
widget2->Show();
ui::DrawWaiterForTest::WaitForCommit(widget->GetLayer()->GetCompositor());
EXPECT_FALSE(widget->IsActive());
EXPECT_FALSE(test_api.size_button()->GetPaintAsActive());
}
// Verify that NonClientFrameViewAsh returns the correct minimum and maximum
// frame sizes when the client view does not specify any size constraints.
TEST_F(NonClientFrameViewAshTest, NoSizeConstraints) {
TestWidgetConstraintsDelegate* delegate = new TestWidgetConstraintsDelegate;
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
NonClientFrameViewAsh* non_client_frame_view =
delegate->non_client_frame_view();
gfx::Size min_frame_size = non_client_frame_view->GetMinimumSize();
gfx::Size max_frame_size = non_client_frame_view->GetMaximumSize();
EXPECT_EQ(delegate->GetTitleBarHeight(), min_frame_size.height());
// A width and height constraint of 0 denotes unbounded.
EXPECT_EQ(0, max_frame_size.width());
EXPECT_EQ(0, max_frame_size.height());
}
// Verify that NonClientFrameViewAsh returns the correct minimum and maximum
// frame sizes when the client view specifies size constraints.
TEST_F(NonClientFrameViewAshTest, MinimumAndMaximumSize) {
gfx::Size min_client_size(500, 500);
gfx::Size max_client_size(800, 800);
TestWidgetConstraintsDelegate* delegate = new TestWidgetConstraintsDelegate;
delegate->set_minimum_size(min_client_size);
delegate->set_maximum_size(max_client_size);
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
NonClientFrameViewAsh* non_client_frame_view =
delegate->non_client_frame_view();
gfx::Size min_frame_size = non_client_frame_view->GetMinimumSize();
gfx::Size max_frame_size = non_client_frame_view->GetMaximumSize();
EXPECT_EQ(min_client_size.width(), min_frame_size.width());
EXPECT_EQ(max_client_size.width(), max_frame_size.width());
EXPECT_EQ(min_client_size.height() + delegate->GetTitleBarHeight(),
min_frame_size.height());
EXPECT_EQ(max_client_size.height() + delegate->GetTitleBarHeight(),
max_frame_size.height());
}
// Verify that NonClientFrameViewAsh updates the avatar icon based on the
// avatar icon window property.
TEST_F(NonClientFrameViewAshTest, AvatarIcon) {
TestWidgetConstraintsDelegate* delegate = new TestWidgetConstraintsDelegate;
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
NonClientFrameViewAsh* non_client_frame_view =
delegate->non_client_frame_view();
EXPECT_FALSE(non_client_frame_view->GetAvatarIconViewForTest());
// Avatar image becomes available.
widget->GetNativeWindow()->SetProperty(
aura::client::kAvatarIconKey,
new gfx::ImageSkia(gfx::test::CreateImage(27, 27).AsImageSkia()));
EXPECT_TRUE(non_client_frame_view->GetAvatarIconViewForTest());
// Avatar image is gone; the ImageView for the avatar icon should be
// removed.
widget->GetNativeWindow()->ClearProperty(aura::client::kAvatarIconKey);
EXPECT_FALSE(non_client_frame_view->GetAvatarIconViewForTest());
}
// Tests that a window is minimized, toggling tablet mode doesn't trigger
// caption button update (https://crbug.com/822890).
TEST_F(NonClientFrameViewAshTest, ToggleTabletModeOnMinimizedWindow) {
NonClientFrameViewAshTestWidgetDelegate* delegate =
new NonClientFrameViewAshTestWidgetDelegate;
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
FrameCaptionButtonContainerView::TestApi test(
delegate->non_client_frame_view()
->GetHeaderView()
->caption_button_container());
widget->Maximize();
// Restore icon for size button in maximized window state. Compare by name
// because the address may not be the same for different build targets in the
// component build.
EXPECT_STREQ(views::kWindowControlRestoreIcon.name,
test.size_button()->icon_definition_for_test()->name);
widget->Minimize();
// Enter and exit tablet mode while the window is minimized.
Shell::Get()->tablet_mode_controller()->SetEnabledForTest(true);
Shell::Get()->tablet_mode_controller()->SetEnabledForTest(false);
// When unminimizing in non-tablet mode, size button should match with
// maximized window state, which is restore icon.
::wm::Unminimize(widget->GetNativeWindow());
EXPECT_TRUE(widget->IsMaximized());
EXPECT_STREQ(views::kWindowControlRestoreIcon.name,
test.size_button()->icon_definition_for_test()->name);
}
// Verify that when in tablet mode with a maximized window, the height of the
// header is zero.
TEST_F(NonClientFrameViewAshTest, FrameHiddenInTabletModeForMaximizedWindows) {
NonClientFrameViewAshTestWidgetDelegate* delegate =
new NonClientFrameViewAshTestWidgetDelegate;
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
widget->Maximize();
Shell::Get()->tablet_mode_controller()->SetEnabledForTest(true);
EXPECT_EQ(0, delegate->GetNonClientFrameViewTopBorderHeight());
}
// Verify that when in tablet mode with a non maximized window, the height of
// the header is non zero.
TEST_F(NonClientFrameViewAshTest,
FrameShownInTabletModeForNonMaximizedWindows) {
auto* delegate = new NonClientFrameViewAshTestWidgetDelegate();
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
Shell::Get()->tablet_mode_controller()->SetEnabledForTest(true);
EXPECT_EQ(views::GetCaptionButtonLayoutSize(
views::CaptionButtonLayoutSize::kNonBrowserCaption)
.height(),
delegate->GetNonClientFrameViewTopBorderHeight());
}
// Verify that if originally in fullscreen mode, and enter tablet mode, the
// height of the header remains zero.
TEST_F(NonClientFrameViewAshTest,
FrameRemainsHiddenInTabletModeWhenTogglingFullscreen) {
NonClientFrameViewAshTestWidgetDelegate* delegate =
new NonClientFrameViewAshTestWidgetDelegate;
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
widget->SetFullscreen(true);
EXPECT_EQ(0, delegate->GetNonClientFrameViewTopBorderHeight());
Shell::Get()->tablet_mode_controller()->SetEnabledForTest(true);
EXPECT_EQ(0, delegate->GetNonClientFrameViewTopBorderHeight());
Shell::Get()->tablet_mode_controller()->SetEnabledForTest(false);
EXPECT_EQ(0, delegate->GetNonClientFrameViewTopBorderHeight());
}
TEST_F(NonClientFrameViewAshTest, OpeningAppsInTabletMode) {
auto* delegate = new TestWidgetConstraintsDelegate;
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
widget->Maximize();
Shell::Get()->tablet_mode_controller()->SetEnabledForTest(true);
EXPECT_EQ(0, delegate->GetNonClientFrameViewTopBorderHeight());
// Verify that after minimizing and showing the widget, the height of the
// header is zero.
widget->Minimize();
widget->Show();
EXPECT_TRUE(widget->IsMaximized());
EXPECT_EQ(0, delegate->GetNonClientFrameViewTopBorderHeight());
// Verify that when we toggle maximize, the header is shown. For example,
// maximized can be toggled in tablet mode by using the accessibility
// keyboard.
WMEvent event(WM_EVENT_TOGGLE_MAXIMIZE);
WindowState::Get(widget->GetNativeWindow())->OnWMEvent(&event);
EXPECT_EQ(0, delegate->GetNonClientFrameViewTopBorderHeight());
Shell::Get()->tablet_mode_controller()->SetEnabledForTest(false);
EXPECT_EQ(views::GetCaptionButtonLayoutSize(
views::CaptionButtonLayoutSize::kNonBrowserCaption)
.height(),
delegate->GetNonClientFrameViewTopBorderHeight());
}
// Test if creating a new window in tablet mode uses maximzied state
// and immersive mode.
TEST_F(NonClientFrameViewAshTest, GetPreferredOnScreenHeightInTabletMaximzied) {
Shell::Get()->tablet_mode_controller()->SetEnabledForTest(true);
auto* delegate = new TestWidgetConstraintsDelegate;
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
auto* frame_view = static_cast<NonClientFrameViewAsh*>(
widget->non_client_view()->frame_view());
auto* header_view = frame_view->GetHeaderView();
ASSERT_TRUE(widget->IsMaximized());
EXPECT_TRUE(header_view->in_immersive_mode());
static_cast<ImmersiveFullscreenControllerDelegate*>(header_view)
->SetVisibleFraction(0.5);
// The height should be ~(33 *.5)
EXPECT_NEAR(16, header_view->GetPreferredOnScreenHeight(), 1);
static_cast<ImmersiveFullscreenControllerDelegate*>(header_view)
->SetVisibleFraction(0.0);
EXPECT_EQ(0, header_view->GetPreferredOnScreenHeight());
}
// Verify windows that are minimized and then entered into tablet mode will have
// no header when unminimized in tablet mode.
TEST_F(NonClientFrameViewAshTest, MinimizedWindowsInTabletMode) {
std::unique_ptr<views::Widget> widget =
CreateTestWidget(new NonClientFrameViewAshTestWidgetDelegate);
widget->GetNativeWindow()->SetProperty(
aura::client::kResizeBehaviorKey,
aura::client::kResizeBehaviorCanMaximize);
widget->Maximize();
widget->Minimize();
Shell::Get()->tablet_mode_controller()->SetEnabledForTest(true);
widget->Show();
EXPECT_EQ(widget->non_client_view()->bounds(),
widget->client_view()->bounds());
}
TEST_F(NonClientFrameViewAshTest, HeaderVisibilityInFullscreen) {
auto* delegate = new NonClientFrameViewAshTestWidgetDelegate();
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
NonClientFrameViewAsh* non_client_frame_view =
delegate->non_client_frame_view();
HeaderView* header_view = non_client_frame_view->GetHeaderView();
EXPECT_FALSE(header_view->in_immersive_mode());
EXPECT_TRUE(header_view->GetVisible());
widget->SetFullscreen(true);
widget->LayoutRootViewIfNecessary();
EXPECT_TRUE(header_view->in_immersive_mode());
EXPECT_TRUE(header_view->GetVisible());
widget->SetFullscreen(false);
widget->LayoutRootViewIfNecessary();
EXPECT_FALSE(header_view->in_immersive_mode());
EXPECT_TRUE(header_view->GetVisible());
// Turn immersive off, and make sure that header view is invisible
// in fullscreen.
widget->SetFullscreen(true);
ImmersiveFullscreenController::EnableForWidget(widget.get(), false);
widget->LayoutRootViewIfNecessary();
EXPECT_FALSE(header_view->in_immersive_mode());
EXPECT_FALSE(header_view->GetVisible());
widget->SetFullscreen(false);
widget->LayoutRootViewIfNecessary();
EXPECT_FALSE(header_view->in_immersive_mode());
EXPECT_TRUE(header_view->GetVisible());
}
namespace {
class TestButtonModel : public chromeos::CaptionButtonModel {
public:
TestButtonModel() = default;
TestButtonModel(const TestButtonModel&) = delete;
TestButtonModel& operator=(const TestButtonModel&) = delete;
~TestButtonModel() override = default;
void set_zoom_mode(bool zoom_mode) { zoom_mode_ = zoom_mode; }
void SetVisible(views::CaptionButtonIcon type, bool visible) {
if (visible)
visible_buttons_.insert(type);
else
visible_buttons_.erase(type);
}
void SetEnabled(views::CaptionButtonIcon type, bool enabled) {
if (enabled)
enabled_buttons_.insert(type);
else
enabled_buttons_.erase(type);
}
// CaptionButtonModel::
bool IsVisible(views::CaptionButtonIcon type) const override {
return visible_buttons_.count(type);
}
bool IsEnabled(views::CaptionButtonIcon type) const override {
return enabled_buttons_.count(type);
}
bool InZoomMode() const override { return zoom_mode_; }
private:
base::flat_set<views::CaptionButtonIcon> visible_buttons_;
base::flat_set<views::CaptionButtonIcon> enabled_buttons_;
bool zoom_mode_ = false;
};
} // namespace
TEST_F(NonClientFrameViewAshTest, BackButton) {
AcceleratorControllerImpl* controller =
Shell::Get()->accelerator_controller();
std::unique_ptr<TestButtonModel> model = std::make_unique<TestButtonModel>();
TestButtonModel* model_ptr = model.get();
auto* delegate = new NonClientFrameViewAshTestWidgetDelegate();
std::unique_ptr<views::Widget> widget =
CreateTestWidget(delegate, desks_util::GetActiveDeskContainerId(),
gfx::Rect(0, 0, 400, 500));
ui::Accelerator accelerator_back_press(ui::VKEY_BROWSER_BACK, ui::EF_NONE);
accelerator_back_press.set_key_state(ui::Accelerator::KeyState::PRESSED);
ui::TestAcceleratorTarget target_back_press;
controller->Register({accelerator_back_press}, &target_back_press);
ui::Accelerator accelerator_back_release(ui::VKEY_BROWSER_BACK, ui::EF_NONE);
accelerator_back_release.set_key_state(ui::Accelerator::KeyState::RELEASED);
ui::TestAcceleratorTarget target_back_release;
controller->Register({accelerator_back_release}, &target_back_release);
NonClientFrameViewAsh* non_client_frame_view =
delegate->non_client_frame_view();
non_client_frame_view->SetCaptionButtonModel(std::move(model));
HeaderView* header_view = non_client_frame_view->GetHeaderView();
EXPECT_FALSE(header_view->GetBackButton());
model_ptr->SetVisible(views::CAPTION_BUTTON_ICON_BACK, true);
non_client_frame_view->SizeConstraintsChanged();
widget->LayoutRootViewIfNecessary();
EXPECT_TRUE(header_view->GetBackButton());
EXPECT_FALSE(header_view->GetBackButton()->GetEnabled());
// Back button is disabled, so clicking on it should not should
// generate back key sequence.
ui::test::EventGenerator* generator = GetEventGenerator();
generator->MoveMouseTo(
header_view->GetBackButton()->GetBoundsInScreen().CenterPoint());
generator->ClickLeftButton();
EXPECT_EQ(0, target_back_press.accelerator_count());
EXPECT_EQ(0, target_back_release.accelerator_count());
model_ptr->SetEnabled(views::CAPTION_BUTTON_ICON_BACK, true);
non_client_frame_view->SizeConstraintsChanged();
widget->LayoutRootViewIfNecessary();
EXPECT_TRUE(header_view->GetBackButton());
EXPECT_TRUE(header_view->GetBackButton()->GetEnabled());
// Back button is now enabled, so clicking on it should generate
// back key sequence.
generator->MoveMouseTo(
header_view->GetBackButton()->GetBoundsInScreen().CenterPoint());
generator->ClickLeftButton();
EXPECT_EQ(1, target_back_press.accelerator_count());
EXPECT_EQ(1, target_back_release.accelerator_count());
model_ptr->SetVisible(views::CAPTION_BUTTON_ICON_BACK, false);
non_client_frame_view->SizeConstraintsChanged();
widget->LayoutRootViewIfNecessary();
EXPECT_FALSE(header_view->GetBackButton());
}
// Make sure that client view occupies the entire window when the
// frame is hidden.
TEST_F(NonClientFrameViewAshTest, FrameVisibility) {
NonClientFrameViewAshTestWidgetDelegate* delegate =
new NonClientFrameViewAshTestWidgetDelegate;
gfx::Rect window_bounds(10, 10, 200, 100);
std::unique_ptr<views::Widget> widget = CreateTestWidget(
delegate, desks_util::GetActiveDeskContainerId(), window_bounds);
// The height is smaller by the top border height.
gfx::Size client_bounds(200, 68);
NonClientFrameViewAsh* non_client_frame_view =
delegate->non_client_frame_view();
EXPECT_EQ(client_bounds, widget->client_view()->GetLocalBounds().size());
non_client_frame_view->SetFrameEnabled(false);
widget->GetRootView()->Layout();
EXPECT_EQ(gfx::Size(200, 100),
widget->client_view()->GetLocalBounds().size());
EXPECT_FALSE(non_client_frame_view->GetFrameEnabled());
EXPECT_EQ(
window_bounds,
non_client_frame_view->GetClientBoundsForWindowBounds(window_bounds));
non_client_frame_view->SetFrameEnabled(true);
widget->GetRootView()->Layout();
EXPECT_EQ(client_bounds, widget->client_view()->GetLocalBounds().size());
EXPECT_TRUE(non_client_frame_view->GetFrameEnabled());
EXPECT_EQ(32, delegate->GetNonClientFrameViewTopBorderHeight());
EXPECT_EQ(
gfx::Rect(gfx::Point(10, 42), client_bounds),
non_client_frame_view->GetClientBoundsForWindowBounds(window_bounds));
}
TEST_F(NonClientFrameViewAshTest, CustomButtonModel) {
std::unique_ptr<TestButtonModel> model = std::make_unique<TestButtonModel>();
TestButtonModel* model_ptr = model.get();
auto* delegate = new NonClientFrameViewAshTestWidgetDelegate();
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
NonClientFrameViewAsh* non_client_frame_view =
delegate->non_client_frame_view();
non_client_frame_view->SetCaptionButtonModel(std::move(model));
HeaderView* header_view = non_client_frame_view->GetHeaderView();
FrameCaptionButtonContainerView::TestApi test_api(
header_view->caption_button_container());
// CLOSE button is always enabled.
EXPECT_TRUE(test_api.close_button());
EXPECT_FALSE(test_api.close_button()->GetVisible());
EXPECT_TRUE(test_api.close_button()->GetEnabled());
model_ptr->SetVisible(views::CAPTION_BUTTON_ICON_CLOSE, true);
non_client_frame_view->SizeConstraintsChanged();
widget->LayoutRootViewIfNecessary();
EXPECT_TRUE(test_api.close_button()->GetVisible());
EXPECT_FALSE(test_api.minimize_button()->GetVisible());
EXPECT_FALSE(test_api.size_button()->GetVisible());
EXPECT_FALSE(test_api.menu_button()->GetVisible());
// Back button
model_ptr->SetVisible(views::CAPTION_BUTTON_ICON_BACK, true);
non_client_frame_view->SizeConstraintsChanged();
widget->LayoutRootViewIfNecessary();
EXPECT_TRUE(header_view->GetBackButton()->GetVisible());
EXPECT_FALSE(header_view->GetBackButton()->GetEnabled());
model_ptr->SetEnabled(views::CAPTION_BUTTON_ICON_BACK, true);
non_client_frame_view->SizeConstraintsChanged();
widget->LayoutRootViewIfNecessary();
EXPECT_TRUE(header_view->GetBackButton()->GetEnabled());
// size button
model_ptr->SetVisible(views::CAPTION_BUTTON_ICON_MAXIMIZE_RESTORE, true);
non_client_frame_view->SizeConstraintsChanged();
widget->LayoutRootViewIfNecessary();
EXPECT_TRUE(test_api.size_button()->GetVisible());
EXPECT_FALSE(test_api.size_button()->GetEnabled());
model_ptr->SetEnabled(views::CAPTION_BUTTON_ICON_MAXIMIZE_RESTORE, true);
non_client_frame_view->SizeConstraintsChanged();
widget->LayoutRootViewIfNecessary();
EXPECT_TRUE(test_api.size_button()->GetEnabled());
// minimize button
model_ptr->SetVisible(views::CAPTION_BUTTON_ICON_MINIMIZE, true);
non_client_frame_view->SizeConstraintsChanged();
widget->LayoutRootViewIfNecessary();
EXPECT_TRUE(test_api.minimize_button()->GetVisible());
EXPECT_FALSE(test_api.minimize_button()->GetEnabled());
model_ptr->SetEnabled(views::CAPTION_BUTTON_ICON_MINIMIZE, true);
non_client_frame_view->SizeConstraintsChanged();
widget->LayoutRootViewIfNecessary();
EXPECT_TRUE(test_api.minimize_button()->GetEnabled());
// menu button
model_ptr->SetVisible(views::CAPTION_BUTTON_ICON_MENU, true);
non_client_frame_view->SizeConstraintsChanged();
widget->LayoutRootViewIfNecessary();
EXPECT_TRUE(test_api.menu_button()->GetVisible());
EXPECT_FALSE(test_api.menu_button()->GetEnabled());
model_ptr->SetEnabled(views::CAPTION_BUTTON_ICON_MENU, true);
non_client_frame_view->SizeConstraintsChanged();
widget->LayoutRootViewIfNecessary();
EXPECT_TRUE(test_api.menu_button()->GetEnabled());
// zoom button
EXPECT_STREQ(views::kWindowControlMaximizeIcon.name,
test_api.size_button()->icon_definition_for_test()->name);
model_ptr->set_zoom_mode(true);
non_client_frame_view->SizeConstraintsChanged();
widget->LayoutRootViewIfNecessary();
EXPECT_STREQ(chromeos::kWindowControlZoomIcon.name,
test_api.size_button()->icon_definition_for_test()->name);
widget->Maximize();
EXPECT_STREQ(chromeos::kWindowControlDezoomIcon.name,
test_api.size_button()->icon_definition_for_test()->name);
}
TEST_F(NonClientFrameViewAshTest, WideFrame) {
auto* delegate = new NonClientFrameViewAshTestWidgetDelegate();
std::unique_ptr<views::Widget> widget =
CreateTestWidget(delegate, desks_util::GetActiveDeskContainerId(),
gfx::Rect(100, 0, 400, 500));
NonClientFrameViewAsh* non_client_frame_view =
delegate->non_client_frame_view();
HeaderView* header_view = non_client_frame_view->GetHeaderView();
widget->Maximize();
std::unique_ptr<WideFrameView> wide_frame_view =
std::make_unique<WideFrameView>(widget.get());
wide_frame_view->GetWidget()->Show();
HeaderView* wide_header_view = wide_frame_view->header_view();
display::Screen* screen = display::Screen::GetScreen();
const gfx::Rect work_area = screen->GetPrimaryDisplay().work_area();
gfx::Rect frame_bounds =
wide_frame_view->GetWidget()->GetWindowBoundsInScreen();
EXPECT_EQ(work_area.width(), frame_bounds.width());
EXPECT_EQ(work_area.origin(), frame_bounds.origin());
EXPECT_FALSE(header_view->should_paint());
EXPECT_TRUE(wide_header_view->should_paint());
// Test immersive.
ImmersiveFullscreenController controller;
wide_frame_view->Init(&controller);
EXPECT_FALSE(wide_header_view->in_immersive_mode());
EXPECT_FALSE(header_view->in_immersive_mode());
EXPECT_TRUE(header_view->GetVisible());
ImmersiveFullscreenController::EnableForWidget(widget.get(), true);
EXPECT_TRUE(header_view->in_immersive_mode());
EXPECT_TRUE(wide_header_view->in_immersive_mode());
EXPECT_TRUE(header_view->GetVisible());
// The height should be ~(33 *.5)
wide_header_view->SetVisibleFraction(0.5);
EXPECT_NEAR(16, wide_header_view->GetPreferredOnScreenHeight(), 1);
// Make sure the frame can be revaled outside of the target window.
EXPECT_FALSE(ImmersiveFullscreenControllerTestApi(&controller)
.IsTopEdgeHoverTimerRunning());
ui::test::EventGenerator* generator = GetEventGenerator();
generator->MoveMouseTo(gfx::Point(10, 0));
generator->MoveMouseBy(1, 0);
EXPECT_TRUE(ImmersiveFullscreenControllerTestApi(&controller)
.IsTopEdgeHoverTimerRunning());
generator->MoveMouseTo(gfx::Point(10, 10));
generator->MoveMouseBy(1, 0);
EXPECT_FALSE(ImmersiveFullscreenControllerTestApi(&controller)
.IsTopEdgeHoverTimerRunning());
generator->MoveMouseTo(gfx::Point(600, 0));
generator->MoveMouseBy(1, 0);
EXPECT_TRUE(ImmersiveFullscreenControllerTestApi(&controller)
.IsTopEdgeHoverTimerRunning());
ImmersiveFullscreenController::EnableForWidget(widget.get(), false);
EXPECT_FALSE(header_view->in_immersive_mode());
EXPECT_FALSE(wide_header_view->in_immersive_mode());
// visible fraction should be ignored in non immersive.
wide_header_view->SetVisibleFraction(0.5);
EXPECT_EQ(32, wide_header_view->GetPreferredOnScreenHeight());
UpdateDisplay("1234x800");
EXPECT_EQ(1234,
wide_frame_view->GetWidget()->GetWindowBoundsInScreen().width());
// Double Click
EXPECT_TRUE(widget->IsMaximized());
generator->MoveMouseToCenterOf(
wide_header_view->GetWidget()->GetNativeWindow());
generator->DoubleClickLeftButton();
EXPECT_FALSE(widget->IsMaximized());
}
TEST_F(NonClientFrameViewAshTest, WideFrameButton) {
auto* delegate = new NonClientFrameViewAshTestWidgetDelegate();
std::unique_ptr<views::Widget> widget =
CreateTestWidget(delegate, desks_util::GetActiveDeskContainerId(),
gfx::Rect(100, 0, 400, 500));
widget->Maximize();
std::unique_ptr<WideFrameView> wide_frame_view =
std::make_unique<WideFrameView>(widget.get());
wide_frame_view->GetWidget()->Show();
HeaderView* header_view = wide_frame_view->header_view();
FrameCaptionButtonContainerView::TestApi test_api(
header_view->caption_button_container());
EXPECT_STREQ(views::kWindowControlRestoreIcon.name,
test_api.size_button()->icon_definition_for_test()->name);
widget->SetFullscreen(true);
header_view->Layout();
EXPECT_STREQ(views::kWindowControlRestoreIcon.name,
test_api.size_button()->icon_definition_for_test()->name);
{
WMEvent event(WM_EVENT_PIN);
WindowState::Get(widget->GetNativeWindow())->OnWMEvent(&event);
header_view->Layout();
EXPECT_STREQ(views::kWindowControlRestoreIcon.name,
test_api.size_button()->icon_definition_for_test()->name);
}
{
WMEvent event(WM_EVENT_TRUSTED_PIN);
WindowState::Get(widget->GetNativeWindow())->OnWMEvent(&event);
header_view->Layout();
EXPECT_STREQ(views::kWindowControlRestoreIcon.name,
test_api.size_button()->icon_definition_for_test()->name);
}
}
namespace {
class NonClientFrameViewAshFrameColorTest
: public NonClientFrameViewAshTest,
public testing::WithParamInterface<bool> {
public:
NonClientFrameViewAshFrameColorTest() = default;
NonClientFrameViewAshFrameColorTest(
const NonClientFrameViewAshFrameColorTest&) = delete;
NonClientFrameViewAshFrameColorTest& operator=(
const NonClientFrameViewAshFrameColorTest&) = delete;
~NonClientFrameViewAshFrameColorTest() override = default;
};
class TestWidgetDelegate : public TestWidgetConstraintsDelegate {
public:
TestWidgetDelegate(bool custom) : custom_(custom) {}
TestWidgetDelegate(const TestWidgetDelegate&) = delete;
TestWidgetDelegate& operator=(const TestWidgetDelegate&) = delete;
~TestWidgetDelegate() override = default;
// views::WidgetDelegate:
std::unique_ptr<views::NonClientFrameView> CreateNonClientFrameView(
views::Widget* widget) override {
if (custom_) {
WindowState* window_state = WindowState::Get(widget->GetNativeWindow());
window_state->SetDelegate(std::make_unique<WindowStateDelegate>());
}
return TestWidgetConstraintsDelegate::CreateNonClientFrameView(widget);
}
private:
bool custom_;
};
} // namespace
// Verify that NonClientFrameViewAsh updates the active color based on the
// kFrameActiveColorKey window property.
TEST_P(NonClientFrameViewAshFrameColorTest, kFrameActiveColorKey) {
TestWidgetDelegate* delegate = new TestWidgetDelegate(GetParam());
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
SkColor active_color =
widget->GetNativeWindow()->GetProperty(kFrameActiveColorKey);
constexpr SkColor new_color = SK_ColorWHITE;
EXPECT_NE(active_color, new_color);
widget->GetNativeWindow()->SetProperty(kFrameActiveColorKey, new_color);
active_color = widget->GetNativeWindow()->GetProperty(kFrameActiveColorKey);
EXPECT_EQ(active_color, new_color);
EXPECT_EQ(new_color,
delegate->non_client_frame_view()->GetActiveFrameColorForTest());
// Test that changing the property updates the caption button images.
FrameCaptionButtonContainerView::TestApi test_api(
delegate->non_client_frame_view()
->GetHeaderView()
->caption_button_container());
ui::DrawWaiterForTest::WaitForCommit(widget->GetLayer()->GetCompositor());
gfx::ImageSkia original_icon_image = test_api.size_button()->icon_image();
widget->GetNativeWindow()->SetProperty(kFrameActiveColorKey, SK_ColorBLACK);
ui::DrawWaiterForTest::WaitForCommit(widget->GetLayer()->GetCompositor());
EXPECT_FALSE(original_icon_image.BackedBySameObjectAs(
test_api.size_button()->icon_image()));
}
// Verify that NonClientFrameViewAsh updates the inactive color based on the
// kFrameInactiveColorKey window property.
TEST_P(NonClientFrameViewAshFrameColorTest, KFrameInactiveColor) {
TestWidgetDelegate* delegate = new TestWidgetDelegate(GetParam());
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
SkColor active_color =
widget->GetNativeWindow()->GetProperty(kFrameInactiveColorKey);
constexpr SkColor new_color = SK_ColorWHITE;
EXPECT_NE(active_color, new_color);
widget->GetNativeWindow()->SetProperty(kFrameInactiveColorKey, new_color);
active_color = widget->GetNativeWindow()->GetProperty(kFrameInactiveColorKey);
EXPECT_EQ(active_color, new_color);
EXPECT_EQ(new_color,
delegate->non_client_frame_view()->GetInactiveFrameColorForTest());
}
// Verify that NonClientFrameViewAsh updates the active color based on the
// kFrameActiveColorKey window property.
TEST_P(NonClientFrameViewAshFrameColorTest, WideFrameInitialColor) {
TestWidgetDelegate* delegate = new TestWidgetDelegate(GetParam());
std::unique_ptr<views::Widget> widget = CreateTestWidget(delegate);
widget->Maximize();
aura::Window* window = widget->GetNativeWindow();
SkColor active_color = window->GetProperty(kFrameActiveColorKey);
SkColor inactive_color = window->GetProperty(kFrameInactiveColorKey);
constexpr SkColor new_active_color = SK_ColorWHITE;
constexpr SkColor new_inactive_color = SK_ColorBLACK;
EXPECT_NE(active_color, new_active_color);
EXPECT_NE(inactive_color, new_inactive_color);
window->SetProperty(kFrameActiveColorKey, new_active_color);
window->SetProperty(kFrameInactiveColorKey, new_inactive_color);
std::unique_ptr<WideFrameView> wide_frame_view =
std::make_unique<WideFrameView>(widget.get());
HeaderView* wide_header_view = wide_frame_view->header_view();
DefaultFrameHeader* header = wide_header_view->GetFrameHeader();
EXPECT_EQ(new_active_color, header->active_frame_color_for_testing());
EXPECT_EQ(new_inactive_color, header->inactive_frame_color_for_testing());
}
// Run frame color tests with and without custom WindowStateDelegate.
INSTANTIATE_TEST_SUITE_P(All,
NonClientFrameViewAshFrameColorTest,
testing::Bool());
} // namespace ash