forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathcookie_store_unittest.h
1888 lines (1659 loc) · 80 KB
/
cookie_store_unittest.h
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef NET_COOKIES_COOKIE_STORE_UNITTEST_H_
#define NET_COOKIES_COOKIE_STORE_UNITTEST_H_
#include <stdint.h>
#include <memory>
#include <set>
#include <string>
#include <vector>
#include "base/bind.h"
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/strings/string_tokenizer.h"
#include "base/task/current_thread.h"
#include "base/test/task_environment.h"
#include "base/threading/thread.h"
#include "base/threading/thread_task_runner_handle.h"
#include "net/cookies/canonical_cookie.h"
#include "net/cookies/cookie_store.h"
#include "net/cookies/cookie_store_test_callbacks.h"
#include "net/cookies/cookie_store_test_helpers.h"
#include "net/cookies/test_cookie_access_delegate.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
#if defined(OS_IOS)
#include "base/ios/ios_util.h"
#endif
// This file declares unittest templates that can be used to test common
// behavior of any CookieStore implementation.
// See cookie_monster_unittest.cc for an example of an implementation.
namespace net {
using base::Thread;
using TimeRange = CookieDeletionInfo::TimeRange;
const int kTimeout = 1000;
const char kValidCookieLine[] = "A=B; path=/";
// The CookieStoreTestTraits must have the following members:
// struct CookieStoreTestTraits {
// // Factory function. Will be called at most once per test.
// static std::unique_ptr<CookieStore> Create();
//
// // Drains the run loop(s) used to deliver cookie change notifications.
// static void DeliverChangeNotifications();
//
// // The cookie store supports cookies with the exclude_httponly() option.
// static const bool supports_http_only;
//
// // The cookie store is able to make the difference between the ".com"
// // and the "com" domains.
// static const bool supports_non_dotted_domains;
//
// // The cookie store does not fold domains with trailing dots (so "com." and
// "com" are different domains).
// static const bool preserves_trailing_dots;
//
// // The cookie store rejects cookies for invalid schemes such as ftp.
// static const bool filters_schemes;
//
// // The cookie store has a bug happening when a path is a substring of
// // another.
// static const bool has_path_prefix_bug;
//
// // The cookie store forbids setting a cookie with an empty name.
// static const bool forbids_setting_empty_name;
//
// // The cookie store supports global tracking of cookie changes (i.e.
// // calls to CookieStore::AddCallbackForAllChanges()).
// static const bool supports_global_cookie_tracking;
//
// // The cookie store supports tracking of cookie changes for an URL (i.e.
// // calls to CookieStore::AddCallbackForUrl()).
// static const bool supports_url_cookie_tracking;
//
// // The cookie store supports tracking of named cookie changes (i.e.
// // calls to CookieStore::AddCallbackForCookie()).
// static const bool supports_named_cookie_tracking;
//
// // The cookie store supports more than one callback per cookie change type.
// static const bool supports_multiple_tracking_callbacks;
//
// // The cookie store correctly distinguishes between OVERWRITE and EXPLICIT
// // (deletion) change causes.
// static const bool has_exact_change_cause;
//
// // The cookie store is guaranteed to deliver cookie changes in the order
// // in which calls were issued. This only applies to changes coming from
// // _different_ calls. If a call results in a cookie overwrite, the deletion
// // change must still be issued before the insertion change.
// static const bool has_exact_change_ordering;
//
// // Time to wait between two cookie insertions to ensure that cookies have
// // different creation times.
// static const int creation_time_granularity_in_ms;
//
// // The cookie store supports setting a CookieAccessDelegate and using it to
// // get the access semantics for each cookie via
// // CookieStore::GetAllCookiesWithAccessSemanticsAsync().
// // If this is not supported, all access semantics will show up as UNKNOWN.
// static const bool supports_cookie_access_semantics;
// };
template <class CookieStoreTestTraits>
class CookieStoreTest : public testing::Test {
protected:
CookieStoreTest()
: http_www_foo_("http://www.foo.com"),
http_bar_foo_("http://bar.foo.com"),
http_www_bar_("http://www.bar.com"),
https_www_foo_("https://www.foo.com"),
ftp_foo_("ftp://ftp.foo.com/"),
ws_www_foo_("ws://www.foo.com"),
wss_www_foo_("wss://www.foo.com"),
www_foo_foo_("http://www.foo.com/foo"),
www_foo_bar_("http://www.foo.com/bar"),
http_baz_com_("http://baz.com"),
http_bar_com_("http://bar.com") {
// This test may be used outside of the net test suite, and thus may not
// have a task environment.
if (!base::CurrentThread::Get()) {
task_environment_ =
std::make_unique<base::test::SingleThreadTaskEnvironment>();
}
}
// Helper methods for the asynchronous Cookie Store API that call the
// asynchronous method and then pump the loop until the callback is invoked,
// finally returning the value.
// TODO(chlily): Consolidate some of these.
std::string GetCookies(CookieStore* cs, const GURL& url) {
DCHECK(cs);
CookieOptions options;
if (!CookieStoreTestTraits::supports_http_only)
options.set_include_httponly();
options.set_same_site_cookie_context(
net::CookieOptions::SameSiteCookieContext::MakeInclusive());
return GetCookiesWithOptions(cs, url, options);
}
std::string GetCookiesWithOptions(CookieStore* cs,
const GURL& url,
const CookieOptions& options) {
return CanonicalCookie::BuildCookieLine(
GetCookieListWithOptions(cs, url, options));
}
CookieList GetCookieListWithOptions(CookieStore* cs,
const GURL& url,
const CookieOptions& options) {
DCHECK(cs);
GetCookieListCallback callback;
cs->GetCookieListWithOptionsAsync(url, options, callback.MakeCallback());
callback.WaitUntilDone();
return callback.cookies();
}
// This does not update the access time on the cookies.
CookieList GetAllCookiesForURL(CookieStore* cs, const GURL& url) {
return GetCookieListWithOptions(cs, url, CookieOptions::MakeAllInclusive());
}
// This does not update the access time on the cookies.
CookieAccessResultList GetExcludedCookiesForURL(CookieStore* cs,
const GURL& url) {
DCHECK(cs);
GetCookieListCallback callback;
CookieOptions options = CookieOptions::MakeAllInclusive();
options.set_return_excluded_cookies();
cs->GetCookieListWithOptionsAsync(url, options, callback.MakeCallback());
callback.WaitUntilDone();
return callback.excluded_cookies();
}
CookieList GetAllCookies(CookieStore* cs) {
DCHECK(cs);
GetAllCookiesCallback callback;
cs->GetAllCookiesAsync(callback.MakeCallback());
callback.WaitUntilDone();
return callback.cookies();
}
bool CreateAndSetCookie(
CookieStore* cs,
const GURL& url,
const std::string& cookie_line,
const CookieOptions& options,
base::Optional<base::Time> server_time = base::nullopt,
base::Optional<base::Time> system_time = base::nullopt) {
auto cookie = CanonicalCookie::Create(
url, cookie_line, system_time.value_or(base::Time::Now()), server_time);
if (!cookie)
return false;
DCHECK(cs);
ResultSavingCookieCallback<CookieAccessResult> callback;
cs->SetCanonicalCookieAsync(std::move(cookie), url, options,
callback.MakeCallback());
callback.WaitUntilDone();
return callback.result().status.IsInclude();
}
bool SetCanonicalCookie(CookieStore* cs,
std::unique_ptr<CanonicalCookie> cookie,
const GURL& source_url,
bool can_modify_httponly) {
DCHECK(cs);
ResultSavingCookieCallback<CookieAccessResult> callback;
CookieOptions options;
if (can_modify_httponly)
options.set_include_httponly();
options.set_same_site_cookie_context(
net::CookieOptions::SameSiteCookieContext::MakeInclusive());
cs->SetCanonicalCookieAsync(std::move(cookie), source_url, options,
callback.MakeCallback());
callback.WaitUntilDone();
return callback.result().status.IsInclude();
}
bool SetCookieWithSystemTime(CookieStore* cs,
const GURL& url,
const std::string& cookie_line,
const base::Time& system_time) {
CookieOptions options;
if (!CookieStoreTestTraits::supports_http_only)
options.set_include_httponly();
options.set_same_site_cookie_context(
net::CookieOptions::SameSiteCookieContext::MakeInclusive());
return CreateAndSetCookie(cs, url, cookie_line, options, base::nullopt,
base::make_optional(system_time));
}
bool SetCookieWithServerTime(CookieStore* cs,
const GURL& url,
const std::string& cookie_line,
const base::Time& server_time) {
CookieOptions options;
if (!CookieStoreTestTraits::supports_http_only)
options.set_include_httponly();
options.set_same_site_cookie_context(
net::CookieOptions::SameSiteCookieContext::MakeInclusive());
return CreateAndSetCookie(cs, url, cookie_line, options,
base::make_optional(server_time));
}
bool SetCookie(CookieStore* cs,
const GURL& url,
const std::string& cookie_line) {
CookieOptions options;
if (!CookieStoreTestTraits::supports_http_only)
options.set_include_httponly();
options.set_same_site_cookie_context(
net::CookieOptions::SameSiteCookieContext::MakeInclusive());
return CreateAndSetCookie(cs, url, cookie_line, options);
}
CookieInclusionStatus CreateAndSetCookieReturnStatus(
CookieStore* cs,
const GURL& url,
const std::string& cookie_line) {
CookieInclusionStatus create_status;
auto cookie = CanonicalCookie::Create(url, cookie_line, base::Time::Now(),
base::nullopt /* server_time */,
&create_status);
if (!cookie)
return create_status;
CookieOptions options;
if (!CookieStoreTestTraits::supports_http_only)
options.set_include_httponly();
// Allow setting SameSite cookies.
options.set_same_site_cookie_context(
net::CookieOptions::SameSiteCookieContext::MakeInclusive());
DCHECK(cs);
ResultSavingCookieCallback<CookieAccessResult> callback;
cs->SetCanonicalCookieAsync(std::move(cookie), url, options,
callback.MakeCallback());
callback.WaitUntilDone();
return callback.result().status;
}
CookieAccessResult SetCanonicalCookieReturnAccessResult(
CookieStore* cs,
std::unique_ptr<CanonicalCookie> cookie,
const GURL& source_url,
bool can_modify_httponly) {
DCHECK(cs);
ResultSavingCookieCallback<CookieAccessResult> callback;
CookieOptions options;
if (can_modify_httponly)
options.set_include_httponly();
options.set_same_site_cookie_context(
net::CookieOptions::SameSiteCookieContext::MakeInclusive());
cs->SetCanonicalCookieAsync(std::move(cookie), source_url, options,
callback.MakeCallback());
callback.WaitUntilDone();
return callback.result();
}
uint32_t DeleteCanonicalCookie(CookieStore* cs,
const CanonicalCookie& cookie) {
DCHECK(cs);
ResultSavingCookieCallback<uint32_t> callback;
cs->DeleteCanonicalCookieAsync(cookie, callback.MakeCallback());
callback.WaitUntilDone();
return callback.result();
}
uint32_t DeleteCreatedInTimeRange(CookieStore* cs,
const TimeRange& creation_range) {
DCHECK(cs);
ResultSavingCookieCallback<uint32_t> callback;
cs->DeleteAllCreatedInTimeRangeAsync(creation_range,
callback.MakeCallback());
callback.WaitUntilDone();
return callback.result();
}
uint32_t DeleteAllCreatedInTimeRange(CookieStore* cs,
CookieDeletionInfo delete_info) {
DCHECK(cs);
ResultSavingCookieCallback<uint32_t> callback;
cs->DeleteAllMatchingInfoAsync(std::move(delete_info),
callback.MakeCallback());
callback.WaitUntilDone();
return callback.result();
}
uint32_t DeleteSessionCookies(CookieStore* cs) {
DCHECK(cs);
ResultSavingCookieCallback<uint32_t> callback;
cs->DeleteSessionCookiesAsync(callback.MakeCallback());
callback.WaitUntilDone();
return callback.result();
}
uint32_t DeleteAll(CookieStore* cs) {
DCHECK(cs);
ResultSavingCookieCallback<uint32_t> callback;
cs->DeleteAllAsync(callback.MakeCallback());
callback.WaitUntilDone();
return callback.result();
}
bool FindAndDeleteCookie(CookieStore* cs,
const std::string& domain,
const std::string& name) {
for (auto& cookie : this->GetAllCookies(cs)) {
if (cookie.Domain() == domain && cookie.Name() == name)
return this->DeleteCanonicalCookie(cs, cookie);
}
return false;
}
// Returns the CookieStore for the test - each test only uses one CookieStore.
CookieStore* GetCookieStore() {
if (!cookie_store_)
cookie_store_ = CookieStoreTestTraits::Create();
return cookie_store_.get();
}
// Resets CookieStore.
void ResetCookieStore() { cookie_store_.reset(); }
// Compares two cookie lines.
void MatchCookieLines(const std::string& line1, const std::string& line2) {
EXPECT_EQ(TokenizeCookieLine(line1), TokenizeCookieLine(line2));
}
// Check the cookie line by polling until equality or a timeout is reached.
void MatchCookieLineWithTimeout(CookieStore* cs,
const GURL& url,
const std::string& line) {
std::string cookies = GetCookies(cs, url);
bool matched = (TokenizeCookieLine(line) == TokenizeCookieLine(cookies));
base::Time polling_end_date = base::Time::Now() +
base::TimeDelta::FromMilliseconds(
CookieStoreTestTraits::creation_time_granularity_in_ms);
while (!matched && base::Time::Now() <= polling_end_date) {
base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(10));
cookies = GetCookies(cs, url);
matched = (TokenizeCookieLine(line) == TokenizeCookieLine(cookies));
}
EXPECT_TRUE(matched) << "\"" << cookies
<< "\" does not match \"" << line << "\"";
}
const CookieURLHelper http_www_foo_;
const CookieURLHelper http_bar_foo_;
const CookieURLHelper http_www_bar_;
const CookieURLHelper https_www_foo_;
const CookieURLHelper ftp_foo_;
const CookieURLHelper ws_www_foo_;
const CookieURLHelper wss_www_foo_;
const CookieURLHelper www_foo_foo_;
const CookieURLHelper www_foo_bar_;
const CookieURLHelper http_baz_com_;
const CookieURLHelper http_bar_com_;
std::unique_ptr<base::test::SingleThreadTaskEnvironment> task_environment_;
private:
// Returns a set of strings of type "name=value". Fails in case of duplicate.
std::set<std::string> TokenizeCookieLine(const std::string& line) {
std::set<std::string> tokens;
base::StringTokenizer tokenizer(line, " ;");
while (tokenizer.GetNext())
EXPECT_TRUE(tokens.insert(tokenizer.token()).second);
return tokens;
}
std::unique_ptr<CookieStore> cookie_store_;
};
TYPED_TEST_SUITE_P(CookieStoreTest);
TYPED_TEST_P(CookieStoreTest, FilterTest) {
CookieStore* cs = this->GetCookieStore();
base::Time two_hours_ago = base::Time::Now() - base::TimeDelta::FromHours(2);
base::Time one_hour_ago = base::Time::Now() - base::TimeDelta::FromHours(1);
base::Time one_hour_from_now =
base::Time::Now() + base::TimeDelta::FromHours(1);
std::unique_ptr<CanonicalCookie> cc(CanonicalCookie::CreateSanitizedCookie(
this->www_foo_foo_.url(), "A", "B", std::string(), "/foo", one_hour_ago,
one_hour_from_now, base::Time(), false, false,
CookieSameSite::STRICT_MODE, COOKIE_PRIORITY_DEFAULT, false));
ASSERT_TRUE(cc);
EXPECT_TRUE(this->SetCanonicalCookie(
cs, std::move(cc), this->www_foo_foo_.url(), true /*modify_httponly*/));
// Note that for the creation time to be set exactly, without modification,
// it must be different from the one set by the line above.
cc = CanonicalCookie::CreateSanitizedCookie(
this->www_foo_bar_.url(), "C", "D", this->www_foo_bar_.domain(), "/bar",
two_hours_ago, base::Time(), one_hour_ago, false, true,
CookieSameSite::STRICT_MODE, COOKIE_PRIORITY_DEFAULT, false);
ASSERT_TRUE(cc);
EXPECT_TRUE(this->SetCanonicalCookie(
cs, std::move(cc), this->www_foo_bar_.url(), true /*modify_httponly*/));
// We permit creating a a secure cookie with an HTTP URL (since the
// CookieAccessDelegate may permit some sites to be used as such for
// development environment purposes), but it can't actually be set in this
// test since no such delegate is configured here.
cc = CanonicalCookie::CreateSanitizedCookie(
this->http_www_foo_.url(), "E", "F", std::string(), std::string(),
base::Time(), base::Time(), base::Time(), true, false,
CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT, false);
ASSERT_TRUE(cc);
EXPECT_FALSE(this->SetCanonicalCookie(
cs, std::move(cc), this->http_www_foo_.url(), true /*modify_httponly*/));
cc = CanonicalCookie::CreateSanitizedCookie(
this->https_www_foo_.url(), "E", "F", std::string(), std::string(),
base::Time(), base::Time(), base::Time(), true, false,
CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT, false);
ASSERT_TRUE(cc);
EXPECT_TRUE(this->SetCanonicalCookie(
cs, std::move(cc), this->https_www_foo_.url(), true /*modify_httponly*/));
// Get all the cookies for a given URL, regardless of properties. This 'get()'
// operation shouldn't update the access time, as the test checks that the
// access time is set properly upon creation. Updating the access time would
// make that difficult.
CookieList cookies = this->GetAllCookiesForURL(cs, this->www_foo_foo_.url());
CookieList::iterator it = cookies.begin();
ASSERT_TRUE(it != cookies.end());
EXPECT_EQ("A", it->Name());
EXPECT_EQ("B", it->Value());
EXPECT_EQ(this->www_foo_foo_.host(), it->Domain());
EXPECT_EQ("/foo", it->Path());
EXPECT_EQ(one_hour_ago, it->CreationDate());
EXPECT_TRUE(it->IsPersistent());
// Expect expiration date is in the right range. Some cookie implementations
// may not record it with millisecond accuracy.
EXPECT_LE((one_hour_from_now - it->ExpiryDate()).magnitude().InSeconds(), 5);
// Some CookieStores don't store last access date.
if (!it->LastAccessDate().is_null())
EXPECT_EQ(one_hour_ago, it->LastAccessDate());
EXPECT_FALSE(it->IsSecure());
EXPECT_FALSE(it->IsHttpOnly());
ASSERT_TRUE(++it == cookies.end());
// Verify that the cookie was set as 'httponly' by passing in a CookieOptions
// that excludes them and getting an empty result.
if (TypeParam::supports_http_only) {
net::CookieOptions options;
options.set_same_site_cookie_context(
net::CookieOptions::SameSiteCookieContext::MakeInclusive());
cookies =
this->GetCookieListWithOptions(cs, this->www_foo_bar_.url(), options);
it = cookies.begin();
ASSERT_TRUE(it == cookies.end());
}
// Get the cookie using the wide open |options|:
cookies = this->GetAllCookiesForURL(cs, this->www_foo_bar_.url());
it = cookies.begin();
ASSERT_TRUE(it != cookies.end());
EXPECT_EQ("C", it->Name());
EXPECT_EQ("D", it->Value());
EXPECT_EQ(this->www_foo_bar_.Format(".%D"), it->Domain());
EXPECT_EQ("/bar", it->Path());
EXPECT_EQ(two_hours_ago, it->CreationDate());
EXPECT_FALSE(it->IsPersistent());
// Some CookieStores don't store last access date.
if (!it->LastAccessDate().is_null())
EXPECT_EQ(one_hour_ago, it->LastAccessDate());
EXPECT_FALSE(it->IsSecure());
EXPECT_TRUE(it->IsHttpOnly());
EXPECT_TRUE(++it == cookies.end());
cookies = this->GetAllCookiesForURL(cs, this->https_www_foo_.url());
it = cookies.begin();
ASSERT_TRUE(it != cookies.end());
EXPECT_EQ("E", it->Name());
EXPECT_EQ("F", it->Value());
EXPECT_EQ("/", it->Path());
EXPECT_EQ(this->https_www_foo_.host(), it->Domain());
// Cookie should have its creation time set, and be in a reasonable range.
EXPECT_LE((base::Time::Now() - it->CreationDate()).magnitude().InMinutes(),
2);
EXPECT_FALSE(it->IsPersistent());
// Some CookieStores don't store last access date.
if (!it->LastAccessDate().is_null())
EXPECT_EQ(it->CreationDate(), it->LastAccessDate());
EXPECT_TRUE(it->IsSecure());
EXPECT_FALSE(it->IsHttpOnly());
EXPECT_TRUE(++it == cookies.end());
}
TYPED_TEST_P(CookieStoreTest, SetCanonicalCookieTest) {
CookieStore* cs = this->GetCookieStore();
base::Time two_hours_ago = base::Time::Now() - base::TimeDelta::FromHours(2);
base::Time one_hour_ago = base::Time::Now() - base::TimeDelta::FromHours(1);
base::Time one_hour_from_now =
base::Time::Now() + base::TimeDelta::FromHours(1);
std::string foo_foo_host(this->www_foo_foo_.url().host());
std::string foo_bar_domain(this->www_foo_bar_.domain());
std::string http_foo_host(this->http_www_foo_.url().host());
std::string https_foo_host(this->https_www_foo_.url().host());
EXPECT_TRUE(this->SetCanonicalCookie(
cs,
CanonicalCookie::CreateUnsafeCookieForTesting(
"A", "B", foo_foo_host, "/foo", one_hour_ago, one_hour_from_now,
base::Time(), false /* secure */, false /* httponly */,
CookieSameSite::LAX_MODE, COOKIE_PRIORITY_DEFAULT, false),
this->www_foo_foo_.url(), true));
EXPECT_TRUE(this->SetCanonicalCookie(
cs,
CanonicalCookie::CreateUnsafeCookieForTesting(
"C", "D", "." + foo_bar_domain, "/bar", two_hours_ago, base::Time(),
one_hour_ago, false, true, CookieSameSite::LAX_MODE,
COOKIE_PRIORITY_DEFAULT, false),
this->www_foo_bar_.url(), true));
// A secure source is required for setting secure cookies.
EXPECT_TRUE(
this->SetCanonicalCookieReturnAccessResult(
cs,
CanonicalCookie::CreateUnsafeCookieForTesting(
"E", "F", http_foo_host, "/", base::Time(), base::Time(),
base::Time(), true, false, CookieSameSite::NO_RESTRICTION,
COOKIE_PRIORITY_DEFAULT, false),
this->http_www_foo_.url(), true)
.status.HasExclusionReason(
CookieInclusionStatus::EXCLUDE_SECURE_ONLY));
// A Secure cookie can be created from an insecure URL, but is rejected upon
// setting.
CookieInclusionStatus status;
auto cookie = CanonicalCookie::Create(
this->http_www_foo_.url(), "foo=1; Secure", base::Time::Now(),
base::nullopt /* server_time */, &status);
EXPECT_TRUE(cookie->IsSecure());
EXPECT_TRUE(status.IsInclude());
EXPECT_TRUE(this->SetCanonicalCookieReturnAccessResult(
cs, std::move(cookie), this->http_www_foo_.url(), true)
.status.HasExclusionReason(
CookieInclusionStatus::EXCLUDE_SECURE_ONLY));
// A secure source is also required for overwriting secure cookies. Writing
// a secure cookie then overwriting it from a non-secure source should fail.
EXPECT_TRUE(this->SetCanonicalCookie(
cs,
CanonicalCookie::CreateUnsafeCookieForTesting(
"E", "F", https_foo_host, "/", base::Time(), base::Time(),
base::Time(), true /* secure */, false /* httponly */,
CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
false /* same_party */),
this->https_www_foo_.url(), true /* modify_http_only */));
EXPECT_TRUE(this->SetCanonicalCookieReturnAccessResult(
cs,
CanonicalCookie::CreateUnsafeCookieForTesting(
"E", "F", http_foo_host, "/", base::Time(),
base::Time(), base::Time(), true /* secure */,
false /* httponly */, CookieSameSite::NO_RESTRICTION,
COOKIE_PRIORITY_DEFAULT, false /* same_party */),
this->http_www_foo_.url(), true /* modify_http_only */)
.status.HasExclusionReason(
CookieInclusionStatus::EXCLUDE_SECURE_ONLY));
if (TypeParam::supports_http_only) {
// Permission to modify http only cookies is required to set an
// httponly cookie.
EXPECT_TRUE(this->SetCanonicalCookieReturnAccessResult(
cs,
CanonicalCookie::CreateUnsafeCookieForTesting(
"G", "H", http_foo_host, "/unique", base::Time(),
base::Time(), base::Time(), false /* secure */,
true /* httponly */, CookieSameSite::LAX_MODE,
COOKIE_PRIORITY_DEFAULT, false /* same_party */),
this->http_www_foo_.url(), false /* modify_http_only */)
.status.HasExclusionReason(
CookieInclusionStatus::EXCLUDE_HTTP_ONLY));
// A HttpOnly cookie can be created, but is rejected
// upon setting if the options do not specify include_httponly.
CookieInclusionStatus create_status;
auto c = CanonicalCookie::Create(
this->http_www_foo_.url(), "bar=1; HttpOnly", base::Time::Now(),
base::nullopt /* server_time */, &create_status);
EXPECT_TRUE(c->IsHttpOnly());
EXPECT_TRUE(create_status.IsInclude());
EXPECT_TRUE(this->SetCanonicalCookieReturnAccessResult(
cs, std::move(c), this->http_www_foo_.url(),
false /* can_modify_httponly */)
.status.HasExclusionReason(
CookieInclusionStatus::EXCLUDE_HTTP_ONLY));
// Permission to modify httponly cookies is also required to overwrite
// an httponly cookie.
EXPECT_TRUE(this->SetCanonicalCookie(
cs,
CanonicalCookie::CreateUnsafeCookieForTesting(
"G", "H", http_foo_host, "/unique", base::Time(), base::Time(),
base::Time(), false /* secure */, true /* httponly */,
CookieSameSite::LAX_MODE, COOKIE_PRIORITY_DEFAULT,
false /* same_party */),
this->http_www_foo_.url(), true /* modify_http_only */));
EXPECT_TRUE(this->SetCanonicalCookieReturnAccessResult(
cs,
CanonicalCookie::CreateUnsafeCookieForTesting(
"G", "H", http_foo_host, "/unique", base::Time(),
base::Time(), base::Time(), false /* secure */,
true /* httponly */, CookieSameSite::LAX_MODE,
COOKIE_PRIORITY_DEFAULT, false /* same_party */),
this->http_www_foo_.url(), false /* modify_http_only */)
.status.HasExclusionReason(
CookieInclusionStatus::EXCLUDE_HTTP_ONLY));
} else {
// Leave store in same state as if the above tests had been run.
EXPECT_TRUE(this->SetCanonicalCookie(
cs,
CanonicalCookie::CreateUnsafeCookieForTesting(
"G", "H", http_foo_host, "/unique", base::Time(), base::Time(),
base::Time(), false /* secure */, true /* httponly */,
CookieSameSite::LAX_MODE, COOKIE_PRIORITY_DEFAULT,
false /* same_party */),
this->http_www_foo_.url(), true /* modify_http_only */));
}
// Get all the cookies for a given URL, regardless of properties. This 'get()'
// operation shouldn't update the access time, as the test checks that the
// access time is set properly upon creation. Updating the access time would
// make that difficult.
CookieList cookies = this->GetAllCookiesForURL(cs, this->www_foo_foo_.url());
CookieList::iterator it = cookies.begin();
ASSERT_EQ(1u, cookies.size());
EXPECT_EQ("A", it->Name());
EXPECT_EQ("B", it->Value());
EXPECT_EQ(this->www_foo_foo_.host(), it->Domain());
EXPECT_EQ("/foo", it->Path());
EXPECT_EQ(one_hour_ago, it->CreationDate());
EXPECT_TRUE(it->IsPersistent());
// Expect expiration date is in the right range. Some cookie implementations
// may not record it with millisecond accuracy.
EXPECT_LE((one_hour_from_now - it->ExpiryDate()).magnitude().InSeconds(), 5);
// Some CookieStores don't store last access date.
if (!it->LastAccessDate().is_null())
EXPECT_EQ(one_hour_ago, it->LastAccessDate());
EXPECT_FALSE(it->IsSecure());
EXPECT_FALSE(it->IsHttpOnly());
// Get the cookie using the wide open |options|:
cookies = this->GetAllCookiesForURL(cs, this->www_foo_bar_.url());
ASSERT_EQ(1u, cookies.size());
it = cookies.begin();
EXPECT_EQ("C", it->Name());
EXPECT_EQ("D", it->Value());
EXPECT_EQ(this->www_foo_bar_.Format(".%D"), it->Domain());
EXPECT_EQ("/bar", it->Path());
EXPECT_EQ(two_hours_ago, it->CreationDate());
EXPECT_FALSE(it->IsPersistent());
// Some CookieStores don't store last access date.
if (!it->LastAccessDate().is_null())
EXPECT_EQ(one_hour_ago, it->LastAccessDate());
EXPECT_FALSE(it->IsSecure());
EXPECT_TRUE(it->IsHttpOnly());
cookies = this->GetAllCookiesForURL(cs, this->https_www_foo_.url());
ASSERT_EQ(1u, cookies.size());
it = cookies.begin();
EXPECT_EQ("E", it->Name());
EXPECT_EQ("F", it->Value());
EXPECT_EQ("/", it->Path());
EXPECT_EQ(this->https_www_foo_.host(), it->Domain());
// Cookie should have its creation time set, and be in a reasonable range.
EXPECT_LE((base::Time::Now() - it->CreationDate()).magnitude().InMinutes(),
2);
EXPECT_FALSE(it->IsPersistent());
// Some CookieStores don't store last access date.
if (!it->LastAccessDate().is_null())
EXPECT_EQ(it->CreationDate(), it->LastAccessDate());
EXPECT_TRUE(it->IsSecure());
EXPECT_FALSE(it->IsHttpOnly());
}
// Test enforcement around setting secure cookies.
TYPED_TEST_P(CookieStoreTest, SecureEnforcement) {
CookieStore* cs = this->GetCookieStore();
GURL http_url(this->http_www_foo_.url());
std::string http_domain(http_url.host());
GURL https_url(this->https_www_foo_.url());
std::string https_domain(https_url.host());
// Confirm that setting the secure attribute from an insecure source fails,
// but the other combinations work.
EXPECT_FALSE(this->SetCanonicalCookie(
cs,
CanonicalCookie::CreateUnsafeCookieForTesting(
"A", "B", http_domain, "/", base::Time::Now(), base::Time(),
base::Time(), true, false, CookieSameSite::STRICT_MODE,
COOKIE_PRIORITY_DEFAULT, false /* same_party */),
http_url, true /*modify_httponly*/));
EXPECT_TRUE(this->SetCanonicalCookie(
cs,
CanonicalCookie::CreateUnsafeCookieForTesting(
"A", "B", http_domain, "/", base::Time::Now(), base::Time(),
base::Time(), true, false, CookieSameSite::STRICT_MODE,
COOKIE_PRIORITY_DEFAULT, false /* same_party */),
https_url, true /*modify_httponly*/));
EXPECT_TRUE(this->SetCanonicalCookie(
cs,
CanonicalCookie::CreateUnsafeCookieForTesting(
"A", "B", http_domain, "/", base::Time::Now(), base::Time(),
base::Time(), false, false, CookieSameSite::STRICT_MODE,
COOKIE_PRIORITY_DEFAULT, false /* same_party */),
https_url, true /*modify_httponly*/));
EXPECT_TRUE(this->SetCanonicalCookie(
cs,
CanonicalCookie::CreateUnsafeCookieForTesting(
"A", "B", http_domain, "/", base::Time::Now(), base::Time(),
base::Time(), false, false, CookieSameSite::STRICT_MODE,
COOKIE_PRIORITY_DEFAULT, false /* same_party */),
http_url, true /*modify_httponly*/));
}
// Check that Secure cookies can be set from a localhost URL, regardless of
// scheme.
TYPED_TEST_P(CookieStoreTest, SecureCookieLocalhost) {
CookieStore* cs = this->GetCookieStore();
EXPECT_TRUE(this->CreateAndSetCookie(cs, GURL("https://localhost/path"),
"A=B;Secure",
CookieOptions::MakeAllInclusive()));
EXPECT_TRUE(this->CreateAndSetCookie(cs, GURL("https://127.0.0.1/path"),
"A=B;Secure",
CookieOptions::MakeAllInclusive()));
EXPECT_TRUE(this->CreateAndSetCookie(cs, GURL("http://localhost/path"),
"A=B;Secure",
CookieOptions::MakeAllInclusive()));
EXPECT_TRUE(this->CreateAndSetCookie(cs, GURL("http://127.0.0.1/path"),
"A=B;Secure",
CookieOptions::MakeAllInclusive()));
EXPECT_TRUE(this->CreateAndSetCookie(cs, GURL("http://[::1]/path"),
"A=B;Secure",
CookieOptions::MakeAllInclusive()));
}
// The iOS networking stack uses the iOS cookie parser, which we do not
// control. While it is spec-compliant, that does not match the practical
// behavior of most UAs in some cases, which we try to replicate. See
// https://crbug.com/638389 for more information.
TYPED_TEST_P(CookieStoreTest, EmptyKeyTest) {
#if !defined(OS_IOS)
CookieStore* cs = this->GetCookieStore();
GURL url1("http://foo1.bar.com");
EXPECT_TRUE(this->SetCookie(cs, url1, "foo"));
EXPECT_EQ("foo", this->GetCookies(cs, url1));
// Cookies with neither name nor value (e.g. `Set-Cookie: =`) are ignored.
GURL url2("http://foo2.bar.com");
EXPECT_TRUE(this->SetCookie(cs, url2, "foo"));
EXPECT_FALSE(this->SetCookie(cs, url2, "\t"));
EXPECT_EQ("foo", this->GetCookies(cs, url2));
GURL url3("http://foo3.bar.com");
EXPECT_TRUE(this->SetCookie(cs, url3, "foo"));
EXPECT_FALSE(this->SetCookie(cs, url3, "="));
EXPECT_EQ("foo", this->GetCookies(cs, url3));
GURL url4("http://foo4.bar.com");
EXPECT_TRUE(this->SetCookie(cs, url4, "foo"));
EXPECT_FALSE(this->SetCookie(cs, url4, ""));
EXPECT_EQ("foo", this->GetCookies(cs, url4));
GURL url5("http://foo5.bar.com");
EXPECT_TRUE(this->SetCookie(cs, url5, "foo"));
EXPECT_FALSE(this->SetCookie(cs, url5, "; bar"));
EXPECT_EQ("foo", this->GetCookies(cs, url5));
GURL url6("http://foo6.bar.com");
EXPECT_TRUE(this->SetCookie(cs, url6, "foo"));
EXPECT_FALSE(this->SetCookie(cs, url6, " "));
EXPECT_EQ("foo", this->GetCookies(cs, url6));
#endif
}
TYPED_TEST_P(CookieStoreTest, DomainTest) {
CookieStore* cs = this->GetCookieStore();
EXPECT_TRUE(this->SetCookie(cs, this->http_www_foo_.url(), "A=B"));
this->MatchCookieLines("A=B",
this->GetCookies(cs, this->http_www_foo_.url()));
EXPECT_TRUE(this->SetCookie(cs, this->http_www_foo_.url(),
this->http_www_foo_.Format("C=D; domain=.%D")));
this->MatchCookieLines("A=B; C=D",
this->GetCookies(cs, this->http_www_foo_.url()));
// Verify that A=B was set as a host cookie rather than a domain
// cookie -- should not be accessible from a sub sub-domain.
this->MatchCookieLines(
"C=D", this->GetCookies(
cs, GURL(this->http_www_foo_.Format("http://foo.www.%D"))));
// Test and make sure we find domain cookies on the same domain.
EXPECT_TRUE(
this->SetCookie(cs, this->http_www_foo_.url(),
this->http_www_foo_.Format("E=F; domain=.www.%D")));
this->MatchCookieLines("A=B; C=D; E=F",
this->GetCookies(cs, this->http_www_foo_.url()));
// Test setting a domain= that doesn't start w/ a dot, should
// treat it as a domain cookie, as if there was a pre-pended dot.
EXPECT_TRUE(
this->SetCookie(cs, this->http_www_foo_.url(),
this->http_www_foo_.Format("G=H; domain=www.%D")));
this->MatchCookieLines("A=B; C=D; E=F; G=H",
this->GetCookies(cs, this->http_www_foo_.url()));
// Test domain enforcement, should fail on a sub-domain or something too deep.
EXPECT_FALSE(this->SetCookie(cs, this->http_www_foo_.url(),
this->http_www_foo_.Format("I=J; domain=.%R")));
this->MatchCookieLines(
std::string(),
this->GetCookies(cs, GURL(this->http_www_foo_.Format("http://a.%R"))));
EXPECT_FALSE(
this->SetCookie(cs, this->http_www_foo_.url(),
this->http_www_foo_.Format("K=L; domain=.bla.www.%D")));
this->MatchCookieLines(
"C=D; E=F; G=H",
this->GetCookies(cs,
GURL(this->http_www_foo_.Format("http://bla.www.%D"))));
this->MatchCookieLines("A=B; C=D; E=F; G=H",
this->GetCookies(cs, this->http_www_foo_.url()));
}
// FireFox recognizes domains containing trailing periods as valid.
// IE and Safari do not. Assert the expected policy here.
TYPED_TEST_P(CookieStoreTest, DomainWithTrailingDotTest) {
CookieStore* cs = this->GetCookieStore();
// These two cases fail because the url, http://www.foo.com, does not match
// the domain given in the cookie line (due to the trailing dots), so the
// cookie is not created.
EXPECT_FALSE(this->SetCookie(cs, this->http_www_foo_.url(),
"a=1; domain=.www.foo.com."));
EXPECT_FALSE(this->SetCookie(cs, this->http_www_foo_.url(),
"b=2; domain=.www.foo.com.."));
this->MatchCookieLines(std::string(),
this->GetCookies(cs, this->http_www_foo_.url()));
GURL url_with_dot("http://www.foo.com.");
GURL url_with_double_dot("http://www.foo.com..");
// This succeeds because the urls match.
EXPECT_TRUE(this->SetCookie(cs, url_with_dot, "a=1; domain=.www.foo.com."));
// This fails because two trailing dots are not allowed, so the cookie is not
// created.
EXPECT_FALSE(
this->SetCookie(cs, url_with_double_dot, "b=2; domain=.www.foo.com.."));
if (TypeParam::preserves_trailing_dots) {
// If the CookieStore preserves trailing dots, then .www.foo.com is not
// considered the same as .www.foo.com.
this->MatchCookieLines(std::string(),
this->GetCookies(cs, this->http_www_foo_.url()));
this->MatchCookieLines("a=1", this->GetCookies(cs, url_with_dot));
} else {
// If the CookieStore does not preserve trailing dots, the domains will both
// be folded into one.
this->MatchCookieLines("a=1",
this->GetCookies(cs, this->http_www_foo_.url()));
this->MatchCookieLines("a=1", this->GetCookies(cs, url_with_dot));
}
}
// Test that cookies can bet set on higher level domains.
TYPED_TEST_P(CookieStoreTest, ValidSubdomainTest) {
CookieStore* cs = this->GetCookieStore();
GURL url_abcd("http://a.b.c.d.com");
GURL url_bcd("http://b.c.d.com");
GURL url_cd("http://c.d.com");
GURL url_d("http://d.com");
EXPECT_TRUE(this->SetCookie(cs, url_abcd, "a=1; domain=.a.b.c.d.com"));
EXPECT_TRUE(this->SetCookie(cs, url_abcd, "b=2; domain=.b.c.d.com"));
EXPECT_TRUE(this->SetCookie(cs, url_abcd, "c=3; domain=.c.d.com"));
EXPECT_TRUE(this->SetCookie(cs, url_abcd, "d=4; domain=.d.com"));
this->MatchCookieLines("a=1; b=2; c=3; d=4", this->GetCookies(cs, url_abcd));
this->MatchCookieLines("b=2; c=3; d=4", this->GetCookies(cs, url_bcd));
this->MatchCookieLines("c=3; d=4", this->GetCookies(cs, url_cd));
this->MatchCookieLines("d=4", this->GetCookies(cs, url_d));
// Check that the same cookie can exist on different sub-domains.
EXPECT_TRUE(this->SetCookie(cs, url_bcd, "X=bcd; domain=.b.c.d.com"));
EXPECT_TRUE(this->SetCookie(cs, url_bcd, "X=cd; domain=.c.d.com"));
this->MatchCookieLines("b=2; c=3; d=4; X=bcd; X=cd",
this->GetCookies(cs, url_bcd));
this->MatchCookieLines("c=3; d=4; X=cd", this->GetCookies(cs, url_cd));
}
// Test that setting a cookie which specifies an invalid domain has
// no side-effect. An invalid domain in this context is one which does
// not match the originating domain.
TYPED_TEST_P(CookieStoreTest, InvalidDomainTest) {
CookieStore* cs = this->GetCookieStore();
GURL url_foobar("http://foo.bar.com");
// More specific sub-domain than allowed.
EXPECT_FALSE(this->SetCookie(cs, url_foobar, "a=1; domain=.yo.foo.bar.com"));
// The iOS networking stack uses the iOS cookie parser, which we do not
// control. Its handling of multiple domain= values in cookie string varies
// depending on iOS version. See https://crbug.com/639167
#if !defined(OS_IOS)
// Regression test for https://crbug.com/601786
EXPECT_FALSE(
this->SetCookie(cs, url_foobar, "a=1; domain=.yo.foo.bar.com; domain="));
#endif // !defined(OS_IOS)
EXPECT_FALSE(this->SetCookie(cs, url_foobar, "b=2; domain=.foo.com"));
EXPECT_FALSE(this->SetCookie(cs, url_foobar, "c=3; domain=.bar.foo.com"));
// Different TLD, but the rest is a substring.
EXPECT_FALSE(this->SetCookie(cs, url_foobar, "d=4; domain=.foo.bar.com.net"));
// A substring that isn't really a parent domain.
EXPECT_FALSE(this->SetCookie(cs, url_foobar, "e=5; domain=ar.com"));
// Completely invalid domains:
EXPECT_FALSE(this->SetCookie(cs, url_foobar, "f=6; domain=."));
EXPECT_FALSE(this->SetCookie(cs, url_foobar, "g=7; domain=/"));
EXPECT_FALSE(
this->SetCookie(cs, url_foobar, "h=8; domain=http://foo.bar.com"));
EXPECT_FALSE(this->SetCookie(cs, url_foobar, "i=9; domain=..foo.bar.com"));
EXPECT_FALSE(this->SetCookie(cs, url_foobar, "j=10; domain=..bar.com"));
// Make sure there isn't something quirky in the domain canonicalization
// that supports full URL semantics.
EXPECT_FALSE(