forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathcast_features_unittest.cc
306 lines (257 loc) · 10.7 KB
/
cast_features_unittest.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chromecast/base/cast_features.h"
#include "base/metrics/field_trial_params.h"
#include "base/values.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace chromecast {
namespace {
const char kTestBooleanFeatureName[] = "test_boolean_feature";
const char kTestBooleanFeatureName2[] = "test_boolean_feature_2";
const char kTestBooleanFeatureName3[] = "test_boolean_feature_3";
const char kTestBooleanFeatureName4[] = "test_boolean_feature_4";
const char kTestParamsFeatureName[] = "test_params_feature";
} // namespace
class CastFeaturesTest : public testing::Test {
public:
CastFeaturesTest() {}
CastFeaturesTest(const CastFeaturesTest&) = delete;
CastFeaturesTest& operator=(const CastFeaturesTest&) = delete;
~CastFeaturesTest() override {}
// testing::Test implementation:
void SetUp() override {
original_feature_list_ = base::FeatureList::ClearInstanceForTesting();
ResetCastFeaturesForTesting();
}
void TearDown() override {
ResetCastFeaturesForTesting();
base::FeatureList::RestoreInstanceForTesting(
std::move(original_feature_list_));
}
private:
std::unique_ptr<base::FeatureList> original_feature_list_;
};
TEST_F(CastFeaturesTest, EnableDisableMultipleBooleanFeatures) {
// Declare several boolean features.
base::Feature bool_feature{kTestBooleanFeatureName,
base::FEATURE_DISABLED_BY_DEFAULT};
base::Feature bool_feature_2{kTestBooleanFeatureName2,
base::FEATURE_ENABLED_BY_DEFAULT};
base::Feature bool_feature_3{kTestBooleanFeatureName3,
base::FEATURE_DISABLED_BY_DEFAULT};
base::Feature bool_feature_4{kTestBooleanFeatureName4,
base::FEATURE_ENABLED_BY_DEFAULT};
// Properly register them
chromecast::SetFeaturesForTest(
{&bool_feature, &bool_feature_2, &bool_feature_3, &bool_feature_4});
// Override those features with DCS configs.
base::Value::List experiments;
base::Value::Dict features;
features.Set(kTestBooleanFeatureName, false);
features.Set(kTestBooleanFeatureName2, false);
features.Set(kTestBooleanFeatureName3, true);
features.Set(kTestBooleanFeatureName4, true);
InitializeFeatureList(features, experiments, "", "", "", "");
// Test that features are properly enabled (they should match the
// DCS config).
ASSERT_FALSE(chromecast::IsFeatureEnabled(bool_feature));
ASSERT_FALSE(chromecast::IsFeatureEnabled(bool_feature_2));
ASSERT_TRUE(chromecast::IsFeatureEnabled(bool_feature_3));
ASSERT_TRUE(chromecast::IsFeatureEnabled(bool_feature_4));
}
TEST_F(CastFeaturesTest, EnableSingleFeatureWithParams) {
// Define a feature with params.
base::Feature test_feature{kTestParamsFeatureName,
base::FEATURE_DISABLED_BY_DEFAULT};
chromecast::SetFeaturesForTest({&test_feature});
// Pass params via DCS.
base::Value::List experiments;
base::Value::Dict features;
base::Value::Dict params;
params.Set("foo_key", "foo");
params.Set("bar_key", "bar");
params.Set("doub_key", "3.14159");
params.Set("long_doub_key", "1.23459999999999999");
params.Set("int_key", "4242");
params.Set("bool_key", "true");
features.Set(kTestParamsFeatureName, std::move(params));
InitializeFeatureList(features, experiments, "", "", "", "");
// Test that this feature is enabled, and params are correct.
ASSERT_TRUE(chromecast::IsFeatureEnabled(test_feature));
ASSERT_EQ("foo",
base::GetFieldTrialParamValueByFeature(test_feature, "foo_key"));
ASSERT_EQ("bar",
base::GetFieldTrialParamValueByFeature(test_feature, "bar_key"));
ASSERT_EQ(3.14159, base::GetFieldTrialParamByFeatureAsDouble(
test_feature, "doub_key", 0.000));
ASSERT_EQ(1.23459999999999999, base::GetFieldTrialParamByFeatureAsDouble(
test_feature, "long_doub_key", 0.000));
ASSERT_EQ(4242, base::GetFieldTrialParamByFeatureAsInt(test_feature,
"int_key", -1));
ASSERT_EQ(true, base::GetFieldTrialParamByFeatureAsBool(test_feature,
"bool_key", false));
}
TEST_F(CastFeaturesTest, CommandLineOverridesDcsAndDefault) {
// Declare several boolean features.
base::Feature bool_feature{kTestBooleanFeatureName,
base::FEATURE_DISABLED_BY_DEFAULT};
base::Feature bool_feature_2{kTestBooleanFeatureName2,
base::FEATURE_ENABLED_BY_DEFAULT};
base::Feature bool_feature_3{kTestBooleanFeatureName3,
base::FEATURE_DISABLED_BY_DEFAULT};
base::Feature bool_feature_4{kTestBooleanFeatureName4,
base::FEATURE_ENABLED_BY_DEFAULT};
// Override those features with DCS configs.
base::Value::List experiments;
base::Value::Dict features;
features.Set(kTestBooleanFeatureName, false);
features.Set(kTestBooleanFeatureName2, false);
features.Set(kTestBooleanFeatureName3, true);
features.Set(kTestBooleanFeatureName4, true);
// Also override a param feature with DCS config.
base::Feature params_feature{kTestParamsFeatureName,
base::FEATURE_ENABLED_BY_DEFAULT};
chromecast::SetFeaturesForTest({&bool_feature, &bool_feature_2,
&bool_feature_3, &bool_feature_4,
¶ms_feature});
base::Value::Dict params;
params.Set("foo_key", "foo");
features.Set(kTestParamsFeatureName, std::move(params));
// Now override with command line flags. Command line flags should have the
// final say.
std::string enabled_features = std::string(kTestBooleanFeatureName)
.append(",")
.append(kTestBooleanFeatureName2);
std::string disabled_features = std::string(kTestBooleanFeatureName4)
.append(",")
.append(kTestParamsFeatureName);
InitializeFeatureList(features, experiments, enabled_features,
disabled_features, "", "");
// Test that features are properly enabled (they should match the
// DCS config).
ASSERT_TRUE(chromecast::IsFeatureEnabled(bool_feature));
ASSERT_TRUE(chromecast::IsFeatureEnabled(bool_feature_2));
ASSERT_TRUE(chromecast::IsFeatureEnabled(bool_feature_3));
ASSERT_FALSE(chromecast::IsFeatureEnabled(bool_feature_4));
// Test that the params feature is disabled, and params are not set.
ASSERT_FALSE(chromecast::IsFeatureEnabled(params_feature));
ASSERT_EQ("",
base::GetFieldTrialParamValueByFeature(params_feature, "foo_key"));
}
TEST_F(CastFeaturesTest, SetEmptyExperiments) {
// Override those features with DCS configs.
base::Value::List experiments;
base::Value::Dict features;
InitializeFeatureList(features, experiments, "", "", "", "");
ASSERT_EQ(0u, GetDCSExperimentIds().size());
}
TEST_F(CastFeaturesTest, SetGoodExperiments) {
// Override those features with DCS configs.
base::Value::List experiments;
base::Value::Dict features;
int32_t ids[] = {12345678, 123, 0, -1};
std::unordered_set<int32_t> expected;
for (int32_t id : ids) {
experiments.Append(id);
expected.insert(id);
}
InitializeFeatureList(features, experiments, "", "", "", "");
ASSERT_EQ(expected, GetDCSExperimentIds());
}
TEST_F(CastFeaturesTest, SetSomeGoodExperiments) {
// Override those features with DCS configs.
base::Value::List experiments;
base::Value::Dict features;
experiments.Append(1234);
experiments.Append("foobar");
experiments.Append(true);
experiments.Append(1);
experiments.Append(1.23456);
std::unordered_set<int32_t> expected;
expected.insert(1234);
expected.insert(1);
InitializeFeatureList(features, experiments, "", "", "", "");
ASSERT_EQ(expected, GetDCSExperimentIds());
}
TEST_F(CastFeaturesTest, SetAllBadExperiments) {
// Override those features with DCS configs.
base::Value::List experiments;
base::Value::Dict features;
experiments.Append("foobar");
experiments.Append(true);
experiments.Append(1.23456);
std::unordered_set<int32_t> expected;
InitializeFeatureList(features, experiments, "", "", "", "");
ASSERT_EQ(expected, GetDCSExperimentIds());
}
TEST_F(CastFeaturesTest, GetOverriddenFeaturesForStorage) {
base::Value::Dict features;
features.Set("bool_key", false);
features.Set("bool_key_2", true);
base::Value::Dict params;
params.Set("foo_key", "foo");
params.Set("bar_key", "bar");
params.Set("doub_key", 3.14159);
params.Set("long_doub_key", 1.234599999999999);
params.Set("int_key", 4242);
params.Set("negint_key", -273);
params.Set("bool_key", true);
features.Set("params_key", std::move(params));
auto dict = GetOverriddenFeaturesForStorage(features);
ASSERT_EQ(3u, dict.size());
auto bval = dict.FindBool("bool_key");
ASSERT_TRUE(bval.has_value());
ASSERT_EQ(false, *bval);
bval = dict.FindBool("bool_key_2");
ASSERT_TRUE(bval.has_value());
ASSERT_EQ(true, *bval);
const auto* dval = dict.FindDict("params_key");
const std::string* sval = nullptr;
ASSERT_TRUE(dval);
ASSERT_EQ(7u, dval->size());
sval = dval->FindString("foo_key");
ASSERT_TRUE(sval);
ASSERT_EQ("foo", *sval);
sval = dval->FindString("bar_key");
ASSERT_TRUE(sval);
ASSERT_EQ("bar", *sval);
sval = dval->FindString("doub_key");
ASSERT_TRUE(sval);
ASSERT_EQ("3.14159", *sval);
sval = dval->FindString("long_doub_key");
ASSERT_TRUE(sval);
ASSERT_EQ("1.234599999999999", *sval);
sval = dval->FindString("int_key");
ASSERT_TRUE(sval);
ASSERT_EQ("4242", *sval);
sval = dval->FindString("negint_key");
ASSERT_TRUE(sval);
ASSERT_EQ("-273", *sval);
sval = dval->FindString("bool_key");
ASSERT_TRUE(sval);
ASSERT_EQ("true", *sval);
}
TEST_F(CastFeaturesTest, GetOverriddenFeaturesForStorage_BadParams) {
base::Value::Dict features;
features.Set("bool_key", false);
features.Set("str_key", "foobar");
features.Set("int_key", 12345);
features.Set("doub_key", 4.5678);
base::Value::Dict params;
params.Set("foo_key", "foo");
features.Set("params_key", std::move(params));
auto dict = GetOverriddenFeaturesForStorage(features);
ASSERT_EQ(2u, dict.size());
auto bval = dict.FindBool("bool_key");
ASSERT_TRUE(bval.has_value());
ASSERT_EQ(false, *bval);
const auto* dval = dict.FindDict("params_key");
ASSERT_TRUE(dval);
ASSERT_EQ(1u, dval->size());
const auto* sval = dval->FindString("foo_key");
ASSERT_TRUE(sval);
ASSERT_EQ("foo", *sval);
}
} // namespace chromecast