Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to change colors. #22

Open
mk-pmb opened this issue May 20, 2023 · 6 comments
Open

Document how to change colors. #22

mk-pmb opened this issue May 20, 2023 · 6 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@mk-pmb
Copy link

mk-pmb commented May 20, 2023

I checked README.md and config.yaml but couldn't find anything about the colors.

@marcolardera
Copy link
Owner

Can you explain this better? I have no idea on what colors you are talking about...

@mk-pmb
Copy link
Author

mk-pmb commented May 20, 2023

Most important would be the code snippets. They currently turn out dark blue on black, so I always have to copy them to my text editor to be able to easily read them. In another terminal they were medium blue and underlined.

@marcolardera
Copy link
Owner

I'm quite confused about that. Seems like a particular terminal setting. By default you should see the code snippets with the syntax highlighting provided by Rich.

@mk-pmb
Copy link
Author

mk-pmb commented May 27, 2023

In that case, Readme should explain (probably in the "Markdown rendering" chapter?) that we use Rich for coloring, and where to find information about configuring Rich.

@marcolardera
Copy link
Owner

Rich is the Python library used for the terminal colors. It's not really configurable right now without editing the source code.

A potential feature idea I get from your feedback is to implement some form of configuration for that, maybe a colors.yaml file or something on that line.

@marcolardera marcolardera added enhancement New feature or request question Further information is requested labels May 29, 2023
@mk-pmb
Copy link
Author

mk-pmb commented May 30, 2023

Configuring colors for Rich should be done upstream in Rich, or in an independent Rich-plugin that might then be used in chatgpt-cli. It would be a bad idea (because off-topic) to add significant portions of such code to the chatgpt-cli repo.

With current information I think the best solution would be to locate or open an upstream feature request ticket for color config, then in README.md or config.yaml, catch readers' expectation with a future-proof headline like "Configuring the colors" and there admit that it's not easily feasible right now, with a link to the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants