Skip to content

Commit 5409bfd

Browse files
authored
Revert "feat: add config for temp path and temp path cleanup on launch (lllyasviel#1992)" (lllyasviel#2502)
This reverts commit 85e8aa8.
1 parent 85e8aa8 commit 5409bfd

File tree

5 files changed

+15
-67
lines changed

5 files changed

+15
-67
lines changed

args_manager.py

+3
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,7 @@
4949
if args_parser.args.disable_in_browser:
5050
args_parser.args.in_browser = False
5151

52+
if args_parser.args.temp_path is None:
53+
args_parser.args.temp_path = os.path.join(gettempdir(), 'Fooocus')
54+
5255
args = args_parser.args

launch.py

+7-14
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import os
2-
import ssl
32
import sys
3+
import ssl
44

55
print('[System ARGV] ' + str(sys.argv))
66

@@ -15,13 +15,15 @@
1515

1616
ssl._create_default_https_context = ssl._create_unverified_context
1717

18+
1819
import platform
1920
import fooocus_version
2021

2122
from build_launcher import build_launcher
22-
from modules.launch_util import is_installed, run, python, run_pip, requirements_met, delete_folder_content
23+
from modules.launch_util import is_installed, run, python, run_pip, requirements_met
2324
from modules.model_loader import load_file_from_url
2425

26+
2527
REINSTALL_ALL = False
2628
TRY_INSTALL_XFORMERS = False
2729

@@ -66,7 +68,6 @@ def prepare_environment():
6668
'https://huggingface.co/lllyasviel/misc/resolve/main/xl-to-v1_interposer-v3.1.safetensors')
6769
]
6870

69-
7071
def ini_args():
7172
from args_manager import args
7273
return args
@@ -76,22 +77,13 @@ def ini_args():
7677
build_launcher()
7778
args = ini_args()
7879

80+
7981
if args.gpu_device_id is not None:
8082
os.environ['CUDA_VISIBLE_DEVICES'] = str(args.gpu_device_id)
8183
print("Set device to:", args.gpu_device_id)
8284

83-
from modules import config
84-
85-
os.environ['GRADIO_TEMP_DIR'] = config.temp_path
86-
87-
if config.temp_path_cleanup_on_launch:
88-
print(f'[Cleanup] Attempting to delete content of temp dir {config.temp_path}')
89-
result = delete_folder_content(config.temp_path, '[Cleanup] ')
90-
if result:
91-
print("[Cleanup] Cleanup successful")
92-
else:
93-
print(f"[Cleanup] Failed to delete content of temp dir.")
9485

86+
from modules import config
9587

9688
def download_models():
9789
for file_name, url in vae_approx_filenames:
@@ -131,4 +123,5 @@ def download_models():
131123

132124
download_models()
133125

126+
134127
from webui import *

modules/config.py

+1-35
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,13 @@
33
import math
44
import numbers
55
import args_manager
6-
import tempfile
76
import modules.flags
87
import modules.sdxl_styles
98

109
from modules.model_loader import load_file_from_url
1110
from modules.util import get_files_from_folder, makedirs_with_log
1211
from modules.flags import Performance, MetadataScheme
1312

14-
1513
def get_config_path(key, default_value):
1614
env = os.getenv(key)
1715
if env is not None and isinstance(env, str):
@@ -20,7 +18,6 @@ def get_config_path(key, default_value):
2018
else:
2119
return os.path.abspath(default_value)
2220

23-
2421
config_path = get_config_path('config_path', "./config.txt")
2522
config_example_path = get_config_path('config_example_path', "config_modification_tutorial.txt")
2623
config_dict = {}
@@ -120,7 +117,7 @@ def get_path_output() -> str:
120117
global config_dict
121118
path_output = get_dir_or_set_default('path_outputs', '../outputs/', make_directory=True)
122119
if args_manager.args.output_path:
123-
print(f'Overriding config value path_outputs with {args_manager.args.output_path}')
120+
print(f'[CONFIG] Overriding config value path_outputs with {args_manager.args.output_path}')
124121
config_dict['path_outputs'] = path_output = args_manager.args.output_path
125122
return path_output
126123

@@ -181,7 +178,6 @@ def get_dir_or_set_default(key, default_value, as_array=False, make_directory=Fa
181178
path_fooocus_expansion = get_dir_or_set_default('path_fooocus_expansion', '../models/prompt_expansion/fooocus_expansion')
182179
path_outputs = get_path_output()
183180

184-
185181
def get_config_item_or_set_default(key, default_value, validator, disable_empty_as_none=False):
186182
global config_dict, visited_keys
187183

@@ -210,36 +206,6 @@ def get_config_item_or_set_default(key, default_value, validator, disable_empty_
210206
return default_value
211207

212208

213-
def init_temp_path(path: str | None, default_path: str) -> str:
214-
if args_manager.args.temp_path:
215-
path = args_manager.args.temp_path
216-
217-
if path != '' and path != default_path:
218-
try:
219-
if not os.path.isabs(path):
220-
path = os.path.abspath(path)
221-
os.makedirs(path, exist_ok=True)
222-
print(f'Using temp path {path}')
223-
return path
224-
except Exception as e:
225-
print(f'Could not create temp path {path}. Reason: {e}')
226-
print(f'Using default temp path {default_path} instead.')
227-
228-
os.makedirs(default_path, exist_ok=True)
229-
return default_path
230-
231-
232-
default_temp_path = os.path.join(tempfile.gettempdir(), 'fooocus')
233-
temp_path = init_temp_path(get_config_item_or_set_default(
234-
key='temp_path',
235-
default_value=default_temp_path,
236-
validator=lambda x: isinstance(x, str),
237-
), default_temp_path)
238-
temp_path_cleanup_on_launch = get_config_item_or_set_default(
239-
key='temp_path_cleanup_on_launch',
240-
default_value=True,
241-
validator=lambda x: isinstance(x, bool)
242-
)
243209
default_base_model_name = get_config_item_or_set_default(
244210
key='default_model',
245211
default_value='model.safetensors',

modules/launch_util.py

+3-17
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import os
22
import importlib
33
import importlib.util
4-
import shutil
54
import subprocess
65
import sys
76
import re
@@ -10,6 +9,9 @@
109
import packaging.version
1110
from packaging.requirements import Requirement
1211

12+
13+
14+
1315
logging.getLogger("torch.distributed.nn").setLevel(logging.ERROR) # sshh...
1416
logging.getLogger("xformers").addFilter(lambda record: 'A matching Triton is not available' not in record.getMessage())
1517

@@ -99,19 +101,3 @@ def requirements_met(requirements_file):
99101

100102
return True
101103

102-
103-
def delete_folder_content(folder, prefix=None):
104-
result = True
105-
106-
for filename in os.listdir(folder):
107-
file_path = os.path.join(folder, filename)
108-
try:
109-
if os.path.isfile(file_path) or os.path.islink(file_path):
110-
os.unlink(file_path)
111-
elif os.path.isdir(file_path):
112-
shutil.rmtree(file_path)
113-
except Exception as e:
114-
print(f'{prefix}Failed to delete {file_path}. Reason: {e}')
115-
result = False
116-
117-
return result

modules/private_logger.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def get_current_html_path(output_format=None):
2121

2222

2323
def log(img, metadata, metadata_parser: MetadataParser | None = None, output_format=None) -> str:
24-
path_outputs = modules.config.temp_path if args_manager.args.disable_image_log else modules.config.path_outputs
24+
path_outputs = args_manager.args.temp_path if args_manager.args.disable_image_log else modules.config.path_outputs
2525
output_format = output_format if output_format else modules.config.default_output_format
2626
date_string, local_temp_filename, only_name = generate_temp_filename(folder=path_outputs, extension=output_format)
2727
os.makedirs(os.path.dirname(local_temp_filename), exist_ok=True)

0 commit comments

Comments
 (0)