This repository was archived by the owner on Mar 10, 2024. It is now read-only.
mobile dnd polyfill support #118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've done some work on the mobile drag and drop polyfill:
timruffles/mobile-drag-drop#44
It aims to implement the HTML5 drag and drop spec as closely as possible, which worked out pretty well.
You can check out the polyfill in combination with your module here:
https://github.com/reppners/angular-drag-and-drop-lists/tree/mobile-polyfill-compatibility
A
bower installshould pull in the polyfill.The reason I need an addition in your module is because the browser implementations are doing something different than is written in the spec. If the spec is implemented strictly it requires to handle the
dragenter-event. Browsers seem to not require it being handled, but the polyfill does because otherwise the algorithm defined in the spec isn't working.I think browsers are doing some magic by checking if an event handler did even exist for the event and if none existed they silently allow the drop.
Anyways.. the additions required are small so I hope you don't mind pulling them in to make the polyfill work for everybody using this library, which would result in "official" support for all mobile browsers when using this library.
Cheers