-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript type support #10
Comments
I rewrote this here for the latest otel apis, latest node APIs and in TS: https://github.com/sesamecare/opentelemetry-node-metrics |
Great work boys! @mentos1386 @djMax Thanks for your efforts. will come back with my feedback as soon as i'm able to try it out in action! Btw, shouldn't this be part of the https://github.com/open-telemetry/opentelemetry-js-contrib repository? Seems like a great addition. |
@fullammo yes, it would be nice if it would be in opentelemetry-js-contrib. There has been some work done on that already, but nothing completed open-telemetry/opentelemetry-js-contrib#1106 |
Hey, awesome project. One thing missing are typescript type definitions. It looks the code base is quite small, would it be worth to "rewrite" in to typescript?
I guess the only type definition missing is for the export itself. That could be written as a
d.ts
definition without any rewrite. As the change itself is very small.The text was updated successfully, but these errors were encountered: