Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript type support #10

Open
mentos1386 opened this issue Nov 3, 2022 · 3 comments
Open

Typescript type support #10

mentos1386 opened this issue Nov 3, 2022 · 3 comments

Comments

@mentos1386
Copy link

mentos1386 commented Nov 3, 2022

Hey, awesome project. One thing missing are typescript type definitions. It looks the code base is quite small, would it be worth to "rewrite" in to typescript?

I guess the only type definition missing is for the export itself. That could be written as a d.ts definition without any rewrite. As the change itself is very small.

@djMax
Copy link

djMax commented Oct 13, 2023

I rewrote this here for the latest otel apis, latest node APIs and in TS: https://github.com/sesamecare/opentelemetry-node-metrics

@fullammo
Copy link

fullammo commented Jan 22, 2024

Great work boys! @mentos1386 @djMax Thanks for your efforts. will come back with my feedback as soon as i'm able to try it out in action! Btw, shouldn't this be part of the https://github.com/open-telemetry/opentelemetry-js-contrib repository? Seems like a great addition.

@mentos1386
Copy link
Author

@fullammo yes, it would be nice if it would be in opentelemetry-js-contrib. There has been some work done on that already, but nothing completed open-telemetry/opentelemetry-js-contrib#1106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants