Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onpress event for Button #601

Merged
merged 10 commits into from
Jun 2, 2024
Merged

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented May 3, 2024

Changes the onclick event handler of Button to onpress because it will now work with:

  • 🖱️ Click events
  • ⌨️ Enter events when focused
  • 👆 Touch events

@marc2332 marc2332 added enhancement 🔥 New feature or request breaking labels May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 79.62963% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 73.91%. Comparing base (702bb8b) to head (0d29c42).

Files Patch % Lines
crates/components/src/button.rs 79.06% 9 Missing ⚠️
crates/components/src/hooks/use_form.rs 0.00% 1 Missing ⚠️
crates/components/src/switch.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage   73.91%   73.91%           
=======================================
  Files         194      194           
  Lines       19913    19941   +28     
=======================================
+ Hits        14718    14739   +21     
- Misses       5195     5202    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review May 15, 2024 19:23
@marc2332 marc2332 merged commit 53ec5c5 into main Jun 2, 2024
4 checks passed
@marc2332 marc2332 deleted the feat/onpress-event-for-button branch June 2, 2024 16:54
This was referenced Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant