Geometry.Edit/Drag support altitude #2448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyihu
changed the title
deyihu
force-pushed
the
edit-support-altitude
branch
from
ee2eb6e to
2a92675
Compare
|
需要增加一下带海拔的Geometry的edit和drag的测试用例 |
fuzhenn
reviewed
Oct 31, 2024
| coordiantes.z = 0; | ||
| const isPoint = !geometry.getGeometries && geometry.isPoint; | ||
| if (isPoint) { | ||
| coordiantes.z = altitude; |
There was a problem hiding this comment.
typo: coordiantes -> coordinates
src/geometry/Geometry.ts
Outdated
| @@ -1953,6 +1953,34 @@ export class Geometry extends JSONAble(Eventable(Handlerable(Class))) { | |||
| return this; | |||
| } | |||
|
|
|||
| getEditCenter() { | |||
There was a problem hiding this comment.
如果这个方法只在editor或drag里用到，可以考虑方法名增加_，并加上 @internal 标签不公开出去
已经修改好 @fuzhenn |
fuzhenn
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2294
fix maptalks/issues#768
Geometry 编辑支持携带海拔