-
Notifications
You must be signed in to change notification settings - Fork 12
WIP: refactor(project-types)!: introduce base class and make groups and lists attribute of project type classes #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mapswipe-workers into refactor-python-workers
started splitting into sub project types
Refactor python workers
add test for group and task creation for tile classification project …
…n test for whole creation workflow
Refactor python workers
Revert "Refactor python workers"
…python-workers Revert "Revert "Refactor python workers""
tileServerA does not exists.
…us arbitrarily large projects could be created
… all integration tests
…ferentiating result tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new structure for project type classes:
BaseProject
TileMapServiceBaseProject
TODOs:
project.py
) Split project types into their own classes #787groups.py
andtasks.py
intoproject.py
. Attributes of those modules should go int dataclassesTask
&Group
and logic into functionscreate_tasks
and create_groups`.project_types.__init__.py
and import them indefinition.py
ProjectType
Enum indefinition.py
:tutorials.py
)ProjectType
Enum indefinition.py
:Testing:
Project Creation
-> Creating in Manager Dashboard - Appears in Mapswipe App
Tutorial Creation
-> Creating in Manager Dashboard - Appears in Mapswipe App
Generating Results
-> Mapping in App, firebase to postgres working
Stats Generation
-> mapping in App, stats get generated in a validatable form (e.g. 3 times 1, 2 times 2, 1 time 3)