Skip to content

Commit 99fefeb

Browse files
authored
Merge pull request #791 from mapswipe/revert-790-revert-789-refactor-python-workers
Revert "Revert "Refactor python workers""
2 parents 237d1b1 + 31c8bce commit 99fefeb

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

mapswipe_workers/mapswipe_workers/project_types/base/project.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,13 @@ def __init__(self, project_draft):
9191

9292
self.tutorialId = project_draft.get("tutorialId", None)
9393

94+
# currently crowdmap specific attributes todo: discuss in group if empty attributes in mapswipe postgres are ok
95+
self.language = project_draft.get("language", "en-us")
96+
self.appId = project_draft.get("appId", None)
97+
self.manualUrl = project_draft.get("manualUrl", None)
98+
99+
100+
94101
# TODO: Implement resultRequiredCounter as property.
95102
# Does not work because for some reason project['group'] = vars()
96103
# and then del project['group'] will delete also project.group.
@@ -172,15 +179,11 @@ def save_project(self):
172179
raise CustomError(e)
173180

174181
try:
175-
self.save_project_to_firebase(project)
176-
self.save_groups_to_firebase(project["projectId"], groups)
177-
self.save_tasks_to_firebase(project["projectId"], groupsOfTasks)
178-
179-
"""self.save_to_firebase(
182+
self.save_to_firebase(
180183
project,
181184
groups,
182185
groupsOfTasks,
183-
)"""
186+
)
184187
logger.info(
185188
f"{self.projectId}" f" - the project has been saved" f" to firebase"
186189
)

mapswipe_workers/mapswipe_workers/project_types/tile_classification/project.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,19 @@ def __init__(self, project_draft: dict):
1919
self.zoomLevel = int(project_draft.get("zoomLevel", 18))
2020
self.tileServer = vars(BaseTileServer(project_draft["tileServer"]))
2121

22+
2223
def validate_geometries(self):
2324
# TODO rename attribute validInputGeometries, it is a path to a geojson.
2425
self.validInputGeometries = save_geojson_to_file(self.projectId, self.geometry)
2526
wkt_geometry = validate_geometries(
2627
self.projectId, self.zoomLevel, self.validInputGeometries
2728
)
2829
return wkt_geometry
30+
31+
def save_to_firebase(self, project, groups, groupsOfTasks):
32+
self.save_project_to_firebase(project)
33+
self.save_groups_to_firebase(project["projectId"], groups)
34+
self.save_tasks_to_firebase(project["projectId"], groupsOfTasks)
2935

3036
def save_project_to_firebase(self, project):
3137
firebase = Firebase()

0 commit comments

Comments
 (0)