Skip to content

#155 Fix RemoveMappersFix to use new 2023.3 RemoveUnusedVariableFix intention action #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

#155 Fix RemoveMappersFix to use new 2023.3 RemoveUnusedVariableFix intention action #162

wants to merge 5 commits into from

Conversation

filiphr
Copy link
Member

@filiphr filiphr commented Nov 26, 2023

No description provided.

@filiphr filiphr mentioned this pull request Nov 26, 2023
Closed
@filiphr
Copy link
Member Author

filiphr commented Nov 26, 2023

I've also submitted JetBrains/intellij-community#2617 in case the IntelliJ team agrees in keeping the getText so that we can use it. Otherwise, we would remove that particular fix until we make 2023.3 the lowest version we support

thunderhook
thunderhook approved these changes Nov 26, 2023
View reviewed changes
Copy link
Contributor

@thunderhook thunderhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Approved the pull request.
Feel free to merge it if you know more about the intellij issue.

@filiphr
Copy link
Member Author

filiphr commented Nov 26, 2023

I'll wait a bit to see what the IntelliJ teams says. If they agree with it then I'll finish this one with that in mind. Otherwise, I'll need to do alternative.

@hduelme hduelme mentioned this pull request Mar 10, 2024
Closed
@filiphr filiphr mentioned this pull request Mar 11, 2024
Merged
@filiphr
Copy link
Member Author

filiphr commented Mar 11, 2024

Closing this in favor of the way better solution by @hduelme in #179

@filiphr filiphr closed this Mar 11, 2024
@filiphr filiphr deleted the 155-fix branch March 16, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderhook thunderhook thunderhook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filiphr @thunderhook