-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build with ideaVersion LATEST-EAP-SNAPSHOT
#155
Comments
…to be downward compatible with WrongUsageOfMappersFactoryInspection
I thought this would be easy. However, they changed a lot of code. My approach with copying the old classes did not work. They also removed the It is still only in the I think we should either:
I am not sure what happens when we switch to 2023.3 as the main version for development. I think this intention cannot run on older versions then? Or does it just not build with that version? We'll see. |
I had a look at it. They didn't remove it. They just changed it. They are now doing: return new RemoveUnusedVariableFix(variable).asIntention(); I've done PR #162 for this |
Done in PR #179 |
In the
LATEST-EAP-SNAPSHOT
they changed the way howRemoveUnusedVariableFix
works, see this commitThe
org.mapstruct.intellij.inspection.WrongUsageOfMappersFactoryInspection.RemoveMappersFix
won't compile anymore since it is expected to be anIntentionAction
instead of aPsiBasedModCommandAction<PsiVariable>
:A quick-fix would be: copy the contents of the old code instead of extending
RemoveUnusedVariableFix
.Additionally it would be good to know why they changed it, and if this is a better way of handling fixes. Therefore we might change our
RemoveMappersFix
respectively.To change the version inside the IDE just change the version to
LATEST-EAP-SNAPSHOT
ingradle.properties
The text was updated successfully, but these errors were encountered: