Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing custom annotations to generated code #101

Open
8 tasks
filiphr opened this issue Jun 5, 2022 · 0 comments
Open
8 tasks

Support passing custom annotations to generated code #101

filiphr opened this issue Jun 5, 2022 · 0 comments
Labels
Milestone

Comments

@filiphr
Copy link
Member

filiphr commented Jun 5, 2022

With the work in PR mapstruct/mapstruct#2792 being done for mapstruct/mapstruct#1574 it would be good to provide some support for the new API in the IntelliJ plugin as well.

Some things that we should do:

  • Auto completion support for AnnotateWith.Element#name and error when name does not exist in target enum.
  • Smart auto completion for AnnotateWith.Element#classes (pick the class type based on the one in the annotation
  • Auto completion for AnnotateWith.Element#enums and error when enum value does not exist
  • Annotation cannot annotated the generated class / method (it doesn't have the right target element type)
  • Error when more than one value type is provided, eg. shorts() and strings()
  • Error when duplicated AnnotateWith.Element#name (more than one having the same name
  • Error when value does not match target annotation value type
  • Error when using array value, but target value is not an array
@filiphr filiphr added the feature label Jun 5, 2022
@filiphr filiphr added this to the 1.4.0 milestone Jun 5, 2022
@filiphr filiphr modified the milestones: 1.4.0, 1.5.0 Nov 13, 2022
@filiphr filiphr modified the milestones: 1.5.0, 1.6.0 Apr 2, 2023
@filiphr filiphr modified the milestones: 1.7.0, 1.7.1 Apr 28, 2024
@filiphr filiphr modified the milestones: 1.8.0, 1.9.0 Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant