Build failing for node v6.5.0 on windows

[springmeyer]

Been trying to get node v6 working on windows. What I've done is:

• Kicked off a node-cpp11 build with visual studio 2015. This pulls directly from nodejs/node rather than the mapbox/node fork because after e94407d we no longer need to carry patches against node to compile with visual studio 2015: https://github.com/mapbox/node-cpp11/blob/master/.travis.yml#L43
• node-cpp11 build worked after fixing a few glitches related to node-cpp11 only
• Branch to try to build node-mapnik on node v6 on windows (just comments all other jobs) over at https://github.com/mapnik/node-mapnik/compare/v6-win
• Failing: https://ci.appveyor.com/project/Mapbox/node-mapnik/build/job/nrqy7mt5wax8cyao

Errors are new and curious:

mapnik-wkt.lib(mapnik_wkt_generator_grammar.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in mapnik_logger.obj [C:\projects\node-mapnik\build\mapnik.vcxproj]
mapnik-json.lib(mapnik_geometry_to_geojson.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in mapnik_logger.obj [C:\projects\node-mapnik\build\mapnik.vcxproj]
mapnik-json.lib(mapnik_json_generator_grammar.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in mapnik_logger.obj [C:\projects\node-mapnik\build\mapnik.vcxproj]
mapnik-json.lib(mapnik_json_feature_grammar.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in mapnik_logger.obj [C:\projects\node-mapnik\build\mapnik.vcxproj]
mapnik-json.lib(generic_json.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in mapnik_logger.obj [C:\projects\node-mapnik\build\mapnik.vcxproj]
mapnik-json.lib(mapnik_json_geometry_grammar.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in mapnik_logger.obj [C:\projects\node-mapnik\build\mapnik.vcxproj]
mapnik-json.lib(mapnik_json_positions_grammar.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in mapnik_logger.obj [C:\projects\node-mapnik\build\mapnik.vcxproj]
libboost_thread-vc140-mt-1_61.lib(tss_pe.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in mapnik_logger.obj [C:\projects\node-mapnik\build\mapnik.vcxproj]
libboost_thread-vc140-mt-1_61.lib(thread.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in mapnik_logger.obj [C:\projects\node-mapnik\build\mapnik.vcxproj]
libboost_system-vc140-mt-1_61.lib(error_code.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in mapnik_logger.obj [C:\projects\node-mapnik\build\mapnik.vcxproj]
     Creating library C:\projects\node-mapnik\build\Release\mapnik.lib and object C:\projects\node-mapnik\build\Release\mapnik.exp
LINK : warning LNK4098: defaultlib 'MSVCRT' conflicts with use of other libs; use /NODEFAULTLIB:library [C:\projects\node-mapnik\build\mapnik.vcxproj]
mapnik-wkt.lib(mapnik_wkt_generator_grammar.obj) : error LNK2001: unresolved external symbol __imp__modf [C:\projects\node-mapnik\build\mapnik.vcxproj]
mapnik-json.lib(mapnik_json_generator_grammar.obj) : error LNK2001: unresolved external symbol __imp__modf [C:\projects\node-mapnik\build\mapnik.vcxproj]
MSVCRT.lib(_chandler4gs_.obj) : error LNK2001: unresolved external symbol __except_handler4_common [C:\projects\node-mapnik\build\mapnik.vcxproj]
libboost_thread-vc140-mt-1_61.lib(thread.obj) : error LNK2001: unresolved external symbol __imp___gmtime64 [C:\projects\node-mapnik\build\mapnik.vcxproj]
libboost_system-vc140-mt-1_61.lib(error_code.obj) : error LNK2001: unresolved external symbol __imp__strerror [C:\projects\node-mapnik\build\mapnik.vcxproj]
C:\projects\node-mapnik\build\Release\mapnik.node : fatal error LNK1120: 4 unresolved externals [C:\projects\node-mapnik\build\mapnik.vcxproj]
gyp ERR! build error 
gyp ERR! stack Error: `msbuild` failed with exit code: 1

[springmeyer]

Oh, this is likely because I'm using upstream node directly and not our fork. Since we've usually changed the runtime to shared in our patches.... like https://github.com/mapbox/node/pull/9/files. Now, for node v4/5 I think I did not change this, or it looks like I may have missed it. So I forgot about it for node v6. So, perhaps we do still need to fork and build with 'RuntimeLibrary': 0 -> 'RuntimeLibrary': 2...

Looking through the node v6 build scripts it looks like there is node_shared variable that toggles this: https://github.com/nodejs/node/blob/dfe1c7e9b809740bbc511a55c668f80a5f5e4c22/common.gypi#L82-L96. Not sure if it does the right thing (might do more than we want) but tried it in: mapbox/node-cpp11@ef06f92

/cc @BergWerkGIS

[springmeyer]

hmm, after mapbox/node-cpp11@ef06f92 and restarting the appveyor job I'm still seeing the same error... @BergWerkGIS help :)

[springmeyer]

made some progress today. Detailed at mapnik/mapnik#3510 (comment). But now blocked on this error I'm unsure the cause of:

Error: The specified module could not be found.
[00:04:22] 
[00:04:22] \\?\C:\projects\node-mapnik\lib\binding\node-v48-win32-x64\mapnik.node
[00:04:22] 

[wilhelmberg]

But now blocked on this error I'm unsure the cause of

This error check has been disabled thus masking that the build has failed and mapnik.node does not exist.

[wilhelmberg]

WRT /MT vs. /MD for node.exe/.lib: This is how its done in windows-builds.

Patching the call to msbuild in node's vsbuild.bat to include this additional msbuild config fragment which forces /MD for the whole node.sln.

I suggest we carry the patch and the props file over to https://github.com/mapbox/node-cpp11/blob/master/windows/build_node.bat
What do you think?

[wilhelmberg]

node-mapnik build is failing in the early stages already when npm is pulling down node headers and node.lib as the directory structure is not as expected and SHASUMS do not match:
https://ci.appveyor.com/project/Mapbox/node-mapnik/build/1.0.1563#L9050

The directory structure for node.exe/.lib on nodejs.org has changed since node@4.
This probably would have to be accounted for in https://github.com/mapbox/node-cpp11/blob/7154967dd0b87abefaae3172999b3d38e40ee9a1/windows/build_node.bat#L44-L57

• https://nodejs.org/dist/v6.5.0/
  • win-x64
  • win-x86
• https://nodejs.org/dist/v0.12.15/
  • x64
  • binaries in root of version directory

[wilhelmberg]

node-mapnik with node@6.5.0 builds successfully (all tests pass) using nodejs's node:
https://ci.appveyor.com/project/Mapbox/node-mapnik/build/1.0.1565

[wilhelmberg]

A hint that failing node-mapnik builds are linked to using Mapbox's node (different directory structure, different SHASUMS, ...).
https://ci.appveyor.com/project/Mapbox/node-mapnik/build/1.0.1567

[wilhelmberg]

Mixing compiler/runtime versions is generally a bad thing and should be avoided (*).
That's why we also build all dependencies from scratch.

To be investigated:

• why node-mapnik (/MD) compiles successfully against stock node.lib (/MT) without mismatch detected for 'RuntimeLibrary' error.
• why all node-mapnik tests pass when built against stock node.lib (/MT) as seen above.

Next steps:

• shortcut: create a "stress test" to check if something blows up using stock /MT node
• long route: Find out if/how CRT objects are passed across module boundaries
  • if yes, then this is a no-go and we have to keep building our own /MD node
  • if no, then we can move on with stock /MT node

---

(*)
except all code that uses CRT objects and is designed in a way that it does not pass these objects across module boundaries.

---

Additional reads about compiler versions and mixing /MD with /MT:

• MSDN: The Great C Runtime (CRT) Refactoring
• Mixing C runtime library versions
• Mixing Multiple Visual Studio Versions in a Program is Evil
• StackOverflow: Mixing /MD and /MT in single dll

[springmeyer]

next action here is to modify the node-cpp11 builds to use the right directory structure for libs and headers that new node-gyp expects. That is the core problem. That was manually fixed by @BergWerkGIS for node v4/5. We should return to this in 2017 and fix node-cpp11 to build the right structure for >= v4 and up automatically. @BergWerkGIS let's hit this in 2017.

[springmeyer]

Update: got a branch that confirms what we've seen above: moving back to stock node.exe works (as far as builds and tests) when the --node-shared=true flag is passed: #758

Next action is to followup on @BergWerkGIS's next steps above:

• shortcut: create a "stress test" to check if something blows up using stock /MT node
• long route: Find out if/how CRT objects are passed across module boundaries
  • if yes, then this is a no-go and we have to keep building our own /MD node
  • if no, then we can move on with stock /MT node

I vote for the shortcut first :) @BergWerkGIS let's sync up in the morning on this.

[wilhelmberg]

hm, hitting a wall with node@4.8.1 and node-mapnik@3.6.0 locally:

λ npm install mapnik@3.6.0
npm WARN package.json investigate-gpx@0.0.1 No license field.
-
> mapnik@3.6.0 install c:\mb\investigate-gpx\node_modules\mapnik
> node-pre-gyp install --fallback-to-build

node-pre-gyp ERR! Tried to download(undefined): https://mapbox-node-binary.s3.amazonaws.com/mapnik/v3.6.0/node-v46-win32-x64-Release.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for mapnik@3.6.0 and node@4.8.1 (node-v46 ABI) (falling back to source compile with node-gyp)

But binary package (https://mapbox-node-binary.s3.amazonaws.com/mapnik/v3.6.0/node-v46-win32-x64-Release.tar.gz) does exist.
???