-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify user if map breaks on font 404 #651
Comments
@pathmapper this looks to be an issue with It's not a regression and exists in https://maputnik.github.io/editor so I suggest we fix in a patch release post |
@orangemug did some testing outside of Maputnik and it appears that only affected tiles are not rendered when a request for glyph fails with a 404 (for the test case above all visible tiles were affected, so it looked like the whole map broke). Opened an upstream issue: mapbox/mapbox-gl-js#9546 There is also a feature request regarding an event when a request for a glyph range PBF returns a bad response, which would be useful to notify the user: mapbox/mapbox-gl-js#9528
👍 |
I ran into a related issue when I was loading glyphs coming from ArcGIS Online. The issue was only in the react layer, and I was able to patch this with some quick and dirty JS changes to the JSX files (here). Has anyone else run into a similar issue? |
With maplibre/maplibre-gl-js#4564, GL JS will attempt to fall back to a locally rendered glyph and warn about the missing PBF instead of crashing. I don’t think there will be an event for Maputnik to hook into, though. |
Follow-up on #395 (comment):
Currently, if map breaks on font 404, there is no notification for the user, neither in the browser console nor in the UI.
Steps to reproduce:
Working version of the style: test.zip
The text was updated successfully, but these errors were encountered: