-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows CMake VS build fails in vendor/icu #2961
Comments
Maybe @tdcosta100 knows how to resolve this |
I need to check the
And then do the commands:
Then try to build again. If it works, the problem is the |
MINGW64 ~/Documents/code/maplibre_test/maplibre-native/platform/windows/vendor/vcpkg (main) I did the fetch. Am I missing a step? |
No, my instruction was wrong, sorry. Please try again with this:
|
Should be fixed in main now: #2966 |
Thanks! |
Describe the bug
Windows CMake build with Visual Studio fails with unresolved external symbol errors for UnicodeString:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A successful build.
Explanation
UnicodeString::length() is defined here: https://github.com/maplibre/maplibre-native/blob/main/vendor/icu/include/unicode/unistr.h#L3906
unistr.h is being included in univchar.h here: https://github.com/maplibre/maplibre-native/blob/main/vendor/icu/src/uinvchar.h#L27
I have not looked into a proper fix.
I hacked the problem by commenting out uprv_isInvariantUnicodeString() in maplibre-native/vendor/icu/src/uinvchar.h since it is not used. It successfully built after I did that.
Platform information (please complete the following information):
MBGL_USE_BUILTIN_ICU was not explicitly set.
The text was updated successfully, but these errors were encountered: