Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Metric Run #2914

Open
sjg-wdw opened this issue Oct 8, 2024 · 4 comments · Fixed by #2944
Open

Performance Metric Run #2914

sjg-wdw opened this issue Oct 8, 2024 · 4 comments · Fixed by #2944
Assignees

Comments

@sjg-wdw
Copy link
Collaborator

sjg-wdw commented Oct 8, 2024

I'd like to get a new run of the performance metrics. Would be good to have one soon and then another one after @adrian-cojocaru's next set of performance changes.

Would like to include the following variants:

  • Legacy OpenGL (@alexcristici which branch is this?)
  • Current OpenGL Drawable
  • Current Vulkan Drawable

I'd like to get a dozen devices. Let's try to distribute more or less evenly over time. How about 6 before 2020 and 6 after?
The idea of running on everything is good. We can see what succeeds and then pick our devices from that. In that case, I'd probably distribute over vendors as much as we could as well.

The other part of this is I'd like someone to run flat out on a modern Android device and calculate a frame rate using the simplest formula possible: Frames / Time
Let's make sure it's one of the devices we have on the device farm too. Then we compare those numbers to make sure they're plausible.

@alexcristici
Copy link
Collaborator

alexcristici commented Oct 8, 2024

Branch for Legacy OpenGL benchmark: https://github.com/maplibre/maplibre-native/tree/android-benchmark-14dec

@alexcristici
Copy link
Collaborator

In BenchmarkActivity.kt there is a variable private var measureFrameTime = true, which can be set to false and it will switch to FPS: Frames / Time.

@sjg-wdw
Copy link
Collaborator Author

sjg-wdw commented Oct 15, 2024

How does that measure, though?
I want to get a measurement with a different path that does not use the same low level measurements we have in place. Just something that divides time by frames.

@alexcristici
Copy link
Collaborator

Yes, it uses different path, activates standard rendering: encoding in parallel with rendering.

@alexcristici alexcristici linked a pull request Oct 16, 2024 that will close this issue
@louwers louwers reopened this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants