Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of _MSC_VER #ifdefs #1613

Open
louwers opened this issue Sep 6, 2023 · 1 comment
Open

Get rid of _MSC_VER #ifdefs #1613

louwers opened this issue Sep 6, 2023 · 1 comment

Comments

@louwers
Copy link
Collaborator

louwers commented Sep 6, 2023

#270 introduced _MSC_VER #ifdefs in the source files.

I think it would be good if we good remove those from source files and instead configure the build tools to ignore those warnings. We should limit the platform specific macros from platform a-specific code as much as possible in my opinion. If we would do this for every platform there would be a lot of noise in the source files.

I'm not really familiar with Windows (cc @ntadej & @tdcosta100).

@ntadej
Copy link
Collaborator

ntadej commented Sep 6, 2023

I think sometimes they are just unavoidable and also we should not ignore warnings globally (unless obvious ones which we already have).

I have some personal stuff to deal with that's why I've been a bit inactive lately but I can hopefully have a look next month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants