Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headless rendering context management needs improvements #1067

Open
ntadej opened this issue Apr 24, 2023 · 0 comments
Open

Headless rendering context management needs improvements #1067

ntadej opened this issue Apr 24, 2023 · 0 comments
Labels
cpp-core

Comments

@ntadej
Copy link
Collaborator

ntadej commented Apr 24, 2023

As spotted in #1042, there are several issues with headless rendering context management:

  • different backends are enabled by gfx::BackendScope
  • gl::HeadlessBackend instance is constructed and destructed independently
  • the (headless) backend owns gfx::RendererBackend owns its own gfx::Context (both are used by gl::HeadlessBackend and gl::Context respectively)
  • gl::HeadlessBackend independetly from gfx::Context activates or deactivates the context
  • gl::Context calls GL functions on cleanup which may not have an active context

Tagging @sjg-wdw as project manager and @alexcristici as we had discussion on the original PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cpp-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ntadej