Skip to content

Fix OpenStreetMap URLs in examples #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Fix OpenStreetMap URLs in examples #30

merged 1 commit into from
Feb 27, 2018

Conversation

rkaravia
Copy link
Contributor

  • Use https everywhere
  • replace ${z}/${x}/${y} by {z}/{x}/{y}

In the OSM wiki,the tile server URLs are specified as:

https://a.tile.openstreetmap.org/${z}/${x}/${y}.png
https://b.tile.openstreetmap.org/${z}/${x}/${y}.png
https://c.tile.openstreetmap.org/${z}/${x}/${y}.png

See https://wiki.openstreetmap.org/wiki/Tile_servers

However, the ${x} notation was never part of the TileJSON specification which consistently uses {x}.

Fixes #18

- Use https everywhere
- replace ${z}/${x}/${y} by {z}/{x}/{y}

In the OSM wiki,the tile server URLs are specified as:

   https://a.tile.openstreetmap.org/${z}/${x}/${y}.png
   https://b.tile.openstreetmap.org/${z}/${x}/${y}.png
   https://c.tile.openstreetmap.org/${z}/${x}/${y}.png

See https://wiki.openstreetmap.org/wiki/Tile_servers

However, the ${x} notation was never part of the TileJSON specification
which consistently uses {x}.

Fixes #18
@mapsam
Copy link
Contributor

mapsam commented Feb 27, 2018

Thanks for the PR @rzoller! This looks great. The usage of ${z} must have been taken directly from the OSM wiki, as you point out. Since the tilejson spec does not use this notation, removing clears it up. Fixing all previous versions seems like a safe choice as well.

Let’s disregard the Travis failure, which was enabled without an actual .travis.yml file - I’ve disabled this since we don’t have any tests.

@mapsam mapsam merged commit 9f2c65b into mapbox:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants