Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on replacing 'request' library #340

Closed
cktang88 opened this issue Dec 26, 2017 · 3 comments
Closed

Thoughts on replacing 'request' library #340

cktang88 opened this issue Dec 26, 2017 · 3 comments

Comments

@cktang88
Copy link
Contributor

cktang88 commented Dec 26, 2017

It seems the only place the request library is used is in lib/install.js, where it's only used for a simple task.
The request library is 52 packages, which take up around 4.22 MB, which seems unjustified for the small one-time usage that it gets included for. Would a PR be welcome to replace it with a lightweight alternative, such as isomorphic-fetch or simple-get or something similar?

@LinusU
Copy link

LinusU commented Mar 8, 2018

ping @springmeyer

Would love to see this happen! I would also be available to help whip up a PR if needed 👍

@dragonfire535
Copy link

Might I recommend snekfetch too? No dependencies at all and very fast.

@springmeyer
Copy link
Contributor

@cktang88 @LinusU @dragonfire535 - I would love to shrink the size of node-pre-gyp. I would welcome a PR that moves to something smaller, as long as the tests still pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants