-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thoughts on replacing 'request' library #340
Comments
ping @springmeyer Would love to see this happen! I would also be available to help whip up a PR if needed 👍 |
Might I recommend snekfetch too? No dependencies at all and very fast. |
@cktang88 @LinusU @dragonfire535 - I would love to shrink the size of node-pre-gyp. I would welcome a PR that moves to something smaller, as long as the tests still pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems the only place the
request
library is used is inlib/install.js
, where it's only used for a simple task.The
request
library is 52 packages, which take up around 4.22 MB, which seems unjustified for the small one-time usage that it gets included for. Would a PR be welcome to replace it with a lightweight alternative, such as isomorphic-fetch or simple-get or something similar?The text was updated successfully, but these errors were encountered: