This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
Updates featureLayer to be interactive only if there is popup content #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on getting this merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch suggests that a feature layer should be considered interactive only if there is a popup attached to it.
By default a vector layer is considered interactive by default. When a layer is "interactive", leaflet adds a class to the DOM that makes the DOM look clickable (by applying the CSS property
cursor: pointer;).Our users have complained about the poor user experience resulting from this: they see a pointer cursor, they try to click on the layer, but nothing happens.