Fixed issue where map still had focus when instruction list was visib… #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
reviewed
Jun 12, 2018
| view.hideRecenterBtn(); | ||
| } else { | ||
| view.showRecenterBtn(); | ||
| if (recenterButtonVisible) { |
There was a problem hiding this comment.
I think recenterButtonVisible can be eliminated by checking if the SummaryBottomSheet is visible here instead with view.isSummaryBottomSheetHidden(). We only want to show if the bottomsheet is currently hidden right?
| @@ -316,6 +316,7 @@ public void hideInstructionList() { | |||
| */ | |||
| public void showInstructionList() { | |||
| onInstructionListVisibilityChanged(true); | |||
| instructionLayout.requestFocus(); | |||
There was a problem hiding this comment.
Does the MapView regain focus okay after the list is hidden?
There was a problem hiding this comment.
Yup it does. I originally added abandonFocus to hideInstructionList, I can re-add it if you want
There was a problem hiding this comment.
No problem, as long as you didn't see any issues
…le. Also fixed issue where when closing the instruction view, the recenter button was always shown.
devotaaabel
force-pushed
the
devota-recenter-issues
branch
from
c7ff8ff
to
c5a2026
Compare
danesfeder
approved these changes
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le. Also fixed issue where when closing the instruction view, the recenter button was always shown. Fixes #1009