Time remaining in SummaryBottomSheet is always in English

[cmahopper]

Android API: 27
Mapbox Navigation SDK version: 0.16.0-beta.1

Time remaining is not localized, it seems. It is always "X day(s) Y hr Z min" no matter what language is set on the device. This seems to be hardcoded in TimeUtils.java.

Maybe I've misunderstood something.

[danesfeder]

Hey @cmahopper 👋 you're correct here - these Strings need to be extracted into our resources and then uploaded to Transifex for translation via contributors. Thanks for pointing this out!

[P-Zenker]

Hey @danesfeder,

I use
Android API: 28
Mapbox Navigation SDK version: 0.18.0

and it still seems not being localized - is that correct?

NavigationRoute.builder(this)
                .accessToken(Mapbox.getAccessToken())
                .language(Locale.GERMAN)
....

// Returns for example 5 hr 12 min
TimeFormatter.formatTimeRemaining(this.getApplication(), CUMapboxUtil.buildBeginningOfLegRouteProgress(directionsRoute).durationRemaining()));

[danesfeder]

@P-Zenker there's another method in TimeFormatter that should help > https://github.com/mapbox/mapbox-navigation-android/blob/master/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/utils/time/TimeFormatter.java#L25-L30

Example usage: https://github.com/mapbox/mapbox-navigation-android/blob/master/libandroid-navigation-ui/src/main/java/com/mapbox/services/android/navigation/ui/v5/summary/SummaryModel.java#L29-L31

[P-Zenker]

Your linked function gives the (correct formatted) arrival time.
I want the time remaining, like you can see in the screenshot

But as you can see the time format is english and not german (5 Std., 12 Min.). On the other hand distance and arrivial time are correct.

Another screenshot to show the wrong remaining time format:

[danesfeder]

Ah I see now sorry about that @P-Zenker - we source those strings from Transifex https://www.transifex.com/mapbox/mapbox-navigation-sdk-for-android/ and it doesn't look like they have been translated for German just yet. Please feel free to contribute those translations and we will update them in the SDK!

[P-Zenker]

No problem - thanks. Translations done ;)

[danesfeder]

@P-Zenker awesome thanks, I'll tag you in the PR that updates them