This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Add an approximate location view. #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian-guerra
force-pushed
the
fabian-accuracy-reduced-view
branch
from
3990c46
to
a0a20e2
Compare
3 tasks
| if (_approximateLayer && (_oldZoom != self.mapView.zoomLevel || _oldHorizontalAccuracy != self.userLocation.location.horizontalAccuracy)) | ||
| { | ||
| CGFloat borderWidth = 2; | ||
| if (self.mapView.zoomLevel < 7) { |
There was a problem hiding this comment.
can we move this zoom level value into a const in case we have to change in the future
maybe like const int maxApproximateZoomLevel = 7 <-- or w.e the correct obj-c syntax is
neelmistry94
approved these changes
Aug 19, 2020
1ec5
approved these changes
Aug 20, 2020
fabian-guerra
force-pushed
the
fabian-accuracy-reduced-view
branch
from
a0a20e2
to
52fc569
Compare
2 tasks
Closed
bamx23
reviewed
Sep 22, 2020
| [self updatePitch]; | ||
| if (@available(iOS 14, *)) { | ||
| #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 140000 | ||
| if (self.mapView.locationManager.accuracyAuthorization == CLAccuracyAuthorizationFullAccuracy) { |
There was a problem hiding this comment.
accuracyAuthorization is optional and PassiveLocationManager in Navigation SDK hasn't implemented this property in 1.0 release. This leads to crashes with Nav SDK 1.0 and Maps SDK 6.2.0 on iOS 14.
There was a problem hiding this comment.
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new approximate location view when
MGLLocationManager.accuracyAuthorizationis set toCLAccuracyAuthorizationReducedAccuracy.