Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 2D conditional terrain coloring #4421

Closed
femski opened this issue Mar 14, 2017 · 4 comments
Closed

Implement 2D conditional terrain coloring #4421

femski opened this issue Mar 14, 2017 · 4 comments

Comments

@femski
Copy link

femski commented Mar 14, 2017

While we wait for 3D terrain, a simple conditional 2D hill-shading would be sufficient for many needs. Something like:

http://ivansanchez.gitlab.io/Leaflet.TileLayer.GL/demo/demo-flood.html

Is this what you will implement in Issue #3730 ? Or is there an example somewhere that demonstrates how we can show conditional terrain today ? Thanks.

@stevage
Copy link
Contributor

stevage commented Mar 15, 2017

Yes, #3730 is about generating hill shading in the browser to simulate a terrain effect. Not sure what you mean by "conditional terrain", but maybe #3889?

@femski
Copy link
Author

femski commented Mar 15, 2017

I meant showing terrain above certain height in red. Those below certain level in transparent and yellow for things in-between.

@stevage
Copy link
Contributor

stevage commented Mar 15, 2017

Yup, that's what #3889 is about - although I don't think anyone has suggested transparent. Note that #3889 is not on anyone's current to-do list, but on many people's wishlist. :)

@mollymerp
Copy link
Contributor

Thanks for your request @femski. @stevage is correct! I'm working on 2d client-side hillshading which will expose several new style-spec properties for controlling how terrain appears on the map. We don't have plans to allow raw elevation querying as part of that effort. I think supporting custom raster sources would cover that use-case. Lets keep conversation centralized in #3889 and #3730.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants