New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundancies in Camera method docs #4286

Closed

anandthakker opened this issue Feb 16, 2017 · 1 comment

Labels

Contributor

anandthakker commented Feb 16, 2017

From: #4266 (review)

@anandthakker said:

options.easing is duplicated here. In fact, for consistency, would it make sense to remove options.easing (and options.offset) in favor of setting the type of [options] to {AnimationOptions}? I realize that, at present, this means more clicks for readers of the docs, but my preference would be to solve that problem somehow in the documentation generation step.

@lucaswoj said:

Good idea. If we go this route, we may also want to:

rename/alias options.linear to options.animate
add options.duration (this will just be passed to Map#flyTo)

anandthakker added the docs 📜 label

anandthakker mentioned this issue

Clarify easing function requirements and clean up references to Anima… #4266

Merged

Contributor

lucaswoj commented Feb 17, 2017

On further thought, I think we should focus our energies on #2801 / #3583 rather than iterating on the existing fitBounds interface.

lucaswoj closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment