Circle no longer runs on external contributor PRs

[mourner]

I noticed that since a few days ago, Circle is no longer running on external PR commits. Examples: #3783 #3781. This makes reviewing PRs much harder, so we should investigate what happened.

cc @lucaswoj @jfirebaugh

[lennerd]

I assume this is blocking for my PR right? Are there any schedules for the next release?

[mourner]

@lennerd don't worry about it, it's just an inconvenience on the maintainer side since we have to run the tests manually to verify that they pass. It's not blocking your PR.

[lucaswoj]

I was poking around in CircleCI recently in an attempt to resolve #3603 more elegantly. It's possible I triggered this regression. I will take a look today.

[mollymerp]

I was wondering about that... thanks @lucaswoj!

@lennerd no finite schedule for the next release but we should have one out before the holidays 🎄. thanks again for your awesome contribution!

[lennerd]

Thank you for your awesome peace of software and services! We enjoy using it! :)

[lucaswoj]

This regression is due to a breaking change made by CircleCI in which forked PRs do not trigger builds by default. See https://discuss.circleci.com/t/pull-request-from-forked-repos-are-not-being-tested/8588/3

I have resolved the issue by enabling the "build forked pull requests" setting.