Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style spec validator allows projection.name = 'globe' for GL JS 2.6.0 #12028

Open
AlexanderBelokon opened this issue Jun 21, 2022 · 0 comments
Open

Comments

@AlexanderBelokon
Copy link

The styles-spec's sdk-support field only specifies versions for fields, not for values:

This can lead to users unintentionally marking their styles as supported by GL JS 2.6.0, even though globe projection (which is now the default) was not yet supported at that time.

studio-globe-supported-260

mapbox-gl-js version: 2.9.1

browser: Firefox 101.0.1

Steps to Trigger Behavior

  1. Login to Studio
  2. Create a new style (with globe projection by default)
  3. (optional) Disable atmosphere to prevent warnings about it
  4. Switch Settings -> Supported Mapbox SDK versions -> Mapbox GL JS to 2.6.0
  5. Notice that there are no warnings about projection (or anything at all, if you removed atmosphere) from GL JS

Expected Behavior

A warning about globe projection is displayed

Actual Behavior

No warning is displayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants