Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Use alternative workaround for cafile issue with node v4 #2

Closed
springmeyer opened this issue Jun 15, 2017 · 1 comment
Closed

Use alternative workaround for cafile issue with node v4 #2

springmeyer opened this issue Jun 15, 2017 · 1 comment

Comments

@springmeyer
Copy link
Contributor

I think we can remove https://github.com/mapbox/ci-scripts/blob/master/node/ci-cpp.bat#L38-L46. This is because I found that this problem can be worked around by upgrading node-gyp. See mapbox/node-pre-gyp#209 (comment)

@BergWerkGIS can you please:

  • Confirm that upgrading node-gyp (which should already be being done in the package.json) works around this problem in the repos you've been testing?
  • If so we'll plan to keep node-gyp upgrade in place for node v4 (and not just for node v0.10.x), and this should be documented in the readme for co-scripts
@wilhelmberg
Copy link
Contributor

Removed cafile workaround: 47726e2

Confirm that upgrading node-gyp (which should already be being done in the package.json) works around this problem in the repos you've been testing?

All repositories I've been testing are ✅ on AppVeyor (node-gdal still running as of now).

If so we'll plan to keep node-gyp upgrade in place for node v4 (and not just for node v0.10.x), and this should be documented in the readme for co-scripts

done: https://github.com/mapbox/ci-scripts/tree/master/node

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants