Open
Conversation
Contributor
|
Thank you for your contributions. I added @1ec5 as a reviewer as I believe he has more context. |
Author
|
Any chance to start a review? |
|
I'd love to see this get reviewed and merged. As it stands now, if I want to create an address with custom formatting, I have 2 options (neither are great):
This PR solves this problem in one way. Another option would be to add the address number to |
|
@1ec5 This look ok to me although we need new tests to cover this functionality |
51afbb6 to
dc89764
Compare
Author
|
I've rebased the PR and added, in existing tests, a simple check for street address. Let me know if you have more sample data to test against. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
I would like to add a convenience
streetAddressproperty for MBPlacemark.I have noticed that for
.addressfeaturesnameproperty contains only a street name and the house number is contained inaddressproperty.The
formattedNameproperty already does it correctly (as it is defined as a street address for.addressfeatures), and also handles house number correctly putting it before or after a street name. So I have just extracted this logic into a separate method.For non-address features I use the logic from
addressDictionarywhich looks for an address first inproperties?.addressand thenaddressproperty.