Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign Held Physcannon Entity to Pass into Commander Goal Trace #237

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

AgentAgrimar
Copy link

Within code that passes the held physcannon entity in to ignore when performing a commander goal trace, there is a mapbase-specific addition that checks if the player has a held entity first, but otherwise forgets to assign the held physcannon entity to the local variable, this pull request corrects that.


Does this PR close any issues?

N/A

PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

Copy link
Member

@Blixibon Blixibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this. This code was originally created to make it easier to carry a certain physics object through different parts of Entropy : Zero 2, and I brought it to Mapbase later as a general quality-of-life change. Players would normally carry said phsics object with +USE, so I must not have tested it with the gravity gun at the time.

@Blixibon Blixibon merged commit 8280197 into mapbase-source:develop Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants