Skip to content

Fix CScriptNetMsgHelper::WriteEntity() #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2022
Merged

Fix CScriptNetMsgHelper::WriteEntity() #206

merged 3 commits into from
Oct 22, 2022

Conversation

@samisalreadytaken
Copy link

@samisalreadytaken samisalreadytaken commented Oct 19, 2022 •
edited
Loading

Previously would only write 10 bits, missing indices [1024,2048)

PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

@Blixibon Blixibon added the VScript Mapbase - Involves VScript label Oct 21, 2022
@Blixibon Blixibon merged commit 216ea46 into mapbase-source:develop Oct 22, 2022
@samisalreadytaken samisalreadytaken deleted the fix branch October 22, 2022 15:51
VDeltaGabriel pushed a commit to Project-P2009/p2009_sdk that referenced this pull request Apr 27, 2023
@Blixibon
Merge pull request mapbase-source#206 from samisalreadytaken/fix
e771b67 
Fix CScriptNetMsgHelper::WriteEntity()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Blixibon Blixibon Blixibon approved these changes

Assignees

No one assigned

Labels

VScript Mapbase - Involves VScript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samisalreadytaken @Blixibon