Skip to content

Conversation

@dvdkouril
Copy link
Contributor

Quick sketch of the scenario where you use the cleanup function returned from render() to call cancelAnimationFrame to break the continuously updating frameloop.

I still want to think about whether this is the most minimal and expressive code example (that's why I'm keeping it a draft). There also might be a better way to word the description.

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2024

⚠️ No Changeset found

Latest commit: f55a16c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.36%. Comparing base (12ca2f8) to head (f55a16c).
Report is 97 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   98.45%   97.36%   -1.09%     
==========================================
  Files           8        8              
  Lines         452      494      +42     
==========================================
+ Hits          445      481      +36     
- Misses          7       13       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@manzt manzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment. Thanks for the contribution!

@dvdkouril dvdkouril marked this pull request as ready for review April 12, 2024 13:52
@manzt manzt merged commit f5ab13e into manzt:main Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants